New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 861918 link

Starred by 1 user
Status: Fixed
Owner:
hansberry@chromium.org
Closed: Jul 10
Cc:
█ jlklein@chromium.org
khorimoto@chromium.org
█ jordynass@chromium.org
█ jhawkins@chromium.org
qnnguyen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Smart Lock is not appearing on lock screen

Project Member Reported by hansberry@chromium.org, Jul 9 
Encountered on ToT.

Smart Lock, when enabled, is no longer visible on the lock screen.

I'm unsure how this regression occurred -- I've made significant refactoring changes to Smart Lock recently, but manually verified each
change.

Investigating.

Comment 1 by khorimoto@chromium.org, Jul 9 

Is this with the MultiDevice API flag enabled or disabled? Or both?

Comment 2 by hansberry@chromium.org, Jul 9 

Both.

Comment 3 by hansberry@chromium.org, Jul 10 

This change introduced this breakage: https://chromium-review.googlesource.com/c/chromium/src/+/1117769

Continuing to investigate.

Comment 4 by hansberry@chromium.org, Jul 10

Cc: qnnguyen@chromium.org
+qnnguyen@chromium.org, the author of the change.

Quan, your removal of 'Shell::Get()->login_screen_controller()->OnFocusPod(new_big_user);' in ash/login/ui/lock_contents_view.cc [1] has caused the Smart Lock (internally known as Easy Unlock) icon, which normally displays next to password field on user pods, to no longer appear. It seems the method UpdateEasyUnlockIconForUser() no longer works because the user pod is not focused before it is called.

Attempting to revert the original change.

1) https://chromium-review.googlesource.com/c/chromium/src/+/1117769/14/ash/login/ui/lock_contents_view.cc#b1048

Comment 5 by hansberry@chromium.org, Jul 10 

I've reverted the change; Quan and I spoke offline and will discuss a fix tomorrow.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59b4cd57f908e5644e6de29b9e96dab8670792fa

commit 59b4cd57f908e5644e6de29b9e96dab8670792fa
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Jul 10 20:49:23 2018

Reland "Use arrow keys to navigate through users on Views-based login screen."

This reverts commit c8df89ca5be5c019e100487a0a069c16ab81561c.
This CL adds back the removed OnFocusPod() call in
lock_contents_view.cc, since this is required for the Smart Lock icon to
be displayed next to user password fields.

TBR=xiyuan@chromium.org

Bug:  861918 
Change-Id: Ia025a92cb2b2b2de7f8e0be82d37b1c5ed05359e
Reviewed-on: https://chromium-review.googlesource.com/1131655
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573898}
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/BUILD.gn
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/lock_screen.h
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/login_bubble.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/login_keyboard_test_base.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/login_keyboard_test_base.h
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/login_password_view.h
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/login_public_account_user_view.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/note_action_launch_button_unittest.cc
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/scrollable_users_list_view.cc
[rename] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/views_utils.cc
[rename] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/login/ui/views_utils.h
[modify] https://crrev.com/59b4cd57f908e5644e6de29b9e96dab8670792fa/ash/shelf/login_shelf_view_unittest.cc

Comment 7 by qnnguyen@chromium.org, Jul 10 

This change should allow the smart unlock icon to show up now.

Comment 8 by hansberry@chromium.org, Jul 10

Status: Fixed (was: Started)
►

Sign in to add a comment