New issue
Advanced search Search tips

Issue 861902 link

Starred by 0 users
Status: Fixed
Owner:
oksamyt@chromium.org
Closed: Aug 20
Cc:
reillyg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Merge Device*Dispatcher classes with respective Device*EventPump classes

Project Member Reported by oksamyt@chromium.org, Jul 9 
Since DeviceMotionEventPump and DeviceOrientationEventPump classes are now in blink, the code can be simplified by removing the dispatcher layer and combining the logic into one class.
last_device_*_data member can also be removed since it represents the same data that is stored inside Device*EventPump.
WebDeviceMotionListener can be removed as well along with the third_party/blink/public/platform/modules/device_orientation folder.

Comment 1 by oksamyt@chromium.org, Jul 9

Description: Show this description

Comment 2 by oksamyt@chromium.org, Jul 9

Description: Show this description

Comment 3 by reillyg@chromium.org, Jul 11

Labels: -Type-Bug OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Type-Task
Owner: oksamyt@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by oksamyt@chromium.org, Jul 25

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c1811cbd81496f58535a6a281078cd0f34429f

commit e1c1811cbd81496f58535a6a281078cd0f34429f
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Wed Aug 08 17:33:22 2018

Combine DeviceOrientationEventPump with DeviceOrientationDispatcher

This change moves the logic from DeviceOrientationDispatcher into
DeviceOrientationEventPump and removes DeviceOrientationDispatcher.
DeviceOrientationController now uses DeviceOrientationEventPump directly,
and a separate instance of DeviceOrientationEventPump is created for
every document. Webkit layout tests were updated to reflect this, and
webkit unit tests have been updated to use a MockDeviceOrientationController.

Bug:  861902 
Change-Id: I1c376ec54208abb3fcfb627304f47a4cbd01894d
Reviewed-on: https://chromium-review.googlesource.com/1161446
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581617}
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-event-listeners.html
[delete] https://crrev.com/e320440a8abaa2065fdc66a3d42580e18fff164e/third_party/WebKit/LayoutTests/device_orientation/orientation/multiple-frames.html
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/blink/renderer/modules/device_orientation/BUILD.gn
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/blink/renderer/modules/device_orientation/device_orientation_absolute_controller.cc
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/blink/renderer/modules/device_orientation/device_orientation_absolute_controller.h
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/blink/renderer/modules/device_orientation/device_orientation_controller.cc
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/blink/renderer/modules/device_orientation/device_orientation_controller.h
[delete] https://crrev.com/e320440a8abaa2065fdc66a3d42580e18fff164e/third_party/blink/renderer/modules/device_orientation/device_orientation_dispatcher.cc
[delete] https://crrev.com/e320440a8abaa2065fdc66a3d42580e18fff164e/third_party/blink/renderer/modules/device_orientation/device_orientation_dispatcher.h
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump.cc
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump.h
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump_unittest.cc
[modify] https://crrev.com/e1c1811cbd81496f58535a6a281078cd0f34429f/third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23c7886b96db9544c866d11046fa6f3f386e8796

commit 23c7886b96db9544c866d11046fa6f3f386e8796
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Wed Aug 15 17:50:36 2018

Combine DeviceMotionEventPump with DeviceMotionDispatcher

This change moves the logic from DeviceMotionDispatcher into
DeviceMotionEventPump and removes DeviceMotionDispatcher.
DeviceMotionController now uses DeviceMotionEventPump directly,and a
separate instance of DeviceMotionEventPump is created forevery document.
Webkit layout tests were updated to reflect this, and webkit unit tests
have been updated to use a MockDeviceMotionController.

Bug:  861902 
Change-Id: Ic9a33b26c6c5771a3a7312724f1056ef311ea6a3
Reviewed-on: https://chromium-review.googlesource.com/1167994
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583311}
[modify] https://crrev.com/23c7886b96db9544c866d11046fa6f3f386e8796/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/23c7886b96db9544c866d11046fa6f3f386e8796/third_party/WebKit/LayoutTests/device_orientation/motion/add-child-listener.html
[delete] https://crrev.com/e2c550114f1da73ae2b2e9d1409338bb64845e33/third_party/WebKit/LayoutTests/device_orientation/motion/detached-frame.html
[delete] https://crrev.com/e2c550114f1da73ae2b2e9d1409338bb64845e33/third_party/WebKit/LayoutTests/device_orientation/motion/fire-last-event.html
[modify] https://crrev.com/23c7886b96db9544c866d11046fa6f3f386e8796/third_party/WebKit/LayoutTests/device_orientation/motion/multiple-event-listeners.html
[modify] https://crrev.com/23c7886b96db9544c866d11046fa6f3f386e8796/third_party/blink/renderer/modules/device_orientation/BUILD.gn
[modify] https://crrev.com/23c7886b96db9544c866d11046fa6f3f386e8796/third_party/blink/renderer/modules/device_orientation/device_motion_controller.cc
[modify] https://crrev.com/23c7886b96db9544c866d11046fa6f3f386e8796/third_party/blink/renderer/modules/device_orientation/device_motion_controller.h
[delete] https://crrev.com/e2c550114f1da73ae2b2e9d1409338bb64845e33/third_party/blink/renderer/modules/device_orientation/device_motion_dispatcher.cc
[delete] https://crrev.com/e2c550114f1da73ae2b2e9d1409338bb64845e33/third_party/blink/renderer/modules/device_orientation/device_motion_dispatcher.h
[modify] https://crrev.com/23c7886b96db9544c866d11046fa6f3f386e8796/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.cc
[modify] https://crrev.com/23c7886b96db9544c866d11046fa6f3f386e8796/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.h
[modify] https://crrev.com/23c7886b96db9544c866d11046fa6f3f386e8796/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92a99f2c3b69b716c59dbd834612a6c3ea6e427

commit c92a99f2c3b69b716c59dbd834612a6c3ea6e427
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Fri Aug 17 17:29:50 2018

Remove unused references to WebDevice*Listener

This change removes the listener template parameter from
DeviceSensorEventPump and any dependencies on WebDevice*Listener.

Bug:  861902 
Change-Id: I91ec5f709eaa74acca35fa884e971f3f60e8f294
Reviewed-on: https://chromium-review.googlesource.com/1176199
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584111}
[modify] https://crrev.com/c92a99f2c3b69b716c59dbd834612a6c3ea6e427/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.h
[modify] https://crrev.com/c92a99f2c3b69b716c59dbd834612a6c3ea6e427/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump.h
[modify] https://crrev.com/c92a99f2c3b69b716c59dbd834612a6c3ea6e427/third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h

Comment 9 by oksamyt@chromium.org, Aug 20

Status: Fixed (was: Started)
►

Sign in to add a comment