New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 861887 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove relocation_packer

Project Member Reported by agrieve@chromium.org, Jul 9

Issue description

Since lld supports packed relocations natively, there is no reason to maintain support for relocation_packer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c179d7021380ae62620b08fc60495977209a7a0

commit 7c179d7021380ae62620b08fc60495977209a7a0
Author: Andrew Grieve <agrieve@chromium.org>
Date: Wed Jul 11 03:05:03 2018

Android: Delete relocation_packer (obsolete with lld)

Removes the tool from third_party, as well as gni references to it.

This does not remove the logic from the "stack" script, since that may
still be useful for running on stacks from older chrome binaries.

Bug:  861887 
Change-Id: Ifc5372846d41f0e8b013524dd463eb023af1ec00
Reviewed-on: https://chromium-review.googlesource.com/1130005
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574052}
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/BUILD.gn
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/build/android/gyp/create_test_runner_script.py
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/build/android/gyp/pack_relocations.py
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/build/android/gyp/write_build_config.py
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/build/android/pylib/symbols/stack_symbolizer.py
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/build/android/test_runner.py
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/build/android/tombstones.py
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/build/config/android/internal_rules.gni
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/build/config/android/rules.gni
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/third_party/android_platform/BUILD.gn
[modify] https://crrev.com/7c179d7021380ae62620b08fc60495977209a7a0/third_party/android_platform/README.chromium
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/Android.mk
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/LICENSE
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/DEPS
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/debug.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/debug.h
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/debug_unittest.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/delta_encoder.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/delta_encoder.h
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/delta_encoder_unittest.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/elf_file.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/elf_file.h
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/elf_file_unittest.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/elf_traits.h
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/main.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/nativehelper/ScopedFd.h
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/packer.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/packer.h
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/packer_unittest.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/run_all_unittests.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/sleb128.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/sleb128.h
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/src/sleb128_unittest.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs.cc
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm32.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm32_packed.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64_packed.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32_packed.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32_packed.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64_packed.so
[delete] https://crrev.com/655ee02dff70755636fc0919c1e03f8320c6e50f/third_party/android_platform/config.gni

Cc: digit@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment