New issue
Advanced search Search tips

Issue 861886 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clang Tool Refactoring produces uncompilable code

Project Member Reported by yannic.b...@gmail.com, Jul 9

Issue description

In https://chromium-review.googlesource.com/c/chromium/src/+/1123819 we found that

helper_->context()->RegisterServiceWorker(
    GURL(kScript1), options1,
    base::AdaptCallbackForRepeating(
        base::BindOnce(&RegisterServiceWorkerCallback, &called_1,
                       &sw_registration_id_1_)));

will be rewritten to

helper_->context()->RegisterServiceWorker(
    GURL(kScript1), options1 base::BindOnce(&RegisterServiceWorkerCallback, &called_1,
                       &sw_registration_id_1_));

if we replace "base::AdaptCallbackForRepeating(" with the empty string ""
(the comma after option1 is missing).
Using " " as replacement produces correct code.
 
Cc: yannic.b...@gmail.com

Sign in to add a comment