New issue
Advanced search Search tips

Issue 861883 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill Views] Labels change color on hover in GTK+

Project Member Reported by tmartino@chromium.org, Jul 9

Issue description

Upon triggering Autofill, the labels all appear correctly. However, hovering over a row causes its subtext label (i.e., the disambiguation text) to turn black--and even ending the hover effect (moving to a different row) does not turn it back to the proper grey.

Only observed on Linux with GTK+; tests on Mac, Win, and Linux Classic all work as intended.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27ecaa37e93ad2a0eea2ec4a4eac69742f576ffd

commit 27ecaa37e93ad2a0eea2ec4a4eac69742f576ffd
Author: Tommy Martino <tmartino@chromium.org>
Date: Mon Jul 09 23:45:24 2018

[Autofill Views] Fixing Label Colors

This change solves two problems related to font colors:
* Changes passed down from UX have requested the use of the subtext/hint
  color for all text in footer rows.
* A bug causes text colors to change (permanently) to incorrect values
  when hover styles are applied. This was observed on Linux under GTK+
  theme only. We don't need to modify text colors during RefreshStyle
  anyway, so the simplest fix is to define these at initialization and
  not touch them again.

Change-Id: I80d2de91bb7067b3dc8fea6f369c83658e15c22a
Bug:  861883 ,  859887 
Reviewed-on: https://chromium-review.googlesource.com/1130015
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573532}
[modify] https://crrev.com/27ecaa37e93ad2a0eea2ec4a4eac69742f576ffd/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Status: Fixed (was: Started)

Sign in to add a comment