Unmanaged pools don't get firmware updates, but some of them should. |
|||||
Issue descriptionSee b/111208707#comment11
,
Jul 9
For historical DUT reference for devices in pool:crosperf chromeos2-row3-rack8-host3 * Probably was in this pool * Google_Grunt.10750.0.0 chromeos2-row3-rack11-host11 * Currently in this pool * Google_Grunt.10709.0.0 localhost ~ # chromeos-firmwareupdate -m autoupdate Model is grunt Starting Google_Grunt firmware updater v4 (autoupdate)... - Updater package: [Google_Grunt.10833.0.0 / EC:grunt_v1.1.8730-dc5ef9e35] - Current system: [RO:Google_Grunt.10709.0.0 , ACT:Google_Grunt.10709.0.0 / EC:grunt_v1.1.8453-11bd4c0f4] - Write protection: Hardware: ON, Software: Main=off autoupdate(recovery): update RO+RW * invoke: flashrom -p host --fast-verify -w models/grunt/bios.bin autoupdate(recovery): update ec/RO+RW * invoke: flashrom -p ec --fast-verify -w models/grunt/ec.bin autoupdate(recovery): EC may be restored or updated in next boot. Firmware update (autoupdate) completed. johndhong@phobrz:~$ ssh chromeos2-row3-rack8-host3 localhost ~ # crossystem fwid Google_Grunt.10833.0.0
,
Jul 9
Oh, right, there are two performance pools:
performance
crosperf
Both of them need to get firmware updates.
,
Jul 9
This problem is bigger than pool:crosperf and pool:performance. The DUTs in wifi cells are also affected. Probably, they should be getting updates, too. The only pools that categorically should not get firmware updates are the FAFT and stress pools; the former for reasons that should be mostly obvious, the latter because its owner specifically requested that the stress pools not be updated. To fix this, I expect we may want to move from a whitelist of "update only these pools" to a blacklist of "update every pool but these."
,
Jul 11
... and DUTs in chameleon pools are affected. See crbug.com/862372#c7
,
Jul 11
,
Jul 13
I spoke with dchan@ and kmshelton@, and we've concluded that
only the FAFT pools should still be excluded from automated
firmware management.
This CL will make it so:
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1137094
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fc46583ab61fd6f55bb6541609bb6e10a8b5b230 commit fc46583ab61fd6f55bb6541609bb6e10a8b5b230 Author: Richard Barnette <jrbarnette@chromium.org> Date: Wed Jul 18 00:30:36 2018 [autotest] Expand automatic firmware update to all non-FAFT pools Previously, automated firmware updates was restricted to the managed pools. That prevented various pools from getting updates, including especially performance and chameleon pools. Previously, this was done for the sake of the FAFT and stress pools, both of which needed to manage firmware versions explicitly. The stress pools are no longer used, so only FAFT should still be excluded from automated firmware version management. So, this changes the rule from "only managed pools" to "all pools except for FAFT." BUG= chromium:861867 TEST=None Change-Id: I0994dba8785aafd543c45cdc0d5f3b0aa9f75574 Reviewed-on: https://chromium-review.googlesource.com/1137094 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: danny chan <dchan@chromium.org> [modify] https://crrev.com/fc46583ab61fd6f55bb6541609bb6e10a8b5b230/server/hosts/cros_firmware.py
,
Jul 18
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by johndhong@chromium.org
, Jul 9