New issue
Advanced search Search tips
Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 861853: add support for presenting vulkan-rendered framebuffers on scenic

Reported by spang@chromium.org, Jul 9 2018 Project Member

Issue description

Make content able to own the display on scenic using a new backend ui/ozone/platform/scenic.
 

Comment 1 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Comment 2 by rjkroege@chromium.org, Aug 7

Labels: -Pri-2 Pri-3

Comment 3 by bugdroid1@chromium.org, Aug 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1db5bf4ff0a83f99d9a029515fe733b9f1946c2d

commit 1db5bf4ff0a83f99d9a029515fe733b9f1946c2d
Author: Michael Spang <spang@chromium.org>
Date: Mon Aug 27 17:14:46 2018

ozone: scenic: Move rectangle resource from ScenicWindowCanvas to ScenicWindow

The shape and location of the window is independent of rendering method,
so move those resources to ScenicWindow where they can be used for both
software & vulkan rendering paths.

Bug: 861853
Test: ozone_demo --ozone-platform=scenic --enable-vulkan (with full series)

Change-Id: I728d9d6fc173dd629b319a5de14072c60156d695

Reviewed-on: https://chromium-review.googlesource.com/1188970
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586292}
[modify] https://crrev.com/1db5bf4ff0a83f99d9a029515fe733b9f1946c2d/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/1db5bf4ff0a83f99d9a029515fe733b9f1946c2d/ui/ozone/platform/scenic/scenic_window.h
[modify] https://crrev.com/1db5bf4ff0a83f99d9a029515fe733b9f1946c2d/ui/ozone/platform/scenic/scenic_window_canvas.cc
[modify] https://crrev.com/1db5bf4ff0a83f99d9a029515fe733b9f1946c2d/ui/ozone/platform/scenic/scenic_window_canvas.h

Comment 4 by spang@chromium.org, Aug 27

Labels: -Pri-3 Pri-2
Summary: add support for presenting vulkan-rendered framebuffers on scenic (was: add support for presenting vulkan-rendered framebuffers on zircon)

Comment 5 by bugdroid1@chromium.org, Aug 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8687ed392293f9d56adbf79f3d016efbfd018e79

commit 8687ed392293f9d56adbf79f3d016efbfd018e79
Author: Michael Spang <spang@chromium.org>
Date: Mon Aug 27 17:40:42 2018

ozone: scenic: Enable vulkan in the sandbox

This is necessary to use the GPU through vulkan.

Bug: 861853
Test: ozone_demo --ozone-platform=scenic --enable-vulkan (with full series)

Change-Id: I7eac180b9c8592f6f5c10799fa845331bda16ec4
Reviewed-on: https://chromium-review.googlesource.com/1188971
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586300}
[modify] https://crrev.com/8687ed392293f9d56adbf79f3d016efbfd018e79/build/config/fuchsia/sandbox_policy
[modify] https://crrev.com/8687ed392293f9d56adbf79f3d016efbfd018e79/build/config/fuchsia/testing_sandbox_policy

Comment 6 by bugdroid1@chromium.org, Aug 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef0b4a274c45d90d63fed8947835416a3e775ec4

commit ef0b4a274c45d90d63fed8947835416a3e775ec4
Author: Michael Spang <spang@chromium.org>
Date: Mon Aug 27 17:57:18 2018

ozone: demo: Add support for passing fuchsia view owner request

Running on scenic requires passing a
fidl::InterfaceRequest<fuchsia::ui::viewsv1token::ViewOwner> to
CreatePlatformWindow().

Bug: 861853
Test: ozone_demo --ozone-platform=scenic --enable-vulkan (with full series)

Change-Id: I948a4408d64dcb8fef1ec28a55437a48e6ec4a54
Reviewed-on: https://chromium-review.googlesource.com/1188973
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586310}
[modify] https://crrev.com/ef0b4a274c45d90d63fed8947835416a3e775ec4/ui/ozone/demo/BUILD.gn
[modify] https://crrev.com/ef0b4a274c45d90d63fed8947835416a3e775ec4/ui/ozone/demo/demo_window.cc
[modify] https://crrev.com/ef0b4a274c45d90d63fed8947835416a3e775ec4/ui/ozone/platform/scenic/scenic_window_canvas.cc

Comment 7 by bugdroid1@chromium.org, Sep 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/058241f944fb9248c51a3750208b0db53b3e2e5b

commit 058241f944fb9248c51a3750208b0db53b3e2e5b
Author: Michael Spang <spang@chromium.org>
Date: Wed Sep 05 21:36:49 2018

ozone: scenic: Enable vulkan presentation to scenic via magma surface

Using the VK_LAYER_GOOGLE_image_pipe_swapchain layer we can create a
swapchain for an image pipe and assign it as the texture of a scenic
window.

This does not work from the viz process yet as we would need to plumb the
image pipe handle over from the browser using FIDL or mojo. Rendering
needs to be done from the UI thread via VulkanBrowserCompositorOutputSurface
or a test app such as ozone_demo.

This also will not work until vulkan synchronization is fixed, see
https://crbug.com/877684

Bug: 861853
Test: content_shell --ozone-platform=scenic --enable-vulkan --disable-gpu

Change-Id: I79ac045c6d6deb20f49023c8e8e9492631700703
Reviewed-on: https://chromium-review.googlesource.com/1188974
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589008}
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/build/config/fuchsia/build_manifest.py
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/gpu/vulkan/BUILD.gn
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/gpu/vulkan/vulkan_instance.cc
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/gpu/vulkan/vulkan_instance.h
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/gpu/vulkan/x/vulkan_implementation_x11.cc
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/third_party/fuchsia-sdk/BUILD.gn
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/drm/gpu/vulkan_implementation_gbm.cc
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/scenic_session.cc
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/scenic_session.h
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/scenic_surface_factory.cc
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/scenic_surface_factory.h
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/scenic_window.h
[add] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/vulkan_implementation_scenic.cc
[add] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/vulkan_implementation_scenic.h
[add] https://crrev.com/058241f944fb9248c51a3750208b0db53b3e2e5b/ui/ozone/platform/scenic/vulkan_magma.h

Comment 8 by bugdroid1@chromium.org, Sep 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/802f700353ac09f9b6d2aa50f8d72c1e886a96b2

commit 802f700353ac09f9b6d2aa50f8d72c1e886a96b2
Author: Michael Spang <spang@chromium.org>
Date: Tue Sep 18 18:06:47 2018

ozone: demo: Defer renderer creation until nonzero size

Fuchsia platform windows are initially 0x0 and this causes vulkan surface
creation to crash. Defer creating a renderer until we have a nonempty
size.

Bug: 861853
Test: run_ozone_demo --ozone-platform=scenic --enable-vulkan

Change-Id: I74e14ed07ab47ebc22730b40cf36217e9ae4873a
Reviewed-on: https://chromium-review.googlesource.com/1229162
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592110}
[modify] https://crrev.com/802f700353ac09f9b6d2aa50f8d72c1e886a96b2/ui/ozone/demo/demo_window.cc
[modify] https://crrev.com/802f700353ac09f9b6d2aa50f8d72c1e886a96b2/ui/ozone/demo/demo_window.h

Comment 9 by bugdroid1@chromium.org, Sep 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7679bb891e6c5b2b82e51dba59c7e47640a7ef2d

commit 7679bb891e6c5b2b82e51dba59c7e47640a7ef2d
Author: Michael Spang <spang@chromium.org>
Date: Tue Sep 18 19:00:50 2018

fuchsia: Add vulkan loader service to sandbox policy

Since 57a19db65282 ("[fuchsia] Whitelist required Fuchsia services in
component manifest.") vulkan fails to initialize. Fix it by adding
the vulkan loader service to the policy.

Bug: 861853
Test: content_shell --ozone-platform=scenic --enable-vulkan --disable-gpu

Change-Id: I38c11f32e0a0dd8b914184a16198c023877a0572
Reviewed-on: https://chromium-review.googlesource.com/1228488
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592126}
[modify] https://crrev.com/7679bb891e6c5b2b82e51dba59c7e47640a7ef2d/build/config/fuchsia/testing_sandbox_policy
[modify] https://crrev.com/7679bb891e6c5b2b82e51dba59c7e47640a7ef2d/webrunner/app/sandbox_policy

Comment 10 by bugdroid1@chromium.org, Sep 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a016d40a0ee396cca137eb84ba89a525815dd438

commit a016d40a0ee396cca137eb84ba89a525815dd438
Author: Michael Spang <spang@chromium.org>
Date: Tue Sep 18 22:20:54 2018

ozone: demo: Rewrite VulkanRenderer post VulkanRenderPass deprecation

The vulkan rendering code in ozone_demo uses code which has been removed
such as gpu::VulkanSwapChain and gpu::VulkanImageView. Rewrite it to
manage its own image views, render passes, and framebuffers just like
VulkanOverlayRenderer has to.

Bug: 861853
Test: ozone_demo --ozone-platform=x11 --enable-vulkan

Change-Id: I358912b02a11d902803cc0a0682da769b47a5a65
Reviewed-on: https://chromium-review.googlesource.com/1228959
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592225}
[modify] https://crrev.com/a016d40a0ee396cca137eb84ba89a525815dd438/gpu/vulkan/vulkan_surface.h
[modify] https://crrev.com/a016d40a0ee396cca137eb84ba89a525815dd438/gpu/vulkan/vulkan_swap_chain.h
[modify] https://crrev.com/a016d40a0ee396cca137eb84ba89a525815dd438/ui/ozone/demo/simple_renderer_factory.cc
[modify] https://crrev.com/a016d40a0ee396cca137eb84ba89a525815dd438/ui/ozone/demo/vulkan_overlay_renderer.cc
[modify] https://crrev.com/a016d40a0ee396cca137eb84ba89a525815dd438/ui/ozone/demo/vulkan_overlay_renderer.h
[modify] https://crrev.com/a016d40a0ee396cca137eb84ba89a525815dd438/ui/ozone/demo/vulkan_renderer.cc
[modify] https://crrev.com/a016d40a0ee396cca137eb84ba89a525815dd438/ui/ozone/demo/vulkan_renderer.h

Comment 11 by bugdroid1@chromium.org, Sep 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3c9ed0efe2ade7757607bcf356712883c315450

commit f3c9ed0efe2ade7757607bcf356712883c315450
Author: Michael Spang <spang@chromium.org>
Date: Wed Sep 19 17:13:13 2018

ozone: Enable vulkan by default

Vulkan is enabled by default on Linux desktop (X11) builds. Enable it on
ozone as well to make sure we have build coverage.

Bug: 861853
Test: compile
Change-Id: I7c15e365b2a4cfc7160847457ce9bf46a3f12f1e
Reviewed-on: https://chromium-review.googlesource.com/1229233
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592451}
[modify] https://crrev.com/f3c9ed0efe2ade7757607bcf356712883c315450/gpu/vulkan/features.gni
[modify] https://crrev.com/f3c9ed0efe2ade7757607bcf356712883c315450/gpu/vulkan/init/vulkan_factory.cc

Comment 12 by spang@chromium.org, Sep 19

Description: Show this description

Comment 13 by bugdroid1@chromium.org, Sep 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5858fb90ed1e3314518316bcaa023cf1599f62

commit 6a5858fb90ed1e3314518316bcaa023cf1599f62
Author: Michael Spang <spang@chromium.org>
Date: Wed Sep 19 18:33:17 2018

fuchsia: Enable vulkan by default

Bug: 861853
Test: compile
Change-Id: Ia9eacbe863736235c64ccbdadaf3f8feaffdd3ee
Reviewed-on: https://chromium-review.googlesource.com/1234374
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592488}
[modify] https://crrev.com/6a5858fb90ed1e3314518316bcaa023cf1599f62/gpu/vulkan/features.gni

Comment 14 by bugdroid1@chromium.org, Sep 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/424dfd0e97288afc91744841bfede2496cc66db5

commit 424dfd0e97288afc91744841bfede2496cc66db5
Author: Michael Spang <spang@chromium.org>
Date: Wed Sep 19 22:30:31 2018

Revert "ozone: Enable vulkan by default"

This reverts commit f3c9ed0efe2ade7757607bcf356712883c315450.

Reason for revert: breaks Linux Chromium OS ASan LSan Tests

Bug:  887048 

Original change's description:
> ozone: Enable vulkan by default
> 
> Vulkan is enabled by default on Linux desktop (X11) builds. Enable it on
> ozone as well to make sure we have build coverage.
> 
> Bug: 861853
> Test: compile
> Change-Id: I7c15e365b2a4cfc7160847457ce9bf46a3f12f1e
> Reviewed-on: https://chromium-review.googlesource.com/1229233
> Commit-Queue: Michael Spang <spang@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Chris Blume <cblume@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592451}

TBR=spang@chromium.org,piman@chromium.org,cblume@chromium.org

Change-Id: I6a95fdfdb742e4a876382c72b212bacd2b601c23
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 861853
Reviewed-on: https://chromium-review.googlesource.com/1235194
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592579}
[modify] https://crrev.com/424dfd0e97288afc91744841bfede2496cc66db5/gpu/vulkan/features.gni
[modify] https://crrev.com/424dfd0e97288afc91744841bfede2496cc66db5/gpu/vulkan/init/vulkan_factory.cc

Comment 15 by bugdroid1@chromium.org, Sep 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7bd6f8bb01bab601d861c8ab312f4b7052816b7

commit e7bd6f8bb01bab601d861c8ab312f4b7052816b7
Author: Michael Spang <spang@chromium.org>
Date: Wed Sep 19 23:15:03 2018

gpu: Move vulkan init after ozone init

Move gpu::CreateVulkanImplementation() call after InitializeForGPU() so
that it can work under ozone builds. Prior to InitializeForGPU(), there's
no surface factory and attempting to initialize vulkan will simply crash.

      (2) gn gen out/linux_ozone_rel --args='use_ozone=true is_debug=false'
      (3) ./out/linux_ozone_rel/content_shell --enable-vulkan

Bug: 861853
Test: (1) apply penghuang's WIP vulkan oop-d patches
Change-Id: I85b04d1cb366afff075dc86c1698caa6e67f93f0
Reviewed-on: https://chromium-review.googlesource.com/1234222
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592595}
[modify] https://crrev.com/e7bd6f8bb01bab601d861c8ab312f4b7052816b7/gpu/ipc/service/gpu_init.cc

Comment 16 by bugdroid1@chromium.org, Oct 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff013ede39f67bb7d400946e9761d06d28ee40b4

commit ff013ede39f67bb7d400946e9761d06d28ee40b4
Author: Michael Spang <spang@chromium.org>
Date: Fri Oct 12 22:38:23 2018

ozone: scenic: Initialize device pixel ratio in ScenicWindow

When the view properties event arrives before the view metrics event, we
get a wildly incorrect surface size due to use of an unitialized scale
factor.

We're already checking if it's nonzero before deciding the size, so
initialize it to zero so that this check can work.

Bug: 861853
Test: run_ozone_demo --ozone-platform=scenic --enable-vulkan

Change-Id: I6049e05992b1041ee1f63b1f293f1ac2013c82b0

Reviewed-on: https://chromium-review.googlesource.com/c/1279286
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599385}
[modify] https://crrev.com/ff013ede39f67bb7d400946e9761d06d28ee40b4/ui/ozone/platform/scenic/scenic_window.h

Comment 17 by sergeyu@chromium.org, Nov 9

Cc: sergeyu@chromium.org

Comment 18 by rjkroege@chromium.org, Nov 12

Labels: Proj-Vulkanize

Comment 19 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d3237485188aa3f3c2fbf885003d6ce1b3e9dd3

commit 5d3237485188aa3f3c2fbf885003d6ce1b3e9dd3
Author: Michael Spang <spang@chromium.org>
Date: Mon Nov 12 20:10:24 2018

ozone: scenic: Use IO message loop for GPU

This is necessary in order to be able to call FIDL interfaces from the
GPU thread.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan

Change-Id: I1f7b0f2957a810745a83ce1cf36327467e6ea448

Reviewed-on: https://chromium-review.googlesource.com/c/1330290
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607314}
[modify] https://crrev.com/5d3237485188aa3f3c2fbf885003d6ce1b3e9dd3/ui/ozone/platform/scenic/ozone_platform_scenic.cc

Comment 20 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/792bd337d4c02236bd0174ce3f44203353fb6667

commit 792bd337d4c02236bd0174ce3f44203353fb6667
Author: Michael Spang <spang@chromium.org>
Date: Mon Nov 12 21:09:16 2018

ozone: scenic: Add missing Present() call to UpdateSize()

When using vulkan, there is no per-frame Present() call to the window's
scenic session. We need to make sure to call present after a size update
to commit the new size.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan
Change-Id: I7d2788ae6ff641908a10a02d837bea223af6a1ca
Reviewed-on: https://chromium-review.googlesource.com/c/1330291
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607330}
[modify] https://crrev.com/792bd337d4c02236bd0174ce3f44203353fb6667/ui/ozone/platform/scenic/scenic_window.cc

Comment 21 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb39a2150be0007063044e3501353e12f89ad67c

commit fb39a2150be0007063044e3501353e12f89ad67c
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Nov 13 03:41:01 2018

Improve initialization failure handling in VulkanInstance

In debug builds VulkanInstance::Destroy() was trying to call
vkDestroyDebugReportCallbackEXT and it would DCHECK after a failure to
find that function. That would happen even if Destroy() is called in
after a failed attempt to load Vulkan libs. It doesn't make sense to
DCHECK in that case. Also now vkDestroyDebugReportCallbackEXT() is
called only if debug callbacks were created successfully.

Bug: 861853
Change-Id: I03bbdbb1793ddb74f07352f354d0f70ee739a93a
Reviewed-on: https://chromium-review.googlesource.com/c/1332263
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607476}
[modify] https://crrev.com/fb39a2150be0007063044e3501353e12f89ad67c/gpu/vulkan/vulkan_instance.cc

Comment 22 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3cca903d946b8445d91fd8e6a3fa947452ab23

commit 2f3cca903d946b8445d91fd8e6a3fa947452ab23
Author: Michael Spang <spang@chromium.org>
Date: Mon Nov 19 21:01:22 2018

ozone: scenic: Scale entity so that texture size can be fixed at 1x1

This will allow the GPU process to avoid worrying about the display scale
when setting up its Scenic resources.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan

Change-Id: I19571bd55ccbc004c42230ec7aba98dcd5370d11
Reviewed-on: https://chromium-review.googlesource.com/c/1342815
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609431}
[modify] https://crrev.com/2f3cca903d946b8445d91fd8e6a3fa947452ab23/ui/ozone/platform/scenic/scenic_window.cc

Comment 23 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba8697a0cc653babcf208e4e918ec29f77823a2b

commit ba8697a0cc653babcf208e4e918ec29f77823a2b
Author: Michael Spang <spang@chromium.org>
Date: Mon Nov 19 21:37:26 2018

gpu: Allow RasterCommandBufferStub to initialize on Fuchsia

This removes a NOTIMPLEMENTED() in RasterCommandBufferStub::Initialize()
so that we can use that code on Fuchsia.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan
Change-Id: Iadc55361d19165ecb6129675c8d569406484bd2f
Reviewed-on: https://chromium-review.googlesource.com/c/1343239
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609446}
[modify] https://crrev.com/ba8697a0cc653babcf208e4e918ec29f77823a2b/gpu/ipc/service/raster_command_buffer_stub.cc

Comment 24 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2753a25d557ee736ed05129c3a1978bc5bd44a2

commit d2753a25d557ee736ed05129c3a1978bc5bd44a2
Author: Michael Spang <spang@chromium.org>
Date: Mon Nov 19 22:14:08 2018

ozone: scenic: Enable SwiftShader

Parts of chromium still depend on a GLES implementation, even when vulkan
is in use. To avoid crashes related to those components, enable
swiftshader temporarily.

Bug: 861853, 897208
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan

Change-Id: I87453e066de39f188a8db28079d80f058fcc4e1c
Reviewed-on: https://chromium-review.googlesource.com/c/1343240
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609461}
[modify] https://crrev.com/d2753a25d557ee736ed05129c3a1978bc5bd44a2/ui/ozone/platform/scenic/scenic_surface_factory.cc
[modify] https://crrev.com/d2753a25d557ee736ed05129c3a1978bc5bd44a2/ui/ozone/platform/scenic/scenic_surface_factory.h

Comment 25 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2c42e851e5a337e0132865270b4d14ff04b44ef

commit e2c42e851e5a337e0132865270b4d14ff04b44ef
Author: Michael Spang <spang@chromium.org>
Date: Wed Nov 28 19:50:53 2018

ozone: scenic: Move vulkan surface resources out of browser's Scenic session

This creates a new session with the system compositor (Scenic) and uses
it to create the vulkan surface resources. This is necessary in order to
support vulkan surfaces from the GPU process, since the browser Scenic
session will not be accessible there.

In order for this to work, we need to be able to run platform code when a
gpu::VulkanSurface is destroyed. To accomplish this, this adds a
destruction callback to gpu::VulkanSurface which cleans up the Scenic
resources associated with the surface.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan

Change-Id: If08c25746ba73569afae63040a7f6551861eeaad
Reviewed-on: https://chromium-review.googlesource.com/c/1343238
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611830}
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/gpu/vulkan/android/vulkan_implementation_android.cc
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/gpu/vulkan/vulkan_surface.cc
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/gpu/vulkan/vulkan_surface.h
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/gpu/vulkan/win32/vulkan_implementation_win32.cc
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/gpu/vulkan/x/vulkan_implementation_x11.cc
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/ui/ozone/platform/scenic/scenic_surface_factory.cc
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/ui/ozone/platform/scenic/scenic_surface_factory.h
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/ui/ozone/platform/scenic/scenic_window.h
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/ui/ozone/platform/scenic/scenic_window_canvas.cc
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/ui/ozone/platform/scenic/scenic_window_canvas.h
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/ui/ozone/platform/scenic/vulkan_implementation_scenic.cc
[modify] https://crrev.com/e2c42e851e5a337e0132865270b4d14ff04b44ef/ui/ozone/platform/scenic/vulkan_implementation_scenic.h

Comment 26 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82d8ee1e070100260963c8d76f23dcd2884099c9

commit 82d8ee1e070100260963c8d76f23dcd2884099c9
Author: Michael Spang <spang@chromium.org>
Date: Wed Nov 28 21:49:37 2018

ozone: scenic: Enable vulkan VizDisplayCompositor with scenic

This enables GPU process VulkanSurfaces to present to Scenic views. Each
surface sends a message to the browser over mojo asking to export a node
to attach the surface resources to. Once this export occurs, the surface
contents will be visible in the global scene.

Bug: 861853
Test: run_content_shell \
  --enable-features=VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList,UiGpuRasterization,OzoneDrmMojo
  --enable-oop-rasterization --enable-vulkan --enable-gpu-rasterization \
  --enable-raster-to-sk-image --use-raster-context-provider \
  --force-gpu-rasterization --use-gl=swiftshader --no-sandbox \
  --disable-gpu-sandbox

Change-Id: Ib39c7f2a6bcb833fbd2cd3e0718229efb69ca940

Reviewed-on: https://chromium-review.googlesource.com/c/1343277
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611883}
[modify] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/content/public/app/mojo/content_gpu_manifest.json
[modify] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/DEPS
[modify] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[add] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/scenic_gpu_host.cc
[add] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/scenic_gpu_host.h
[add] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/scenic_gpu_service.cc
[add] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/scenic_gpu_service.h
[modify] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/scenic_surface_factory.cc
[modify] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/scenic_surface_factory.h
[modify] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/vulkan_implementation_scenic.cc
[modify] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/platform/scenic/vulkan_implementation_scenic.h
[modify] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/public/interfaces/BUILD.gn
[add] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/public/interfaces/scenic_gpu_host.mojom
[add] https://crrev.com/82d8ee1e070100260963c8d76f23dcd2884099c9/ui/ozone/public/interfaces/scenic_gpu_service.mojom

Comment 27 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6152020cc89d3c52df9b72da9ae914991bad894

commit b6152020cc89d3c52df9b72da9ae914991bad894
Author: Michael Spang <spang@chromium.org>
Date: Wed Nov 28 23:47:47 2018

ozone: scenic: Remove stub GpuPlatformSupportHost

This was replaced by ScenicGpuHost but not removed.

Bug: 861853
Test: compile
Change-Id: I6c982b87a6f9d64abb975ebfd4ac2d024333d503
Reviewed-on: https://chromium-review.googlesource.com/c/1354480
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611942}
[modify] https://crrev.com/b6152020cc89d3c52df9b72da9ae914991bad894/ui/ozone/platform/scenic/ozone_platform_scenic.cc

Comment 28 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec925c890f0128e3875272e96a72eda351ba64dc

commit ec925c890f0128e3875272e96a72eda351ba64dc
Author: Michael Spang <spang@chromium.org>
Date: Thu Nov 29 02:45:20 2018

ozone: scenic: Require mojo

This fixes a crash if you don't pass --enable-features=OzoneDrmMojo.
Oops.

Bug: 861853
Test: run_content_shell with no arguments
Change-Id: I5408ca9323b8481ed6c5f092172b75f2181c94fe
Reviewed-on: https://chromium-review.googlesource.com/c/1354502
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612002}
[modify] https://crrev.com/ec925c890f0128e3875272e96a72eda351ba64dc/ui/ozone/platform/scenic/ozone_platform_scenic.cc

Comment 29 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da02fb9b376e9607afe91e887164e58d607eb2bb

commit da02fb9b376e9607afe91e887164e58d607eb2bb
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Nov 30 01:48:30 2018

Fuchsia: Moved SandboxPolicyFuchsia to service/service_manager/sandbox

This will allow to reuse the class in //webrunner when starting context
process.

Bug: 861853
Change-Id: I499850a7ba8df4b73e5f71b6a61568a5cfca1e6b
Reviewed-on: https://chromium-review.googlesource.com/c/1355764
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612494}
[modify] https://crrev.com/da02fb9b376e9607afe91e887164e58d607eb2bb/content/browser/BUILD.gn
[modify] https://crrev.com/da02fb9b376e9607afe91e887164e58d607eb2bb/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/da02fb9b376e9607afe91e887164e58d607eb2bb/content/browser/child_process_launcher_helper_fuchsia.cc
[modify] https://crrev.com/da02fb9b376e9607afe91e887164e58d607eb2bb/content/common/BUILD.gn
[modify] https://crrev.com/da02fb9b376e9607afe91e887164e58d607eb2bb/services/service_manager/sandbox/BUILD.gn
[add] https://crrev.com/da02fb9b376e9607afe91e887164e58d607eb2bb/services/service_manager/sandbox/fuchsia/OWNERS
[rename] https://crrev.com/da02fb9b376e9607afe91e887164e58d607eb2bb/services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.cc
[rename] https://crrev.com/da02fb9b376e9607afe91e887164e58d607eb2bb/services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.h

Comment 30 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60

commit df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Dec 07 01:03:04 2018

Fuchsia: Use SandboxPolicyFuchsia for context process.

1. Updated SandboxPolicyFuchsia to support sandbox policy for context
   process.
2. Updated ContextProviderImpl to use SandboxPolicyFuchsia.
3. SandboxPolicyFuchsia now provides Vulkan access to Context process.

Bug: 861853
Change-Id: If0e72e424bbadc0199a1c06e7c27e5df4245c7c7
Reviewed-on: https://chromium-review.googlesource.com/c/1354563
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614516}
[modify] https://crrev.com/df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60/services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.cc
[modify] https://crrev.com/df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60/services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.h
[modify] https://crrev.com/df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60/services/service_manager/sandbox/sandbox_type.h
[modify] https://crrev.com/df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60/webrunner/BUILD.gn
[modify] https://crrev.com/df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60/webrunner/service/context_provider_impl.cc

Comment 31 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01db93151d091c302ddb8be3b04a6b4c690aac7f

commit 01db93151d091c302ddb8be3b04a6b4c690aac7f
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Dec 10 23:57:20 2018

[Fuchsia] Export Vulkan loader service to the GPU process.

Updated GPU sandbox policy for the GPU process to export the
fuchsia.vulkan.loader service. With this change sandboxed GPU process
can use Vulkan.

Bug: 861853
Change-Id: Ifcb1fa0ac186ae63b7fb09bd8782bf690c2f4b55
Reviewed-on: https://chromium-review.googlesource.com/c/1368991
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615333}
[modify] https://crrev.com/01db93151d091c302ddb8be3b04a6b4c690aac7f/services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.cc

Comment 32 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b54ed09d961a5d552f4067fbbef23af87c7186e

commit 5b54ed09d961a5d552f4067fbbef23af87c7186e
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Dec 12 03:54:57 2018

[Vulkan] Enable kRGB_888x_SkColorType in SkColorTypeToVkFormat()

Previously, gfx::SkColorTypeToVkFormat() wasn't mapping
kRGB_888x_SkColorType because VK_FORMAT_R8G8B8_UNORM was not supported
by Skia, but it should be able to handle that image format now.

Bug: 861853
Change-Id: Ic2b861f42628946484efb872aaf0c43aad5d660b
Reviewed-on: https://chromium-review.googlesource.com/c/1372724
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615808}
[modify] https://crrev.com/5b54ed09d961a5d552f4067fbbef23af87c7186e/ui/gfx/skia_util.cc

Comment 33 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ee88db103816b5460fc65d6f935eb685848b933

commit 3ee88db103816b5460fc65d6f935eb685848b933
Author: Michael Spang <spang@chromium.org>
Date: Wed Dec 12 20:17:38 2018

ozone: scenic: Move ScenicSurface to a standalone class

In order to prepare to use ScenicSurface from multiple files, move it to
its own file.

Bug: 861853
Test: run_content_shell \
  --enable-features=VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList,UiGpuRasterization,OzoneDrmMojo
  --enable-oop-rasterization --enable-vulkan --enable-gpu-rasterization \
  --enable-raster-to-sk-image --use-raster-context-provider \
  --force-gpu-rasterization --use-gl=swiftshader --no-sandbox \
  --disable-gpu-sandbox

Change-Id: Ie1197b3f355a079513828353fc20e9a16162e9ea
Reviewed-on: https://chromium-review.googlesource.com/c/1362474
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616011}
[modify] https://crrev.com/3ee88db103816b5460fc65d6f935eb685848b933/ui/ozone/platform/scenic/BUILD.gn
[add] https://crrev.com/3ee88db103816b5460fc65d6f935eb685848b933/ui/ozone/platform/scenic/scenic_surface.cc
[add] https://crrev.com/3ee88db103816b5460fc65d6f935eb685848b933/ui/ozone/platform/scenic/scenic_surface.h
[modify] https://crrev.com/3ee88db103816b5460fc65d6f935eb685848b933/ui/ozone/platform/scenic/vulkan_implementation_scenic.cc

Comment 34 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46ca37ef5cf428faa777500f9d4af6d502e74e3d

commit 46ca37ef5cf428faa777500f9d4af6d502e74e3d
Author: Michael Spang <spang@chromium.org>
Date: Thu Dec 13 00:59:10 2018

ozone: scenic: Hold resources in new object that's independent of VulkanSurface

This removes the need for a destruction callback on VulkanSurface. This also
means that we would keep the same session when surfaces are reshaped since that
creates an entirely new VulkanSurface.

This is only used for Fuchsia & SkiaRenderer + Vulkan as of this patch.

Bug: 861853
Test: run_content_shell \
  --enable-features=VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList,UiGpuRasterization,OzoneDrmMojo
  --enable-oop-rasterization --enable-vulkan --enable-gpu-rasterization \
  --enable-raster-to-sk-image --use-raster-context-provider \
  --force-gpu-rasterization --use-gl=swiftshader --no-sandbox \
  --disable-gpu-sandbox

Change-Id: I84ed451df257cce2e1a2a471a1e6995e78fe3001
Reviewed-on: https://chromium-review.googlesource.com/c/1362475
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616130}
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/components/viz/service/BUILD.gn
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/gpu/vulkan/android/vulkan_implementation_android.cc
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/gpu/vulkan/vulkan_surface.cc
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/gpu/vulkan/vulkan_surface.h
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/gpu/vulkan/win32/vulkan_implementation_win32.cc
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/gpu/vulkan/x/vulkan_implementation_x11.cc
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/BUILD.gn
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/platform/scenic/scenic_surface.cc
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/platform/scenic/scenic_surface.h
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/platform/scenic/scenic_surface_factory.cc
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/platform/scenic/scenic_surface_factory.h
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/platform/scenic/vulkan_implementation_scenic.cc
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/platform/scenic/vulkan_implementation_scenic.h
[add] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/public/platform_window_surface.h
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/public/surface_factory_ozone.cc
[modify] https://crrev.com/46ca37ef5cf428faa777500f9d4af6d502e74e3d/ui/ozone/public/surface_factory_ozone.h

Comment 35 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea5fccd162efc5dcd022c2b0f3119b858b7c5c6a

commit ea5fccd162efc5dcd022c2b0f3119b858b7c5c6a
Author: James Robinson <jamesr@google.com>
Date: Thu Dec 20 01:20:14 2018

[viz][fuchsia] Disable OOP-D by default on Fuchsia

VisDisplayCompositor doesn't quite work in the default Fuchsia
configuration just yet, disable by default for now. It appears that GPU
rasterization needs to be enabled by default for OOP-D to work but
that's blocked on other work.

Bug: 861853
Change-Id: Ic4d81c0b6df28ea1f1b48b5d31e3a00aa6db2e7b
Reviewed-on: https://chromium-review.googlesource.com/c/1385206
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: James Robinson <jamesr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618059}
[modify] https://crrev.com/ea5fccd162efc5dcd022c2b0f3119b858b7c5c6a/components/viz/common/features.cc

Comment 36 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b4a80d34ee5bacbb342b419cab238a566f04338

commit 2b4a80d34ee5bacbb342b419cab238a566f04338
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Jan 11 18:24:05 2019

Update vulkan headers to 1.1.97

The new version adds vulkan_fuchsia.h

Bug: 861853
Change-Id: Iaad12a3ce67fbdb5908abc0ea5aebce3e8d40b55
Reviewed-on: https://chromium-review.googlesource.com/c/1406308
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622063}
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/README.chromium
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan.h
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_android.h
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_core.h
[add] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_fuchsia.h
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_ios.h
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_macos.h
[add] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_vi.h
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_wayland.h
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_win32.h
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_xcb.h
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_xlib.h
[modify] https://crrev.com/2b4a80d34ee5bacbb342b419cab238a566f04338/third_party/vulkan/include/vulkan/vulkan_xlib_xrandr.h

Comment 37 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c05171057895cbde179d5d419a888a29c7a8e045

commit c05171057895cbde179d5d419a888a29c7a8e045
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Jan 14 20:00:20 2019

[Fuchsia] Use VK_FUCHSIA_imagepipe_surface

VK_KHR_external_memory_fuchsia extension was replaced with
VK_FUCHSIA_imagepipe_surface. Use the new extension instead of the old
one.

Bug: 861853
Change-Id: I11538b6054b64345369d6a34f6979909b56bc331
Reviewed-on: https://chromium-review.googlesource.com/c/1405453
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622559}
[modify] https://crrev.com/c05171057895cbde179d5d419a888a29c7a8e045/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/c05171057895cbde179d5d419a888a29c7a8e045/ui/ozone/platform/scenic/vulkan_implementation_scenic.cc
[modify] https://crrev.com/c05171057895cbde179d5d419a888a29c7a8e045/ui/ozone/platform/scenic/vulkan_implementation_scenic.h
[delete] https://crrev.com/c5cda87325a63650458d900ef6c24edf27b31321/ui/ozone/platform/scenic/vulkan_magma.h

Sign in to add a comment