New issue
Advanced search Search tips

Issue 861844 link

Starred by 1 user
Status: Fixed
Owner:
alexilin@chromium.org
Closed: Jul 16
Cc:
mattcary@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 795291



Sign in to add a comment

Convert gpu command buffer to the new shared memory API.

Project Member Reported by alexilin@chromium.org, Jul 9 
The deprecated SharedMemoryHandle is used in gpu/command_buffer/common/buffer.h

This buffer is shared as writable to the GPU process so the UnsafeSharedMemoryRegion should be used.

Main directories affected by this change:
* gpu/command_buffer
* gpu/ipc
* ppapi/proxy
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15bb703ccf158980bf43c374227d4ac8be775edb

commit 15bb703ccf158980bf43c374227d4ac8be775edb
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Fri Jul 13 10:09:06 2018

gpu: Convert command and transfer buffers to the new shared memory API

This CL replaces the deprecated base::SharedMemory in
gpu::SharedMemoryBufferBacking with the base::UnsafeSharedMemoryRegion. This
involves cascading changes in many other files including the change of
parameters in GpuChannelMsg_CreateCommandBuffer and
GpuCommandBufferMsg_RegisterTransferBuffer ipc messages.

Bug:  861844 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7c7afecd9fbf6d268ed72233f2e85a6f2d93da51
Reviewed-on: https://chromium-review.googlesource.com/1127948
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574872}
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/cc/paint/paint_op_buffer_fuzzer.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/content/renderer/pepper/ppb_graphics_3d_impl.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/content/renderer/pepper/ppb_graphics_3d_impl.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/content/renderer/pepper/resource_creation_impl.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/content/renderer/pepper/resource_creation_impl.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/client_discardable_manager_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/client_test_helper.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/cmd_buffer_helper.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/implementation_base.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/mapped_memory.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/mapped_memory_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/mock_transfer_buffer.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/mock_transfer_buffer.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/transfer_buffer.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/transfer_buffer.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/client/transfer_buffer_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/common/buffer.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/common/buffer.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/common/buffer_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/common/discardable_handle_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/service/buffer_manager.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/service/command_buffer_service.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/service/service_discardable_manager_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/service/transfer_buffer_manager.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/command_buffer/service/transfer_buffer_manager_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/client/command_buffer_proxy_impl.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/client/command_buffer_proxy_impl.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/client/gpu_channel_host.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/client/gpu_channel_host.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/common/gpu_messages.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/command_buffer_stub.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/gles2_command_buffer_stub.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/gles2_command_buffer_stub.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/gpu_channel.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/gpu_channel_test_common.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/gpu_channel_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/raster_command_buffer_stub.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/gpu/ipc/service/raster_command_buffer_stub.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/ppapi/proxy/ppapi_command_buffer_proxy.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/ppapi/proxy/ppapi_command_buffer_proxy.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/ppapi/proxy/ppapi_command_buffer_proxy_unittest.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/ppapi/proxy/ppb_graphics_3d_proxy.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/ppapi/proxy/ppb_graphics_3d_proxy.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/ppapi/proxy/resource_creation_proxy.cc
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/ppapi/proxy/resource_creation_proxy.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/ppapi/proxy/serialized_handle.h
[modify] https://crrev.com/15bb703ccf158980bf43c374227d4ac8be775edb/ppapi/thunk/resource_creation_api.h

Comment 2 by alexilin@chromium.org, Jul 16

Status: Fixed (was: Started)
►

Sign in to add a comment