New issue
Advanced search Search tips

Issue 861843 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 843511



Sign in to add a comment

swarm content_browsertests on the cast bots

Project Member Reported by thakis@chromium.org, Jul 9

Issue description

Owner: ----
Status: Untriaged (was: Started)
Doesn't pass, see blocker.
Also mentioned on the blocker: This would likely reduce cycle time of cast_shell_linux by 30% or so.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da3f703063b9200918c1ae426ba4ea68e9ee6555

commit da3f703063b9200918c1ae426ba4ea68e9ee6555
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jul 11 14:34:27 2018

Add comments explaining why the cast bots run two test suites unswarmed.

Also add a data dep that's necessary (but apparently not sufficient) for
cast_shell_browsertests to run on swarming.

Bug: 861753,  861843 
Change-Id: Ib10a8589c1349ac70dc4d4358395af6b2867d16b
Reviewed-on: https://chromium-review.googlesource.com/1133201
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574156}
[modify] https://crrev.com/da3f703063b9200918c1ae426ba4ea68e9ee6555/chromecast/browser/BUILD.gn
[modify] https://crrev.com/da3f703063b9200918c1ae426ba4ea68e9ee6555/testing/buildbot/test_suite_exceptions.pyl

Components: Infra
Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)
mac triage: thakis@ - it sounds like you still want to own this but it's blocked right now?
Components: Internals>Cast
Labels: -OS-Mac OS-Linux
Status: Untriaged (was: Assigned)
No, someone on cast should look at this.
Blockedon: -861841
I am removing the blocking issue 861841 because the FileSystemURLLoaderFactoryTest tests are now disabled (see that issue for more info).
Status: Started (was: Untriaged)
Oh cool, sending https://chromium-review.googlesource.com/c/chromium/src/+/1129042 out then :-)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02f3039f96b32a43a2046b23a8d56dae04dff800

commit 02f3039f96b32a43a2046b23a8d56dae04dff800
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jul 16 18:39:43 2018

Run content_browsertests on swarming on the cast bots.

content_browsertests takes almost 7 minutes to run and is currently on the
critical path of the bot since it's not swarmed, so this should reduce
the cycle time of cast_shell_linux by almost 7 minutes.

Bug: 843511, 861843 
Change-Id: I95dc87ca2b844b2bf0363b4a8b1915aeaed30938
Reviewed-on: https://chromium-review.googlesource.com/1129042
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575360}
[modify] https://crrev.com/02f3039f96b32a43a2046b23a8d56dae04dff800/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/02f3039f96b32a43a2046b23a8d56dae04dff800/testing/buildbot/test_suite_exceptions.pyl

Status: Fixed (was: Started)

Sign in to add a comment