FileSystemURLLoaderFactoryTest.* fail on cast bots, at least when content_browsertests is run under swarming |
|||||||
Issue descriptionhttps://ci.chromium.org/p/chromium/builders/luci.chromium.try/cast_shell_audio_linux/6 (doesn't use swarming, but a non-default bot) https://ci.chromium.org/p/chromium/builders/luci.chromium.try/cast_shell_linux/88615 (moves content_browsertests to run under swarming like on all the other bots These tests fail: FileSystemURLLoaderFactoryTest.FileTest FileSystemURLLoaderFactoryTest.AutoMountNoHandler FileSystemURLLoaderFactoryTest.NoSuchRoot FileSystemURLLoaderFactoryTest.FileAutoMountNoHandler FileSystemURLLoaderFactoryTest.FileGetMimeType FileSystemURLLoaderFactoryTest.InvalidURL FileSystemURLLoaderFactoryTest.FileNoSuchRoot FileSystemURLLoaderFactoryTest.FileTestFullSpecifiedRange FileSystemURLLoaderFactoryTest.DirectoryListing FileSystemURLLoaderFactoryTest.NoSuchFile FileSystemURLLoaderFactoryTest.NoSuchDirectory FileSystemURLLoaderFactoryTest.FileAutoMountInvalidRoot FileSystemURLLoaderFactoryTest.FileCancel FileSystemURLLoaderFactoryTest.FileDirRedirect FileSystemURLLoaderFactoryTest.FileTestMultipleRangesNotSupported FileSystemURLLoaderFactoryTest.AutoMountDirectoryListing FileSystemURLLoaderFactoryTest.FileAutoMountFileTest FileSystemURLLoaderFactoryTest.Incognito FileSystemURLLoaderFactoryTest.AutoMountInvalidRoot Looks like they all fail with: [6066:6119:0709/080334.329966:FATAL:network_service_instance.cc(70)] Check failed: !base::FeatureList::IsEnabled(network::features::kNetworkService). Not sure why the network service is enabled there, but it somehow is. This blocks landing https://chromium-review.googlesource.com/c/chromium/src/+/1129042 which could reduce cycle time of that bug by some 30%.
,
Jul 11
cmumford, ping?
,
Jul 11
chris, I'm pretty sure this is canary non-blocking.
,
Jul 12
,
Jul 13
move to correct component
,
Jul 16
These tests are currently disabled. They were disabled in http://crrev.com/c/1074427 for issue 846985 . I believe the fix for this specific bug is to enable the network service (i.e. call InitAndEnableFeature) in the test constructor instead of later on in SetUpOnMainThread. I'll still have to fix the threading issues described in issue 860547 before attempting to land that. Both this issue, and issue 860547 are test-only bugs so technically are not canary blocking. FYI: The implementation of these tests are closely coupled with the network service itself which is why the network service is forced on by the tests.
,
Jul 16
,
Jul 24
,
Jul 24
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by thakis@chromium.org
, Jul 9