New issue
Advanced search Search tips

Issue 861837 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Delete timeStampInMs

Project Member Reported by eakuefner@chromium.org, Jul 9

Issue description

Simon is going to be using this for time-to-culprit automation
 
How does timeDurationInMsAutoFormat need to be different from timeInMsAutoFormat?
Labels: -Pri-2 Pri-3
Summary: Delete timeStampInMs (was: Implement timeDurationInMsAutoFormat)
Reviewed this offline with Ben; the formatSpec for timeStampInMs and timeDurationInMs are identical and tsMs is virtually unused. Let's get rid of timeStampInMs.

Lowering to P3 for this cleanup.

Simon, for your use case, you'll want to switch to timeInMsAutoFormat.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/685c633d540056039b94c2d27f33b372d6a2c1a1

commit 685c633d540056039b94c2d27f33b372d6a2c1a1
Author: Ethan Kuefner <eakuefner@chromium.org>
Date: Tue Jul 10 19:36:18 2018

[TBMv2] Make timeInMsAutoFormat available in Python

This CL allows users of the Python histogram library to create histograms with
unit timeInMsAutoFormat.

Bug: chromium:861837
Change-Id: I9da26f21e5e79ff45e4401980ecfc77a234eeb42
Reviewed-on: https://chromium-review.googlesource.com/1131894
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/685c633d540056039b94c2d27f33b372d6a2c1a1/tracing/tracing/value/histogram.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/1230eb961dc4964fb9cf0954143c24c92f2de6d9

commit 1230eb961dc4964fb9cf0954143c24c92f2de6d9
Author: Simon <simonhatch@chromium.org>
Date: Tue Jul 10 20:15:08 2018

Dashboard - Use msBestFitFormat for dashboard stats.

Bug: chromium:861837
Change-Id: If93cf71447971b19c12be48184938b9c35019705
Reviewed-on: https://chromium-review.googlesource.com/1132100
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>

[modify] https://crrev.com/1230eb961dc4964fb9cf0954143c24c92f2de6d9/dashboard/dashboard/update_dashboard_stats.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/141a357eff247e439605ace9d7f25281a84b89d7

commit 141a357eff247e439605ace9d7f25281a84b89d7
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jul 10 23:22:37 2018

Roll src/third_party/catapult 3b1c86144cc8..1230eb961dc4 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/3b1c86144cc8..1230eb961dc4


git log 3b1c86144cc8..1230eb961dc4 --date=short --no-merges --format='%ad %ae %s'
2018-07-10 simonhatch@chromium.org Dashboard - Use msBestFitFormat for dashboard stats.
2018-07-10 eakuefner@chromium.org [TBMv2] Make timeInMsAutoFormat available in Python


Created with:
  gclient setdep -r src/third_party/catapult@1230eb961dc4

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:861837,chromium:861837
TBR=sullivan@chromium.org

Change-Id: Id236f43859df3e36ff64c6501bf1b3b539a4ba9c
Reviewed-on: https://chromium-review.googlesource.com/1131963
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573979}
[modify] https://crrev.com/141a357eff247e439605ace9d7f25281a84b89d7/DEPS

Owner: ----
Status: Available (was: Assigned)
Going to unassign since this is lo-pri; this might be a good GoodFirstBug.

Sign in to add a comment