Add back boostForPendingFrame |
|||||||
Issue descriptionTwo bugs introduced in https://chromium-review.googlesource.com/934311 and https://chromium-review.googlesource.com/1033802 Frame depth change is not necessarily reported to binding changes. And the boostForPendingViews logic is accidentally removed. Fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1128573
,
Jul 9
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07fe724b57d94ce25bbb520410e5b596f856d826 commit 07fe724b57d94ce25bbb520410e5b596f856d826 Author: Bo Liu <boliu@chromium.org> Date: Mon Jul 09 23:59:49 2018 Android process binding fixes * Add back boostForPendingView logic accidentally removed in r554797 * Send updates when frame depth changes, which was missing in r546622. Note this fix is limited to OS_ANDROID to maintain the desktop workaround for crbug.com/560446 * Also improve testCrossDomainNavigationDoNotLoseImportance to also log the calling stack on failure. Bug: 861826 Change-Id: I0757647a81228a9bfc5fda02d775f62fb6bee723 Reviewed-on: https://chromium-review.googlesource.com/1128573 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573540} [modify] https://crrev.com/07fe724b57d94ce25bbb520410e5b596f856d826/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/07fe724b57d94ce25bbb520410e5b596f856d826/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelperImpl.java [modify] https://crrev.com/07fe724b57d94ce25bbb520410e5b596f856d826/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherIntegrationTest.java
,
Jul 11
Been in canary for 1.5 days.
,
Jul 11
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 11
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54ff2c33c4e8409d5a71fa3e6b83064d75476115 commit 54ff2c33c4e8409d5a71fa3e6b83064d75476115 Author: Bo Liu <boliu@chromium.org> Date: Wed Jul 11 19:09:58 2018 [Merge M68] Android process binding fixes * Add back boostForPendingView logic accidentally removed in r554797 * Send updates when frame depth changes, which was missing in r546622. Note this fix is limited to OS_ANDROID to maintain the desktop workaround for crbug.com/560446 * Also improve testCrossDomainNavigationDoNotLoseImportance to also log the calling stack on failure. (cherry picked from commit 07fe724b57d94ce25bbb520410e5b596f856d826) Bug: 861826 Change-Id: I0757647a81228a9bfc5fda02d775f62fb6bee723 Reviewed-on: https://chromium-review.googlesource.com/1128573 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#573540} Reviewed-on: https://chromium-review.googlesource.com/1133777 Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#646} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/54ff2c33c4e8409d5a71fa3e6b83064d75476115/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/54ff2c33c4e8409d5a71fa3e6b83064d75476115/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java [modify] https://crrev.com/54ff2c33c4e8409d5a71fa3e6b83064d75476115/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherIntegrationTest.java
,
Jul 11
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by boliu@chromium.org
, Jul 9