New issue
Advanced search Search tips

Issue 861821 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Chrome crashed when opening a synced address in settings/Autofill and payments/addresses

Project Member Reported by gogerald@chromium.org, Jul 9

Issue description

07-09 11:08:27.746  9753  9753 W System.err: java.lang.AssertionError
07-09 11:08:27.747  9753  9753 W System.err: 	at org.chromium.chrome.browser.payments.ui.EditorDropdownField.<init>(EditorDropdownField.java:99)
07-09 11:08:27.747  9753  9753 W System.err: 	at org.chromium.chrome.browser.payments.ui.EditorDialog.addFieldViewToEditor(EditorDialog.java:439)
07-09 11:08:27.747  9753  9753 W System.err: 	at org.chromium.chrome.browser.payments.ui.EditorDialog.prepareEditor(EditorDialog.java:376)
07-09 11:08:27.747  9753  9753 W System.err: 	at org.chromium.chrome.browser.payments.ui.EditorDialog.show(EditorDialog.java:512)
07-09 11:08:27.747  9753  9753 W System.err: 	at org.chromium.chrome.browser.payments.AddressEditor.onSubKeysReceived(AddressEditor.java:391)
07-09 11:08:27.747  9753  9753 W System.err: 	at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
07-09 11:08:27.747  9753  9753 W System.err: 	at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:51)
07-09 11:08:27.747  9753  9753 W System.err: 	at android.os.Handler.dispatchMessage(Handler.java:105)
07-09 11:08:27.747  9753  9753 W System.err: 	at android.os.Looper.loop(Looper.java:164)
07-09 11:08:27.747  9753  9753 W System.err: 	at android.app.ActivityThread.main(ActivityThread.java:6541)
07-09 11:08:27.747  9753  9753 W System.err: 	at java.lang.reflect.Method.invoke(Native Method)
07-09 11:08:27.747  9753  9753 W System.err: 	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
07-09 11:08:27.747  9753  9753 W System.err: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
07-09 11:08:27.765  9753  9753 F chromium: [FATAL:jni_android.cc(259)] Please include Java exception stack in crash report
07-09 11:08:27.765  9753  9753 F chromium: #00 0x918fcacd /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libbase.cr.so+0x000faacd
07-09 11:08:27.765  9753  9753 F chromium: #01 0x9191950a /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libbase.cr.so+0x0011750a
07-09 11:08:27.765  9753  9753 F chromium: #02 0x918e5d96 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libbase.cr.so+0x000e3d96
07-09 11:08:27.765  9753  9753 F chromium: #03 0x84173c7b /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x01047c7b
07-09 11:08:27.765  9753  9753 F chromium: #04 0x84174233 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x01048233
07-09 11:08:27.765  9753  9753 F chromium: #05 0x841741fd /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x010481fd
07-09 11:08:27.765  9753  9753 F chromium: #06 0x841741d2 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x010481d2
07-09 11:08:27.765  9753  9753 F chromium: #07 0x83b283af /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x009fc3af
07-09 11:08:27.765  9753  9753 F chromium: #08 0x8461dba3 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x014f1ba3
07-09 11:08:27.765  9753  9753 F chromium: #09 0x8461da55 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x014f1a55
07-09 11:08:27.765  9753  9753 F chromium: #10 0x846420cc /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x015160cc
07-09 11:08:27.765  9753  9753 F chromium: #11 0x8461d1bb /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x014f11bb
07-09 11:08:27.765  9753  9753 F chromium: #12 0x84648adb /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x0151cadb
07-09 11:08:27.765  9753  9753 F chromium: #13 0x8461d1bb /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x014f11bb
07-09 11:08:27.765  9753  9753 F chromium: #14 0x846499ba /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x0151d9ba
07-09 11:08:27.765  9753  9753 F chromium: #15 0x8461d1bb /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x014f11bb
07-09 11:08:27.765  9753  9753 F chromium: #16 0x84642df3 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x01516df3
07-09 11:08:27.765  9753  9753 F chromium: #17 0x84642e40 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libchrome.cr.so+0x01516e40
07-09 11:08:27.765  9753  9753 F chromium: #18 0x8fa6279c /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libnet.cr.so+0x005cf79c
07-09 11:08:27.765  9753  9753 F chromium: #19 0x8fa62702 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libnet.cr.so+0x005cf702
07-09 11:08:27.765  9753  9753 F chromium: #20 0x8fa63604 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libnet.cr.so+0x005d0604
07-09 11:08:27.765  9753  9753 F chromium: #21 0x8fa635ac /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libnet.cr.so+0x005d05ac
07-09 11:08:27.765  9753  9753 F chromium: #22 0x8fa63567 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libnet.cr.so+0x005d0567
07-09 11:08:27.765  9753  9753 F chromium: #23 0x8fa6353d /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libnet.cr.so+0x005d053d
07-09 11:08:27.765  9753  9753 F chromium: #24 0x918ef114 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libbase.cr.so+0x000ed114
07-09 11:08:27.765  9753  9753 F chromium: #25 0x918fd52f /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libbase.cr.so+0x000fb52f
07-09 11:08:27.765  9753  9753 F chromium: #26 0x9191f407 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libbase.cr.so+0x0011d407
07-09 11:08:27.765  9753  9753 F chromium: #27 0x919222ea /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libbase.cr.so+0x001202ea
07-09 11:08:27.765  9753  9753 F chromium: #28 0x919225d0 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libbase.cr.so+0x001205d0
07-09 11:08:27.765  9753  9753 F chromium: #29 0x91922718 /data/data/com.google.android.apps.chrome/incremental-install-files/lib/libbase.cr.so+0x00120718



 
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6da1f51df86aee94ed2f57684368ff7e441a4a77

commit 6da1f51df86aee94ed2f57684368ff7e441a4a77
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Wed Jul 18 21:43:11 2018

Avoid Crash for State Dropdown on Address Editor

Problem: if the state is not saved as the key (like NY), and is saved
as a complete form (New York), or is invalid (Caoldo), the assert
would fail on debug mode. On release build, the state would not show
up on the editor.

Solution: Look for both the key and the complete form. If can't find
them (invalid value), show the default or the first item.

Tests added.

Bug: 861821
Change-Id: I8eeb3679c0dd503c264014e22d8e2a6cd8ef5405
Reviewed-on: https://chromium-review.googlesource.com/1140366
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576226}
[modify] https://crrev.com/6da1f51df86aee94ed2f57684368ff7e441a4a77/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDropdownField.java
[modify] https://crrev.com/6da1f51df86aee94ed2f57684368ff7e441a4a77/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragmentTest.java

Sign in to add a comment