New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 861799 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression
Proj-VR
Proj-XR



Sign in to add a comment

6.5%-60.1% regression in xr.browsing.wpr.static at 571476:571575

Project Member Reported by bsheedy@google.com, Jul 9

Issue description

The draw_frame_cpu regressions point to https://chromium-review.googlesource.com/1117741. There are memory regressions in the same range, but currently unsure of whether that's caused by this CL or not.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=861799

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e98e074a5f16884c1e86b57fd270f9523bdd28095a393ea071f7885674b17a13


Bot(s) for this bug's original alert(s):

pixel_2_xl
pixel_xl
Components: UI>Browser>VR
Labels: Proj-XR-VR VR-Perf
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298

commit 7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Thu Jul 12 19:38:45 2018

VR: Update textures only if dirty

This prevents from performing unnecessary context switches.

Bug:  861799 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5da0e41dda9edb0243c9bbc9c944bdc2cdfaaf39
Reviewed-on: https://chromium-review.googlesource.com/1133298
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574680}
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/vr/elements/textured_element.cc
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/vr/elements/textured_element.h
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/vr/ui.cc
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/vr/ui.h
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298/chrome/browser/vr/ui_scene.h

Status: Fixed (was: Assigned)

Sign in to add a comment