Add versions of existing metrics that take into account the number of alive tabs when the metric is recorded. Example Metrics: - EQT - Scroll latency - Page load metrics - FCP, FirstInputDelay Related doc: https://docs.google.com/document/d/1zQ6vgWMYH5z5Sfnx9knBS7BlDlmhV2n0xMyNzFPNO6c/edit#heading=h.266vyk3v7gu
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4f4244cd8d6bc6399413c41e045508bdc7438a0 commit a4f4244cd8d6bc6399413c41e045508bdc7438a0 Author: Scott Haseley <shaseley@google.com> Date: Fri Aug 24 00:39:00 2018 [metrics] Adding helper methods for creating metrics bucketed by number of live tabs This CL defines the live tab count buckets, adds a namespace and helper methods for defining metrics bucketed by live tab count, and adds unit tests that test example metrics. Actual metrics will be implemented in follow-up CLs. Design doc: https://docs.google.com/document/d/1FB6Pv5Pu0jbYJwSfnqSeufHVOGEt9-d1agpzA4_CC-k/edit?usp=sharing Bug: 861796 Change-Id: Idd510da5f3c40f9c4d5d1dc292fb6b4139217af2 Reviewed-on: https://chromium-review.googlesource.com/1166215 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585672} [modify] https://crrev.com/a4f4244cd8d6bc6399413c41e045508bdc7438a0/components/BUILD.gn [add] https://crrev.com/a4f4244cd8d6bc6399413c41e045508bdc7438a0/components/live_tab_count_metrics/BUILD.gn [add] https://crrev.com/a4f4244cd8d6bc6399413c41e045508bdc7438a0/components/live_tab_count_metrics/OWNERS [add] https://crrev.com/a4f4244cd8d6bc6399413c41e045508bdc7438a0/components/live_tab_count_metrics/README [add] https://crrev.com/a4f4244cd8d6bc6399413c41e045508bdc7438a0/components/live_tab_count_metrics/live_tab_count_metrics.cc [add] https://crrev.com/a4f4244cd8d6bc6399413c41e045508bdc7438a0/components/live_tab_count_metrics/live_tab_count_metrics.h [add] https://crrev.com/a4f4244cd8d6bc6399413c41e045508bdc7438a0/components/live_tab_count_metrics/live_tab_count_metrics_unittest.cc
Adding component as part of labeling rotation, please update if incorrect :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45294ec10f51ec8c1207506685e84e4711217c52 commit 45294ec10f51ec8c1207506685e84e4711217c52 Author: Scott Haseley <shaseley@google.com> Date: Fri Aug 24 18:52:00 2018 Adding page load metrics bucketed by live tab count This CL adds versions of FirstContentfulPaint, FirstMeaningfulPaint, and FirstInputDelay metrics that are bucketed by the number of live tabs open in the browser. The following metrics are added: PageLoad.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint.ByLiveTabCount.<BucketRangeSuffixText> PageLoad.PaintTiming.NavigationToFirstContentfulPaint.ByLiveTabCount.<BucketRangeSuffixText> PageLoad.InteractiveTiming.FirstInputDelay.ByLiveTabCount.<BucketRangeSuffixText> <BucketRangeSuffixText> corresponds to the LiveTabCountMetrics histogram_suffixes in histograms.xml, e.g. "1Tab", "2Tabs", etc. Bug: 861796 Change-Id: I50a7b806f82b7284543a97ed5d2496213c9a5d62 Reviewed-on: https://chromium-review.googlesource.com/1168287 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#585925} [modify] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/BUILD.gn [add] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/metrics/live_tab_count_metrics.cc [add] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/metrics/live_tab_count_metrics.h [modify] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/page_load_metrics/observers/histogram_suffixes.cc [modify] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/page_load_metrics/observers/histogram_suffixes.h [add] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/page_load_metrics/observers/live_tab_count_page_load_metrics_observer.cc [add] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/page_load_metrics/observers/live_tab_count_page_load_metrics_observer.h [add] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/page_load_metrics/observers/live_tab_count_page_load_metrics_observer_browsertest.cc [add] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/page_load_metrics/observers/live_tab_count_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc [modify] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/chrome/test/BUILD.gn [modify] https://crrev.com/45294ec10f51ec8c1207506685e84e4711217c52/tools/metrics/histograms/histograms.xml
Comment 1 by shaseley@google.com
, Jul 9