New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 861776 link

Starred by 1 user
Status: Verified
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Jul 16
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 834385



Sign in to add a comment

ecryptfs-utils: failed to build with glibc 2.27

Project Member Reported by yunlian@chromium.org, Jul 9 
With glibc 2.27
emerge-samus ecryptfs-utils

In file included from mount.ecryptfs.c:28:
../../../../../../../../usr/include/keyutils.h:129:43: error: unknown type name 'uid_t'; did you mean 'pid_t'?
extern long keyctl_chown(key_serial_t id, uid_t uid, gid_t gid);

Comment 1 by vapier@chromium.org, Jul 10

Cc: vapier@chromium.org
Components: OS>Packages
Labels: OS-Chrome
this looks like a bug in keyutils.h not ecryptfs-utils
  https://bugs.gentoo.org/650856

Comment 2 by yunlian@chromium.org, Jul 11 

Yes, keyutils has an upstream patch below.

Mike, could you please add this to Gentoo upstream keyutils so that I can
pull it over? 

commit 9d52b8ab86931fb5a66fa5b567ea01875f31016e (HEAD -> master, origin/master, origin/HEAD)
Author: David Howells <dhowells@redhat.com>
Date:   Fri Nov 14 11:25:17 2014 +0000

    LIB: #include sys/types.h in keyutils.h to bring in missing types
    
    sys/types.h needs to be #included from keyutils.h as it uses size_t, uid_t and
    gid_t which are otherwise undefined.
    
    Reported-by: Rasmus Villemoes <rv@rasmusvillemoes.dk>
    Signed-off-by: David Howells <dhowells@redhat.com>

diff --git a/keyutils.h b/keyutils.h
index b9ff7e8..fc8495d 100644
--- a/keyutils.h
+++ b/keyutils.h
@@ -12,6 +12,7 @@
 #ifndef KEYUTILS_H
 #define KEYUTILS_H
 
+#include <sys/types.h>
 #include <stdint.h>
 
 extern const char keyutils_version_string[];
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/37296ed7a65099f8eb9cb49faffd9cf4009f3f50

commit 37296ed7a65099f8eb9cb49faffd9cf4009f3f50
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Jul 14 00:29:06 2018

keyutils: upgreade to 1.5.10

This pulls Gentoo upstreap keyutils-1.5.10. The only change
is to change the KEYWORDS to "*"

BUG= chromium:861776 
TEST=emerge-samus ecryptfs-utils with glibc 2.27/2.23

Change-Id: I6e85fc487bcc6ca400a3a4e7ae4c7df687bb682c
Reviewed-on: https://chromium-review.googlesource.com/1135817
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/69b7af668312846cb0af56e1dd9513f631b9dabd/sys-apps/keyutils/files/keyutils-1.5.5-makefile-fixup.patch
[delete] https://crrev.com/69b7af668312846cb0af56e1dd9513f631b9dabd/sys-apps/keyutils/files/keyutils-1.5.9-endian-check-1.patch
[add] https://crrev.com/37296ed7a65099f8eb9cb49faffd9cf4009f3f50/sys-apps/keyutils/files/keyutils-1.5.10-makefile-fixup.patch
[delete] https://crrev.com/69b7af668312846cb0af56e1dd9513f631b9dabd/sys-apps/keyutils/files/keyutils-1.5.9-endian-check-2.patch
[rename] https://crrev.com/37296ed7a65099f8eb9cb49faffd9cf4009f3f50/sys-apps/keyutils/keyutils-1.5.10.ebuild
[modify] https://crrev.com/37296ed7a65099f8eb9cb49faffd9cf4009f3f50/sys-apps/keyutils/Manifest
[rename] https://crrev.com/37296ed7a65099f8eb9cb49faffd9cf4009f3f50/sys-apps/keyutils/files/keyutils-1.5.10-disable-tests.patch

Comment 4 by vapier@chromium.org, Jul 14 

i assume the new 1.5.10 release contains the fix ?

Comment 5 by yunlian@chromium.org, Jul 16 

Yes

Comment 6 by yunlian@chromium.org, Jul 16

Status: Verified (was: Untriaged)
►

Sign in to add a comment