New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 861769 link

Starred by 1 user
Status: Fixed
Owner:
█ akaba@chromium.org
Last visit > 30 days ago
Closed: Aug 21
Cc:
samans@chromium.org
█ fsam...@chromium.org
kylec...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 857575



Sign in to add a comment

Rewrite content rendering timeout using new fallback semantics

Project Member Reported by samans@chromium.org, Jul 9 
Simply clearing the fallback will no longer mean nothing older than the primary will be shown. This will break content rendering timeout. To make it work with the new fallback semantics, the timer will set the fallback to the first surface after navigation instead of simply clearing it. OnFirstSurfaceActivation will not stop the timer. The timer will always fire after 4 seconds.

Comment 1 by akaba@google.com, Jul 31

Owner: akaba@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2624f2c1a13f4a81e930ffce84ef7eb227d3144

commit f2624f2c1a13f4a81e930ffce84ef7eb227d3144
Author: akaba <akaba@google.com>
Date: Tue Aug 21 17:11:01 2018

Rewrite content rendering timeout using new fallback semantics

Content rendering timeout will now set the fallback to the first Surface
after navigation instead of invalidating it.

Bug:  861769 
TBR: piman@chromium.org
Change-Id: I145a482cc084398d6687aa749acd563c9a07c6e2
Reviewed-on: https://chromium-review.googlesource.com/1174707
Commit-Queue: Andre Kaba <akaba@google.com>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584798}
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/delegated_frame_host_client_aura.cc
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/delegated_frame_host_client_aura.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/content/test/test_render_view_host.h
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/f2624f2c1a13f4a81e930ffce84ef7eb227d3144/ui/android/delegated_frame_host_android.h

Comment 3 by akaba@chromium.org, Aug 21

Status: Fixed (was: Assigned)
►

Sign in to add a comment