New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 861764 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 857575



Sign in to add a comment

Frame eviction should also reset primary SurfaceId

Project Member Reported by samans@chromium.org, Jul 9

Issue description

Lack of fallback SurfaceId will no longer indicate that there will be no reference. Therefore frame eviction should also clear primary SurfaceId.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc96c6441c8c03dfde6ddd04b0b8465a83c858e

commit ebc96c6441c8c03dfde6ddd04b0b8465a83c858e
Author: akaba <akaba@google.com>
Date: Mon Jul 16 17:53:28 2018

Frame Eviction reset the whole surface range

Frame eviction shouldn't just reset the fallback to an unvalid surface but should reset the primary too. This is done by replacing the SurfaceLayer with a SolidColorLayer.

Bug:  861764 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I18b9ee11c9d0132dd41eb34a8dc79bdae09af393
Reviewed-on: https://chromium-review.googlesource.com/1136847
Commit-Queue: Andre Kaba <akaba@google.com>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575340}
[modify] https://crrev.com/ebc96c6441c8c03dfde6ddd04b0b8465a83c858e/cc/layers/surface_layer.h
[modify] https://crrev.com/ebc96c6441c8c03dfde6ddd04b0b8465a83c858e/content/browser/renderer_host/delegated_frame_host.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/025c4917a3d0a3420ec520807c348741988102ac

commit 025c4917a3d0a3420ec520807c348741988102ac
Author: akaba <akaba@google.com>
Date: Fri Jul 20 23:19:03 2018

Make Frame eviction more consistent between between Android and Desktop.

A follow up CL to
https://chromium.googlesource.com/chromium/src.git/+/ebc96c6441c8c03dfde6ddd04b0b8465a83c858e
to make DelegatedFrameHost::EvictDelegatedFrame consistant with
DelegatedFrameHostAndroid::EvictDelegatedFrame.

Bug:  861764 
Change-Id: I71b5e3a4c34f08f911bc0022d2b2dcb08427bb5a
Reviewed-on: https://chromium-review.googlesource.com/1141991
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Andre Kaba <akaba@google.com>
Cr-Commit-Position: refs/heads/master@{#577029}
[modify] https://crrev.com/025c4917a3d0a3420ec520807c348741988102ac/content/browser/renderer_host/delegated_frame_host.cc

Status: Fixed (was: Assigned)

Sign in to add a comment