New issue
Advanced search Search tips

Issue 861754 link

Starred by 1 user
Status: Fixed
Owner:
sunxd@chromium.org
Closed: Sep 25
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Renderer4.MainThreadWheelScrollReason doesn't seem to record wheel event handlers

Project Member Reported by flackr@chromium.org, Jul 9 
Chrome Version: 69.0.3483.0 (Developer Build) (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) Load attached HTML
(2) Scroll
(3) Load chrome://histograms and find Renderer4.MainThreadWheelScrollReason.

What is the expected result?
Expect a main thread reason for the main thread event handler.

What happens instead?
Instead, all scrolls seem to be reported as composited.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
mouse-handler.html
203 bytes View Download

Comment 1 by yigu@chromium.org, Jul 10 

FYI, the non fast scrollable region list is empty in TryScroll() https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_impl.cc?g=0&l=3342

Comment 2 by flackr@chromium.org, Jul 10 

Re #1, sunxd is currently working on adding regions for event handlers (issue 700075), right now they block scrolls anywhere on the page by checking for the presence of an event handler with class kWheelEventBlocking. I filed this bug because we don't actually record that we have blocked the wheel scroll on main - so we seem to have no accounting for how often this happens.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/679a7c694a84f31830841baf8e2a034639a51146

commit 679a7c694a84f31830841baf8e2a034639a51146
Author: Xianda Sun <sunxd@chromium.org>
Date: Tue Sep 25 19:17:05 2018

Merging MainThreadScrollingReason and ScrollingThreadStatus

This CL merges the two metrics because of their similarity. Apart from
that, MainThreadScrollingReason does not collect metrics when a scroller
is composited but still blocked on main thread due to event handlers.

We really care about the reasons that make scrolling slow, so we should
also collect composited but blocking cases and the two similar metrics
can be merged.

Bug:  861754 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I295d94f7ca3892dbfde34e4c61db0d95af92b1fe
Reviewed-on: https://chromium-review.googlesource.com/1226828
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594047}
[modify] https://crrev.com/679a7c694a84f31830841baf8e2a034639a51146/cc/input/main_thread_scrolling_reason.cc
[modify] https://crrev.com/679a7c694a84f31830841baf8e2a034639a51146/cc/input/main_thread_scrolling_reason.h
[modify] https://crrev.com/679a7c694a84f31830841baf8e2a034639a51146/cc/input/main_thread_scrolling_reason_unittest.cc
[modify] https://crrev.com/679a7c694a84f31830841baf8e2a034639a51146/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/679a7c694a84f31830841baf8e2a034639a51146/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/679a7c694a84f31830841baf8e2a034639a51146/ui/events/blink/input_handler_proxy_unittest.cc

Comment 4 by sunxd@chromium.org, Sep 25

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f5f716bb4afde1221284da07a4bafc1d4c020a

commit 48f5f716bb4afde1221284da07a4bafc1d4c020a
Author: Xianda Sun <sunxd@chromium.org>
Date: Wed Oct 03 15:43:23 2018

Update MainThreadScrollingReason histogram enum

The newly added MainThreadScrollingReasons: kWheelEventHandlerRegion and
kTouchEventHandlerRegion cannot be displayed correctly on UMA. This CL
updates the histogram enum in order to fix this bug.

Bug:  861754 
Change-Id: Ibd165ffe477cbc405d047bc820c77056d730ec6e
Reviewed-on: https://chromium-review.googlesource.com/c/1257549
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596228}
[modify] https://crrev.com/48f5f716bb4afde1221284da07a4bafc1d4c020a/tools/metrics/histograms/enums.xml
►

Sign in to add a comment