cast_shell_browsertests should run on swarming |
||||||||
Issue descriptiontest_suite_exceptions.pyl currently disables swarming for cast_shell_browsertests. cast_shell_browsertests should instead be made to pass under swarming (if it doesn't yet). The test is fast, so it's not a huge issue in practice, but all our tests should run on swarmin.
,
Jul 9
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e963ab6ec7d45fe25997828f68b495a6ab583366 commit e963ab6ec7d45fe25997828f68b495a6ab583366 Author: Nico Weber <thakis@chromium.org> Date: Mon Jul 09 17:21:53 2018 Run cast_shell_browsertests on swarming. Bug: 861753 Change-Id: Ib3b69cc03c2e50f531d612aa0f83ef4e3cb817aa Reviewed-on: https://chromium-review.googlesource.com/1129321 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573350} [modify] https://crrev.com/e963ab6ec7d45fe25997828f68b495a6ab583366/chromecast/browser/BUILD.gn [modify] https://crrev.com/e963ab6ec7d45fe25997828f68b495a6ab583366/testing/buildbot/chromium.linux.json [modify] https://crrev.com/e963ab6ec7d45fe25997828f68b495a6ab583366/testing/buildbot/test_suite_exceptions.pyl
,
Jul 9
,
Jul 10
Nico, cast_shell_browsertests started intermittently failing on the run with this CL included (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55533). Failure: https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8941458616937468304%2F%2B%2Fsteps%2Fcast_shell_browsertests%2F0%2Flogs%2FCastFeaturesBrowserTest.TestOnlyWellFormedFeaturesPersisted%2F0 Is it safe to revert the CL assuming that you don't see an immediate fix?
,
Jul 10
My guess is that some dependency is not properly expressed. Perhaps this? https://cs.chromium.org/chromium/src/chromecast/browser/cast_content_browser_client.cc?q=kGpuNoCont&sq=package:chromium&g=0&l=443
,
Jul 10
Yeah, save to revert.
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/629091a1e0f5089e143f947766ac7be9e7bdf44b commit 629091a1e0f5089e143f947766ac7be9e7bdf44b Author: Colin Blundell <blundell@chromium.org> Date: Tue Jul 10 14:50:28 2018 Revert "Run cast_shell_browsertests on swarming." This reverts commit e963ab6ec7d45fe25997828f68b495a6ab583366. Reason for revert: Causes cast_shell_browsertests to intermittently fail (see https://bugs.chromium.org/p/chromium/issues/detail?id=861753#c5). Original change's description: > Run cast_shell_browsertests on swarming. > > Bug: 861753 > Change-Id: Ib3b69cc03c2e50f531d612aa0f83ef4e3cb817aa > Reviewed-on: https://chromium-review.googlesource.com/1129321 > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573350} TBR=thakis@chromium.org,kbr@chromium.org,halliwell@chromium.org Change-Id: Iebfc1c8230f1671c2cca81a0e9144ef55c069fac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861753 Reviewed-on: https://chromium-review.googlesource.com/1131435 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#573723} [modify] https://crrev.com/629091a1e0f5089e143f947766ac7be9e7bdf44b/chromecast/browser/BUILD.gn [modify] https://crrev.com/629091a1e0f5089e143f947766ac7be9e7bdf44b/testing/buildbot/chromium.linux.json [modify] https://crrev.com/629091a1e0f5089e143f947766ac7be9e7bdf44b/testing/buildbot/test_suite_exceptions.pyl
,
Jul 10
,
Jul 10
,
Jul 11
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da3f703063b9200918c1ae426ba4ea68e9ee6555 commit da3f703063b9200918c1ae426ba4ea68e9ee6555 Author: Nico Weber <thakis@chromium.org> Date: Wed Jul 11 14:34:27 2018 Add comments explaining why the cast bots run two test suites unswarmed. Also add a data dep that's necessary (but apparently not sufficient) for cast_shell_browsertests to run on swarming. Bug: 861753, 861843 Change-Id: Ib10a8589c1349ac70dc4d4358395af6b2867d16b Reviewed-on: https://chromium-review.googlesource.com/1133201 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574156} [modify] https://crrev.com/da3f703063b9200918c1ae426ba4ea68e9ee6555/chromecast/browser/BUILD.gn [modify] https://crrev.com/da3f703063b9200918c1ae426ba4ea68e9ee6555/testing/buildbot/test_suite_exceptions.pyl
,
Jul 17
fix component |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by thakis@chromium.org
, Jul 9Status: Started (was: Untriaged)