New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 861748 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove methods to Start/Stop tracing from the browser.

Project Member Reported by perezju@chromium.org, Jul 9

Issue description

These legacy methods are now replaced by the corresponding calls
to the network_controller.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f3e7194f90e3631cf2d66eb6d4fcd2b0b685cc4a

commit f3e7194f90e3631cf2d66eb6d4fcd2b0b685cc4a
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Jul 09 14:33:20 2018

[Telemetry] Remove methods to Start/Stop tracing from browser

These legacy methods are now replaced by the corresponding calls
to the network_controller.

Bug:  chromium:861748 
Change-Id: If4122260ea726b61e77d4072bbe6ff11973622ad
Reviewed-on: https://chromium-review.googlesource.com/1128868
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/f3e7194f90e3631cf2d66eb6d4fcd2b0b685cc4a/telemetry/telemetry/internal/backends/browser_backend.py
[modify] https://crrev.com/f3e7194f90e3631cf2d66eb6d4fcd2b0b685cc4a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f95e270b9a1646f6d6d6189449db94b18e6e3068

commit f95e270b9a1646f6d6d6189449db94b18e6e3068
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jul 09 17:45:57 2018

Roll src/third_party/catapult 27380b171e3f..bea867a76a73 (3 commits)

https://chromium.googlesource.com/catapult.git/+log/27380b171e3f..bea867a76a73


git log 27380b171e3f..bea867a76a73 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 cphlipot0@gmail.com Android systrace: Fix undeclared use of strerr
2018-07-09 cphlipot0@gmail.com Android systrace: Fix undeclared references to POSIX APIs
2018-07-09 perezju@chromium.org [Telemetry] Remove methods to Start/Stop tracing from browser


Created with:
  gclient setdep -r src/third_party/catapult@bea867a76a73

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:861748 
TBR=sullivan@chromium.org

Change-Id: If54ccf0e48c55cc31f4ccf5cbde914848ae50ac3
Reviewed-on: https://chromium-review.googlesource.com/1129340
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573357}
[modify] https://crrev.com/f95e270b9a1646f6d6d6189449db94b18e6e3068/DEPS

Status: Fixed (was: Started)

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 5 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment