New issue
Advanced search Search tips

Issue 861735 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Window postMessage override with dictionary

Project Member Reported by dtapu...@chromium.org, Jul 9

Issue description

Support a new Window.postMessage override that takes a dictionary in.

This is necessary to be able to control propagation of user gesture information.

See https://github.com/dtapuska/useractivation and
https://github.com/whatwg/html/pull/3800
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb

commit f1699bba83a44c97b8ff24b0b13ade1d7df04cbb
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Jul 30 20:33:49 2018

Move the transfer object into WindowPostMessageOptions

Spec changes were requested and this change matches the spec changes.
https://github.com/whatwg/html/issues/3799

BUG= 861735 

Change-Id: Ie5f33e6d52eb5d904ae3c439ee488ab75a3b514d
Reviewed-on: https://chromium-review.googlesource.com/1151388
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579152}
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/broken-origin.tentative.html
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/host-specific-origin.tentative.html
[delete] https://crrev.com/767cc2d8e9720c997cd2dcee6562a60cd3df2717/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/invalid-args.tentative.html
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/message-channel-transferable.tentative.html
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/no-target-origin.tentative.html
[rename] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/null-transfer.tentative.html
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/slash-origin.tentative.html
[delete] https://crrev.com/767cc2d8e9720c997cd2dcee6562a60cd3df2717/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/two-arg.tentative.html
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/undefined-transferable.tentative.html
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/external/wpt/webmessaging/with-options/unknown-parameter.tentative.html
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/http/tests/security/postMessage/target-origin-expected.txt
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/WebKit/LayoutTests/http/tests/security/postMessage/target-origin.html
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/blink/renderer/core/frame/dom_window.cc
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/blink/renderer/core/frame/dom_window.h
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/blink/renderer/core/frame/window.idl
[modify] https://crrev.com/f1699bba83a44c97b8ff24b0b13ade1d7df04cbb/third_party/blink/renderer/core/frame/window_post_message_options.idl

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94475bdfffb535c2cbdee9745439329da09d068c

commit 94475bdfffb535c2cbdee9745439329da09d068c
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Aug 08 00:49:32 2018

Add a PostMessageOptions dictionary to match the current API.

The current pull request against the HTML spec is here:
https://github.com/whatwg/html/issues/3799

Add a PostMessgeOptions dictionary so that WindowPostMessageOptions is
a subclass of that.

BUG= 861735 

Change-Id: I66c6990de82b0d74efa7f31240b63d19d074945d
Reviewed-on: https://chromium-review.googlesource.com/1165954
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581417}
[modify] https://crrev.com/94475bdfffb535c2cbdee9745439329da09d068c/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/94475bdfffb535c2cbdee9745439329da09d068c/third_party/blink/renderer/core/frame/window_post_message_options.idl
[add] https://crrev.com/94475bdfffb535c2cbdee9745439329da09d068c/third_party/blink/renderer/core/messaging/post_message_options.idl

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23d1b73a4523a7a99e66d802e6bd568e8319cdd

commit c23d1b73a4523a7a99e66d802e6bd568e8319cdd
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Aug 10 12:46:22 2018

Remove usage of PostMessage IDL extended attribute.

In anticipation of adding a few more overloads to the postMessage APIs
in https://github.com/whatwg/html/issues/3799 ensure that the code doesn't
use the PostMessage extended attribute. Since the extended attribute doesn't support
overloading it was decided that these implementations should really be
reading the transferable argument themselves not in the bindings code.

Make two versions one that is used by service workers that causes
transferables to be copied and another that is used by workers,
and message_ports that treat them as moveable types.

BUG= 861735 

Change-Id: I82720aae73a1285d74b5c8f10b244c719290e2d9
Reviewed-on: https://chromium-review.googlesource.com/1165835
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582127}
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/bindings/bindings.gni
[add] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/bindings/core/v8/serialization/post_message_helper.cc
[add] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/bindings/core/v8/serialization/post_message_helper.h
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/frame/dom_window.cc
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/messaging/message_port.cc
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/messaging/message_port.h
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/messaging/message_port.idl
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/workers/dedicated_worker.h
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.h
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.idl
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/core/workers/worker.idl
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/modules/service_worker/client.idl
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/modules/service_worker/service_worker.h
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/modules/service_worker/service_worker.idl
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/modules/service_worker/service_worker_client.cc
[modify] https://crrev.com/c23d1b73a4523a7a99e66d802e6bd568e8319cdd/third_party/blink/renderer/modules/service_worker/service_worker_client.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/949105c912339f450ad544258f6b21e189710880

commit 949105c912339f450ad544258f6b21e189710880
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Aug 10 13:56:01 2018

Remove PostMessage IDL extended attribute.

Since usage was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1165835
remove it from the bindings generation.

BUG= 861735 

Change-Id: I20159b179f208d5cd35bdf3b9be4df7fa59082c0
Reviewed-on: https://chromium-review.googlesource.com/1167467
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582143}
[modify] https://crrev.com/949105c912339f450ad544258f6b21e189710880/third_party/blink/renderer/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/949105c912339f450ad544258f6b21e189710880/third_party/blink/renderer/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/949105c912339f450ad544258f6b21e189710880/third_party/blink/renderer/bindings/scripts/v8_methods.py
[modify] https://crrev.com/949105c912339f450ad544258f6b21e189710880/third_party/blink/renderer/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/949105c912339f450ad544258f6b21e189710880/third_party/blink/renderer/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/949105c912339f450ad544258f6b21e189710880/third_party/blink/renderer/bindings/tests/idls/core/test_object.idl
[modify] https://crrev.com/949105c912339f450ad544258f6b21e189710880/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
[modify] https://crrev.com/949105c912339f450ad544258f6b21e189710880/third_party/blink/renderer/bindings/tests/results/core/v8_test_object.h

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b306af5091a167ee09737e8f6f872a77df64917a

commit b306af5091a167ee09737e8f6f872a77df64917a
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Aug 13 16:59:34 2018

Add a PostMessageOptions API to workers and message_port

The current pull request against the HTML spec is here:
https://github.com/whatwg/html/issues/3799

Rename the RuntimeEnabledFeature from WindowPostMessageOptions to
PostMessageOptions

BUG= 861735 

Change-Id: Ia7980a85c10535f6d531c87f3790efcf6ed2d54d
Reviewed-on: https://chromium-review.googlesource.com/1169304
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582619}
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage.https.html
[add] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-dictionary-transferables-worker.js
[add] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/external/wpt/webmessaging/message-channels/dictionary-transferrable.html
[add] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/external/wpt/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-dictionary.html
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/external/wpt/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/second-argument-null.html
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/fast/events/message-port-multi-expected.txt
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/fast/events/resources/message-port-multi.js
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/fast/workers/resources/worker-context-thread-multi-port.js
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/fast/workers/resources/worker-multi-port.js
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/fast/workers/worker-context-multi-port-expected.txt
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/fast/workers/worker-multi-port-expected.txt
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/fast/workers/worker-onerror-09-expected.txt
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/WebKit/LayoutTests/fast/workers/worker-onerror-09.html
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/frame/window.idl
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/messaging/message_port.cc
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/messaging/message_port.h
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/messaging/message_port.idl
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/workers/dedicated_worker.h
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.h
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.idl
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/core/workers/worker.idl
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/modules/service_worker/client.idl
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/modules/service_worker/service_worker.h
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/modules/service_worker/service_worker.idl
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/modules/service_worker/service_worker_client.cc
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/modules/service_worker/service_worker_client.h
[modify] https://crrev.com/b306af5091a167ee09737e8f6f872a77df64917a/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/720f75396c34ad74a41d9ef49ebed455bac1f7e7

commit 720f75396c34ad74a41d9ef49ebed455bac1f7e7
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Aug 22 16:35:51 2018

Adjust some worker APIs to use BlinkTransferableMessage

Since we want to indicate the user gesture to postMessage to a
dedicated worker it is cleaner to adjust the worker APIs to take
a BlinkTransferableMessage.

This change is intended to have no behavioral change.

BUG= 861735 

Change-Id: I825d886877ae0931ce979c6b28930f754349dd9f
Reviewed-on: https://chromium-review.googlesource.com/1183288
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585061}
[modify] https://crrev.com/720f75396c34ad74a41d9ef49ebed455bac1f7e7/third_party/blink/renderer/core/messaging/blink_transferable_message.h
[modify] https://crrev.com/720f75396c34ad74a41d9ef49ebed455bac1f7e7/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/720f75396c34ad74a41d9ef49ebed455bac1f7e7/third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
[modify] https://crrev.com/720f75396c34ad74a41d9ef49ebed455bac1f7e7/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc
[modify] https://crrev.com/720f75396c34ad74a41d9ef49ebed455bac1f7e7/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.h
[modify] https://crrev.com/720f75396c34ad74a41d9ef49ebed455bac1f7e7/third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.cc
[modify] https://crrev.com/720f75396c34ad74a41d9ef49ebed455bac1f7e7/third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.h
[modify] https://crrev.com/720f75396c34ad74a41d9ef49ebed455bac1f7e7/third_party/blink/renderer/core/workers/dedicated_worker_test.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2fd13720ce018729ccd795b7abaa52cf5f4614f

commit e2fd13720ce018729ccd795b7abaa52cf5f4614f
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Aug 22 19:21:04 2018

Add ability to send user activation context to message port and workers.

As per the latest update to https://github.com/dtapuska/useractivation
exposing the UserActivation on the MessagePort was needed. So this
adds the code and a few tests.

BUG= 861735 

Change-Id: I3439b67c75e53666243a2ec36d8d93e6c23de5b4
Reviewed-on: https://chromium-review.googlesource.com/1183683
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585195}
[add] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/WebKit/LayoutTests/external/wpt/webmessaging/message-channels/user-activation.tentative.html
[add] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/WebKit/LayoutTests/external/wpt/webmessaging/worker_postMessage_user_activation.js
[add] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/WebKit/LayoutTests/external/wpt/webmessaging/worker_postMessage_user_activation.tentative.html
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/bindings/core/v8/serialization/post_message_helper.cc
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/bindings/core/v8/serialization/post_message_helper.h
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/core/events/message_event.cc
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/core/events/message_event.h
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/core/events/message_event.idl
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/core/events/message_event_init.idl
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/core/frame/window_post_message_options.idl
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/core/messaging/message_port.cc
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/core/messaging/post_message_options.idl
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/e2fd13720ce018729ccd795b7abaa52cf5f4614f/third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.cc

Labels: M-70
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fa5613cb693bc6ad0fa1752d2c32d5c4c838b0a

commit 7fa5613cb693bc6ad0fa1752d2c32d5c4c838b0a
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Aug 22 22:15:23 2018

Enable PostMessage overloads.

Approved Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/HSfL38bAexE/n9QuIIILDwAJ

BUG= 861735 

Change-Id: I3784f1a6b9c4f117563d273d5710cbe2784ac5ac
Reviewed-on: https://chromium-review.googlesource.com/1185725
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585276}
[modify] https://crrev.com/7fa5613cb693bc6ad0fa1752d2c32d5c4c838b0a/third_party/blink/renderer/platform/runtime_enabled_features.json5

Status: Fixed (was: Assigned)

Sign in to add a comment