New issue
Advanced search Search tips

Issue 861732 link

Starred by 2 users
Status: Fixed
Owner:
jdoerrie@chromium.org
Closed: Jul 10
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Settings: Runtime error thrown when searching with Autofill Home Disabled

Project Member Reported by jdoerrie@chromium.org, Jul 9 
Chrome Version       :  69.0.3476.0
OS: Desktop

What steps will reproduce the problem?
(1) Run Chrome with --disable-features="AutofillHome"
(2) Open chrome://settings
(3) Search for "passwords" (or "addresses", "credit cards"...)

What is the expected result?
Search Bubbles are shown, no assertion error.

What happens instead?
Search Bubbles are shown, but an assertion error is triggered:
Assertion failed: An associated control was expected for SETTINGS-SUBPAGE Manage passwords, but was not found.", source: chrome://settings/crisper.js (24) 

See also attached Screenshot
runtime_error.png
102 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a57aa107f0b41bf28fa741d75f6dda171811034e

commit a57aa107f0b41bf28fa741d75f6dda171811034e
Author: jdoerrie <jdoerrie@chromium.org>
Date: Mon Jul 09 22:02:10 2018

[Autofill Home] Fix Runtime Errors When Searching

This change fixes runtime errors introduced by the recent Autofill Home
change.

Bug:  861732 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia445d198ea4f4945b213df3e0f4d76509032c895
Reviewed-on: https://chromium-review.googlesource.com/1122616
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573469}
[modify] https://crrev.com/a57aa107f0b41bf28fa741d75f6dda171811034e/chrome/browser/resources/settings/people_page/people_page.html

Comment 2 by jdoerrie@chromium.org, Jul 10

Status: Fixed (was: Started)

Comment 3 by susan.boorgula@chromium.org, Jul 10

Labels: Needs-Feedback
Tested this issue on Windows 10 and Mac OS 10.13.3 on the reported version 67.0.3396.99 and unable to reproduce the issue by following the below steps.

1. Launched Chrome with flag --disable-features="AutofillHome".
2. navigated to chrome://settings and opened Devtools -> Console.
3. Searched for some text and couldn't observe any runtime error thrown on Console.
Attached is the screen cast for reference.

jdoerrie@ Request you to check and confirm if anything is missed from our end in verifying the issue?

Thanks..
861732.mp4
1.3 MB View Download

Comment 4 by jdoerrie@chromium.org, Jul 10

Description: Show this description

Comment 5 by jdoerrie@chromium.org, Jul 10 

Apologies, I used the wrong version number by mistake. The bug was introduced in version 69.0.3476.0 and should be fixed in 69.0.3487.0. Could you verify whether this is indeed the case?
►

Sign in to add a comment