The two methods are being merged. Some additional cleanup will be needed after. This bug is here to track it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5220d0e27bde79cdb393de6f20ca0591d44504ac commit 5220d0e27bde79cdb393de6f20ca0591d44504ac Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Aug 14 10:58:15 2018 Rename openURL: to openURLInNewTab: This CL rename the openURL: method to indicate that it is loading the URL in a new tab. Bug: 861729 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bea43c3589070c1b32b8d7bf08330edab9f59e2 Reviewed-on: https://chromium-review.googlesource.com/1174255 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582885} [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/app/application_delegate/app_state.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/app/application_delegate/app_state_unittest.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/app/main_controller.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/passwords/ios_chrome_password_manager_infobar_delegate.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/ui/commands/application_commands.h [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/ui/key_commands_provider.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/ui/ntp/new_tab_page_perftest.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/ui/sad_tab/sad_tab_view.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/ui/tabs/tab_strip_controller.mm [modify] https://crrev.com/5220d0e27bde79cdb393de6f20ca0591d44504ac/ios/chrome/browser/upgrade/upgrade_center.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc commit 3bf8ee3917aa1e9a47fd74d9de6068c3997791cc Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Aug 16 13:26:04 2018 Remove TabGrid implementation of BrowserCommands This CL removes the TabGrid implementation of BrowserCommands. This is done such as the -openNewTab: method of BrowserCommands can be removed in UI Refresh, merged away in the -openURL: method in ApplicationCommands. Bug: 861729 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I001e387a3f4668ff2291c49ef83354888ea81a03 Reviewed-on: https://chromium-review.googlesource.com/1127898 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#583627} [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/app/main_controller.mm [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest.mm [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/browser/ui/stack_view/stack_view_controller.h [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/browser/ui/tab_grid/tab_grid_adaptor.h [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/browser/ui/tab_grid/tab_grid_adaptor.mm [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/browser/ui/tab_switcher/tab_switcher.h [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.h [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/test/app/chrome_test_util.h [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/test/app/chrome_test_util.mm [modify] https://crrev.com/3bf8ee3917aa1e9a47fd74d9de6068c3997791cc/ios/chrome/test/app/tab_test_util.mm
Comment 1 by bugdroid1@chromium.org
, Aug 14