Incognito preferences default storage should be in memory. |
|||
Issue descriptionIncognito preferences default storage is now on disk and if a preference should not be written to disk, it is block-listed in CreateIncognitoPrefServiceSyncable. This creates the possibility of storing incognito preferences on disk by forgetting to add them to block-list. To make the behavior more privacy preserving, the default should be in memory storage of incognito preferences and if required, specific types would be allow-listed.
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/201689d551356adbe8b98ccbcc21ac14c6dd2ff4 commit 201689d551356adbe8b98ccbcc21ac14c6dd2ff4 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Jul 19 05:01:53 2018 Remove Clear Browsing Data preferences from incognito whitelist. Clear browsing data preferences (browsing_data::prefs::*) are removed from incognito whitelist for persistent storage. The browsing_data preferences are used by Clear Browsing Data, which is only available in regular mode. Bug: 861722 Change-Id: I7835f8b1ad2a8b4a8b7bb72b99401b281823f313 Reviewed-on: https://chromium-review.googlesource.com/1141565 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#576375} [modify] https://crrev.com/201689d551356adbe8b98ccbcc21ac14c6dd2ff4/chrome/browser/prefs/pref_service_incognito_whitelist.cc [modify] https://crrev.com/201689d551356adbe8b98ccbcc21ac14c6dd2ff4/chrome/browser/prefs/pref_service_syncable_util.cc
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dcbf4d493a0e0a1b931c748cebadb6c531b1531 commit 1dcbf4d493a0e0a1b931c748cebadb6c531b1531 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jul 19 11:44:01 2018 Make rhalavati@ owner of the incognito whitelist. rhalavati@ is the right owner (from privacy) for this and prefs/OWNERS don't need to involved in its cleanup nor related tweaks (e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1129385) R=rhalavati@chromium.org Bug: 861722 Change-Id: I45e517388285980df2eadcb04cd85edf1558b28d Reviewed-on: https://chromium-review.googlesource.com/1142291 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#576444} [modify] https://crrev.com/1dcbf4d493a0e0a1b931c748cebadb6c531b1531/chrome/browser/prefs/OWNERS [modify] https://crrev.com/1dcbf4d493a0e0a1b931c748cebadb6c531b1531/chrome/browser/prefs/pref_service_incognito_whitelist.h
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23e9b57c0d952d1b8c0af7b3be1557449174340b commit 23e9b57c0d952d1b8c0af7b3be1557449174340b Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Jul 19 17:28:14 2018 Remove Content Settings Core preferences from incognito whitelist. Preferences defined in 'components/content_settings/core/common/pref_names.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I6f7c8ef8cf57db3a4895b661b2ab1e1e874338c7 Reviewed-on: https://chromium-review.googlesource.com/1141566 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#576540} [modify] https://crrev.com/23e9b57c0d952d1b8c0af7b3be1557449174340b/chrome/browser/net/network_context_configuration_browsertest.cc [modify] https://crrev.com/23e9b57c0d952d1b8c0af7b3be1557449174340b/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecd8273e999e54e13aab21c6d726d4636f04c78c commit ecd8273e999e54e13aab21c6d726d4636f04c78c Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Jul 20 04:16:39 2018 Remove Translate preferences from incognito whitelist. Preferences defined in 'components/translate/core/browser/translate_pref_names.h' 'components/translate/core/browser/translate_prefs.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I5d54f16d6637a6da53514a01ffe1f19f9ad2f4f1 Reviewed-on: https://chromium-review.googlesource.com/1142774 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#576775} [modify] https://crrev.com/ecd8273e999e54e13aab21c6d726d4636f04c78c/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee74699e8ee4e04de4189a8f178751ebdd15ec0f commit ee74699e8ee4e04de4189a8f178751ebdd15ec0f Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Jul 20 09:50:51 2018 Remove NTP preferences from incognito whitelist. NTP preferences are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: Icf97bcb06a9002e0145451b33f4cc1e2c56f1ed8 Reviewed-on: https://chromium-review.googlesource.com/1144820 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#576822} [modify] https://crrev.com/ee74699e8ee4e04de4189a8f178751ebdd15ec0f/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38c375648d86dd68e2b50713cbbe991481f68521 commit 38c375648d86dd68e2b50713cbbe991481f68521 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Jul 20 15:32:20 2018 Remove Sync preferences from incognito whitelist. Preferences defined in: 'components/sync/base/pref_names.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I7cbfdb7a59e6a6404cda79fb3f1a7dd7b4325e99 Reviewed-on: https://chromium-review.googlesource.com/1145266 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#576872} [modify] https://crrev.com/38c375648d86dd68e2b50713cbbe991481f68521/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/422eb9537b737ac8764bc6827534e4cba964a809 commit 422eb9537b737ac8764bc6827534e4cba964a809 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Jul 25 05:20:12 2018 Remove policy preferences from incognito whitelist. Policy preferences are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Bug: 866422 Change-Id: I3d5eea500c6801a89547bb38608f187675b73681 Reviewed-on: https://chromium-review.googlesource.com/1148053 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#577805} [modify] https://crrev.com/422eb9537b737ac8764bc6827534e4cba964a809/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bce35f2af9857c3b7dc733e57870c3687b4a11b commit 2bce35f2af9857c3b7dc733e57870c3687b4a11b Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Jul 25 19:31:27 2018 Remove Data Reduction Proxy preferences from incognito whitelist. Preferences defined in: 'components/data_reduction_proxy/core/common/' 'data_reduction_proxy_pref_names.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: Ic3eecaa21127a36f95debfc5b44abfc70fbe57a0 Reviewed-on: https://chromium-review.googlesource.com/1149368 Reviewed-by: Scott Little <sclittle@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#578017} [modify] https://crrev.com/2bce35f2af9857c3b7dc733e57870c3687b4a11b/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09a57bcb5b3e2877e0fcc648cc45729682d7217e commit 09a57bcb5b3e2877e0fcc648cc45729682d7217e Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Jul 26 09:42:07 2018 Remove Webkit preferences from incognito whitelist. Preferences related to Webkit are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I8c449d7aee9ca4abb2ea2becc7edf01a4058ebb8 Reviewed-on: https://chromium-review.googlesource.com/1150028 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#578248} [modify] https://crrev.com/09a57bcb5b3e2877e0fcc648cc45729682d7217e/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4682b19ef501613d96768c07e83d529fdc8b05f7 commit 4682b19ef501613d96768c07e83d529fdc8b05f7 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Jul 30 06:47:37 2018 Remove ash preferences from incognito whitelist. Preferences defined in: 'ash/public/cpp/ash_pref_names.h' 'ash/public/cpp/shelf_prefs.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: If62781c31693db1b8b755ce46bd75f2c6eceda5a Reviewed-on: https://chromium-review.googlesource.com/1141567 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#578986} [modify] https://crrev.com/4682b19ef501613d96768c07e83d529fdc8b05f7/chrome/browser/prefs/pref_service_incognito_whitelist.cc [modify] https://crrev.com/4682b19ef501613d96768c07e83d529fdc8b05f7/chrome/browser/prefs/pref_service_syncable_util.cc
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36ff521efe5743c64ddd511ef540d6a377200d42 commit 36ff521efe5743c64ddd511ef540d6a377200d42 Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Jul 31 09:43:55 2018 Remove Password Manager preferences from incognito whitelist. Preferences related to Password Manager are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I298e226c93a990473158e8eb455fa70370aa6751 Reviewed-on: https://chromium-review.googlesource.com/1155601 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579363} [modify] https://crrev.com/36ff521efe5743c64ddd511ef540d6a377200d42/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/846c336ff42acef4d8f9a2efdd3542a693aee4ef commit 846c336ff42acef4d8f9a2efdd3542a693aee4ef Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Jul 31 14:36:50 2018 Remove Autofill preferences from incognito whitelist. Preferences related to Autofill are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I3ea4b2dc62c6dbb9edeecd691f5a22d48eb52862 Reviewed-on: https://chromium-review.googlesource.com/1156402 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579400} [modify] https://crrev.com/846c336ff42acef4d8f9a2efdd3542a693aee4ef/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2031eb238f227038344913a514b21a07a19d463 commit a2031eb238f227038344913a514b21a07a19d463 Author: Gabriel Charette <gab@chromium.org> Date: Tue Jul 31 14:54:48 2018 Expand ownership of incognito whitelist to pref_service_syncable_util.cc e.g. for CLs like https://chromium-review.googlesource.com/c/chromium/src/+/1142503 R=rhalavati@chromium.org Bug: 861722 Change-Id: I9c7d48e6c73dae3af13d48e32d224600f2f10aa2 Reviewed-on: https://chromium-review.googlesource.com/1156476 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#579405} [modify] https://crrev.com/a2031eb238f227038344913a514b21a07a19d463/chrome/browser/prefs/OWNERS
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/187c369f53efb7b93342dc1e6a2dc7f8726d7276 commit 187c369f53efb7b93342dc1e6a2dc7f8726d7276 Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Jul 31 16:09:38 2018 Remove Extensions preferences from incognito whitelist. Preferences related to Extensions are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Id54e7c234961d6814c3bd55692c93a28d2917f84 Reviewed-on: https://chromium-review.googlesource.com/1149370 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579422} [modify] https://crrev.com/187c369f53efb7b93342dc1e6a2dc7f8726d7276/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ac3edc20843541c0b81ac092cda56725402edf6 commit 3ac3edc20843541c0b81ac092cda56725402edf6 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 01 04:20:13 2018 Remove Safe Browsing preferences from incognito whitelist. Preferences related to Safe Browsing are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I4e19fd53d5fd6c1e59991be70f443c94696d0b7f Reviewed-on: https://chromium-review.googlesource.com/1155599 Reviewed-by: Jialiu Lin <jialiul@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579697} [modify] https://crrev.com/3ac3edc20843541c0b81ac092cda56725402edf6/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0d658f7c849dc0fa1bc410869031fc972484e16 commit a0d658f7c849dc0fa1bc410869031fc972484e16 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 01 05:40:13 2018 Remove Component Updater preferences from incognito whitelist. Preferences defined in: 'components/component_updater/pref_names.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I390ffc5b63aff52d197cd0ad1ef47a6b6b4c683c Reviewed-on: https://chromium-review.googlesource.com/1145269 Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579710} [modify] https://crrev.com/a0d658f7c849dc0fa1bc410869031fc972484e16/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1620e033b593e69a139b35625a3712d8450457fe commit 1620e033b593e69a139b35625a3712d8450457fe Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 01 09:43:08 2018 Remove ChromeOS Tethering preferences from incognito whitelist. Preferences related to ChromeOS Thethering are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I3faa7ad982ace7347a894f3f3225332d0a437ed0 Reviewed-on: https://chromium-review.googlesource.com/1158068 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579740} [modify] https://crrev.com/1620e033b593e69a139b35625a3712d8450457fe/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4fe0fd4c7eed73967e4b5284cff73827510781c commit f4fe0fd4c7eed73967e4b5284cff73827510781c Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 01 11:11:35 2018 Remove ChromeOS Proximity Auth preferences from incognito whitelist. Preferences related to ChromeOS Proximity Auth are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Id9247d7ba200705786327aeab7f251a77de0435f Reviewed-on: https://chromium-review.googlesource.com/1158067 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#579757} [modify] https://crrev.com/f4fe0fd4c7eed73967e4b5284cff73827510781c/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/275d9f6af2e9ed4a1669f7059e500c8a66978bb8 commit 275d9f6af2e9ed4a1669f7059e500c8a66978bb8 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 01 16:32:58 2018 Move incognito persistent preferences list. The list of preferences that are stored in user profile when changed from incognito mode are moved from 'chrome/browser/prefs/pref_service_syncable_util.cc' to 'chrome/browser/prefs/pref_service_incognito_whitelist.cc'. Bug: 861722 Change-Id: Ic13e7c45f5c82193bf29cfdeac2d3ffe7c186fc9 Reviewed-on: https://chromium-review.googlesource.com/1158064 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#579832} [modify] https://crrev.com/275d9f6af2e9ed4a1669f7059e500c8a66978bb8/chrome/browser/prefs/OWNERS [modify] https://crrev.com/275d9f6af2e9ed4a1669f7059e500c8a66978bb8/chrome/browser/prefs/pref_service_incognito_whitelist.cc [modify] https://crrev.com/275d9f6af2e9ed4a1669f7059e500c8a66978bb8/chrome/browser/prefs/pref_service_incognito_whitelist.h [modify] https://crrev.com/275d9f6af2e9ed4a1669f7059e500c8a66978bb8/chrome/browser/prefs/pref_service_syncable_util.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecade6c5065d00eb247891e58cb8727b8054824b commit ecade6c5065d00eb247891e58cb8727b8054824b Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 02 06:06:42 2018 Remove Metrics preferences from incognito whitelist. Preferences defined in: 'components/metrics/metrics_pref_names.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I3cf9ee5bb0ad248a95fbcbef51cd0c18e5d513be Reviewed-on: https://chromium-review.googlesource.com/1149365 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#580086} [modify] https://crrev.com/ecade6c5065d00eb247891e58cb8727b8054824b/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f32a52484842b44e4e605adb62c85774691bdf85 commit f32a52484842b44e4e605adb62c85774691bdf85 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 02 08:52:33 2018 Remove Supervised User preferences from incognito whitelist. Preferences related to Supervised Users are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I74259a24fa1747298f80a627247f5777fad163f4 Reviewed-on: https://chromium-review.googlesource.com/1159365 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#580118} [modify] https://crrev.com/f32a52484842b44e4e605adb62c85774691bdf85/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e817cb44df3420e9494e2a36d85179a8f336dbf commit 3e817cb44df3420e9494e2a36d85179a8f336dbf Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 02 09:52:04 2018 Remove SignIn preferences from incognito whitelist. Preferences related to SignIn are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I03fbc9c62227ca1cbb3b58b9ee2f9ad90df9b586 Reviewed-on: https://chromium-review.googlesource.com/1159367 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#580124} [modify] https://crrev.com/3e817cb44df3420e9494e2a36d85179a8f336dbf/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59435c3ad7720c5550f6713d5c7718698d4f1d5c commit 59435c3ad7720c5550f6713d5c7718698d4f1d5c Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 02 14:32:28 2018 Remove Spell Check preferences from incognito whitelist. Preferences related to Spell Check are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I09b64981a24f918cd62d82e487b265b4a0179a7b Reviewed-on: https://chromium-review.googlesource.com/1159368 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580171} [modify] https://crrev.com/59435c3ad7720c5550f6713d5c7718698d4f1d5c/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d84459753860b192c0b1685639f2f50a10c5dec commit 9d84459753860b192c0b1685639f2f50a10c5dec Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 06 06:09:11 2018 Remove Arc preferences from incognito whitelist. Preferences related to Arc are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I45d5f5bb40841c386d39709d9da80ca431b2a2e1 Reviewed-on: https://chromium-review.googlesource.com/1158069 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#580809} [modify] https://crrev.com/9d84459753860b192c0b1685639f2f50a10c5dec/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdca4eb1132c172b6456bd5c6e9107625b443a1f commit bdca4eb1132c172b6456bd5c6e9107625b443a1f Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Aug 07 04:25:12 2018 Remove CryptAuth preferences from incognito whitelist. Preferences related to CryptAuth are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I390bd032a255db1141430a1ab1a791d01227145d Reviewed-on: https://chromium-review.googlesource.com/1159366 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581131} [modify] https://crrev.com/bdca4eb1132c172b6456bd5c6e9107625b443a1f/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6048aabe0b5a5f1515bcc88a2aff19ce8ccaa5b5 commit 6048aabe0b5a5f1515bcc88a2aff19ce8ccaa5b5 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 08 05:45:21 2018 Move Variations preferences to incognito persistent whitelist. Preferences related to Variations are moved to the incognito persistent storage list. This CL does not change the current behavior. Bug: 861722 Change-Id: Iff56f55450639bf95848f3c1c97d7452f2c649a8 Reviewed-on: https://chromium-review.googlesource.com/1159369 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581483} [modify] https://crrev.com/6048aabe0b5a5f1515bcc88a2aff19ce8ccaa5b5/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6aadbd46a12f96d0bce635f012415eed564958be commit 6aadbd46a12f96d0bce635f012415eed564958be Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 08 08:56:18 2018 Move Bookmarks preferences to incognito persistent whitelist. Preferences related to bookmarks are moved to the incognito persistent storage list. This CL does not change the current behavior. Bug: 861722 Change-Id: I03e11cf0a2bb84872db4b96443b9d1d0db4002f5 Reviewed-on: https://chromium-review.googlesource.com/1166830 Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581505} [modify] https://crrev.com/6aadbd46a12f96d0bce635f012415eed564958be/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90352173958179c4e2c04b75f7cc2799b0304681 commit 90352173958179c4e2c04b75f7cc2799b0304681 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 08 10:00:52 2018 Remove Crostini preferences from incognito whitelist. Preferences related to Crostini are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I115c8fee12d105ebfe56a177d19d95d8e8106357 Reviewed-on: https://chromium-review.googlesource.com/1166825 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581509} [modify] https://crrev.com/90352173958179c4e2c04b75f7cc2799b0304681/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96687fafffbfdc9bcca8ce6dd01283726a17f4d3 commit 96687fafffbfdc9bcca8ce6dd01283726a17f4d3 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 08 13:52:19 2018 Remove Certificate Transparency preferences from incognito whitelist. Preferences related to Certificate Transparency are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I5971f1aa34f0a6f3b47f2a8ba0234e7d00d31738 Reviewed-on: https://chromium-review.googlesource.com/1166832 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581550} [modify] https://crrev.com/96687fafffbfdc9bcca8ce6dd01283726a17f4d3/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a370c82ec5626bd139a528b30d4653c2f3a2f4 commit e6a370c82ec5626bd139a528b30d4653c2f3a2f4 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 08 15:26:09 2018 Remove ChromeOS Power preferences from incognito whitelist. Preferences related to ChromeOS Power are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I0b3bf1fb7d4863349a4a3e932965845f9aaf232a Reviewed-on: https://chromium-review.googlesource.com/1158066 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581567} [modify] https://crrev.com/e6a370c82ec5626bd139a528b30d4653c2f3a2f4/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79a5885c95c6b4de89a0e4128be1abeaf8b9a275 commit 79a5885c95c6b4de89a0e4128be1abeaf8b9a275 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 09 04:31:22 2018 Remove ChromeOS language remap preferences from incognito whitelist. Preferences related to ChromeOS language remap are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I86da7605639c1d7f8bc0baf5bfbcd4aac573f020 Reviewed-on: https://chromium-review.googlesource.com/1166822 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581783} [modify] https://crrev.com/79a5885c95c6b4de89a0e4128be1abeaf8b9a275/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/817c4d130019fb37f56b9c975cec748c98342f4a commit 817c4d130019fb37f56b9c975cec748c98342f4a Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 09 04:31:53 2018 Remove ChromeOS Drive preferences from incognito whitelist. Preferences related to ChromeOS Drive are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ic2be139b20c90b7a372560c682d34dad527c9e62 Reviewed-on: https://chromium-review.googlesource.com/1166824 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581784} [modify] https://crrev.com/817c4d130019fb37f56b9c975cec748c98342f4a/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca776f20c00334888b2422553d4cee50710bb1f7 commit ca776f20c00334888b2422553d4cee50710bb1f7 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 13 05:12:10 2018 Move UKM preferences to incognito persietent list. Preferences related to UKM are moved to the persistent storage list for incognito mode. This CL does not change any current behaviore. Bug: 861722 Change-Id: I80e3ab0ef4326e7e6105649c3fe376be1755c755 Reviewed-on: https://chromium-review.googlesource.com/1166826 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582508} [modify] https://crrev.com/ca776f20c00334888b2422553d4cee50710bb1f7/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b850e268e4e6a029e51ef1d60645e4ce7905244 commit 3b850e268e4e6a029e51ef1d60645e4ce7905244 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 13 07:07:07 2018 Move Rappor preferences to incognito persistent whitelist. Preferences related to Rapor are moved to the incognito persistent storage list. This CL does not change the current behavior. Bug: 861722 Change-Id: Ie2212b845d2ce9a73d60a7fc24ae480b29b56420 Reviewed-on: https://chromium-review.googlesource.com/1166829 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#582517} [modify] https://crrev.com/3b850e268e4e6a029e51ef1d60645e4ce7905244/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/699e98d1be973b4d4a937722afa944f01db116e7 commit 699e98d1be973b4d4a937722afa944f01db116e7 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 13 14:11:47 2018 Remove Unified Consent preferences from incognito whitelist. Preferences related to unified consent are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I733657f359b34369fcef0559660cd14c74bfb181 Reviewed-on: https://chromium-review.googlesource.com/1172131 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582573} [modify] https://crrev.com/699e98d1be973b4d4a937722afa944f01db116e7/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/983e3fa37bbe0df9e367ea420f37bf267fde278a commit 983e3fa37bbe0df9e367ea420f37bf267fde278a Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Aug 14 04:42:44 2018 Remove Startup Metrics preferences from incognito persistent whitelist. Preferences related to Startup Metrics are removed from incognito persistent storage list. Bug: 861722 Change-Id: Id42fa05d2aabb38d4ec31dd01c012765d9f98d40 Reviewed-on: https://chromium-review.googlesource.com/1166827 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582832} [modify] https://crrev.com/983e3fa37bbe0df9e367ea420f37bf267fde278a/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f15b4f5405c023a8e761d056c28674539e0797b commit 0f15b4f5405c023a8e761d056c28674539e0797b Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 15 06:08:35 2018 Remove Contextual Suggestions preferences from incognito whitelist. Contextual Suggestions preferences are removed from the persistent storage list for incognito mode. After this CL, if this preference is changed from incognito mode, it is only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ia1c68e786c3509905391651c9a95cf2d152bf5ea Reviewed-on: https://chromium-review.googlesource.com/1174117 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583176} [modify] https://crrev.com/0f15b4f5405c023a8e761d056c28674539e0797b/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2aa8afec9831acc891d8d1c1781a21dd291af07e commit 2aa8afec9831acc891d8d1c1781a21dd291af07e Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 15 06:34:06 2018 Remove Network Time preferences from incognito whitelist. Preferences related to network time are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I7a37a22be09e21942e608b1f407b1d27704fa8fd Reviewed-on: https://chromium-review.googlesource.com/1172134 Reviewed-by: Nicolas Zea <zea@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583180} [modify] https://crrev.com/2aa8afec9831acc891d8d1c1781a21dd291af07e/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c266aea5fe7852842b455dad4a4327108ec080c commit 4c266aea5fe7852842b455dad4a4327108ec080c Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 15 06:52:17 2018 Remove Proxy Config preferences from incognito whitelist. Preferences related to proxy config are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I2670d44b59443f1c26844612842402511d246e63 Reviewed-on: https://chromium-review.googlesource.com/1172133 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583183} [modify] https://crrev.com/4c266aea5fe7852842b455dad4a4327108ec080c/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/052ff32c69ed1725bcd6319944de1452f6a7f64c commit 052ff32c69ed1725bcd6319944de1452f6a7f64c Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 16 05:27:24 2018 Remove five ash preferences from incognito whitelist. The following preferences are removed from the persistent storage list for incognito mode: ash::prefs::kDetachableBaseDevices ash::prefs::kEnableStylusTools ash::prefs::kHasSeenStylus ash::prefs::kTouchpadEnabled ash::prefs::kTouchscreenEnabled After this CL, if this preference is changed from incognito mode, it is only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I09e6cb8d42659648ee4bc202cdb2ac7b3a3af83b Reviewed-on: https://chromium-review.googlesource.com/1174116 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583549} [modify] https://crrev.com/052ff32c69ed1725bcd6319944de1452f6a7f64c/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3df624e294723722a1150e29c1b24ea4b6a122e3 commit 3df624e294723722a1150e29c1b24ea4b6a122e3 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 16 05:31:50 2018 Remove Prefetch and Offline pages preferences from incognito whitelist. Prefetch and Offline pages preferences are removed from the persistent storage list for incognito mode. After this CL, if this preference is changed from incognito mode, it is only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ie4b9a3aa86c4950b7a26849ce3fd405a22575319 Reviewed-on: https://chromium-review.googlesource.com/1174119 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583551} [modify] https://crrev.com/3df624e294723722a1150e29c1b24ea4b6a122e3/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e84f8028075baac6675a30c0dea43bf33901ac9 commit 3e84f8028075baac6675a30c0dea43bf33901ac9 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 16 05:34:12 2018 Remove Preferences Reset Time from incognito whitelist. Preferences Reset Time is removed from the persistent storage list for incognito mode. After this CL, if this preference is changed from incognito mode, it is only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I063fc4d41ab9150ce77070ed08fe17c6371339dc Reviewed-on: https://chromium-review.googlesource.com/1172129 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583552} [modify] https://crrev.com/3e84f8028075baac6675a30c0dea43bf33901ac9/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb023a8529eb397b174f7b5e3183a04ef7fa91cc commit cb023a8529eb397b174f7b5e3183a04ef7fa91cc Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 16 15:57:52 2018 Remove Settings Reset Prompt preferences from incognito whitelist. Settings Reset Prompt preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I84164f5734290d20c2a50ed93139645b91561296 Reviewed-on: https://chromium-review.googlesource.com/1176808 Commit-Queue: Robert Shield <robertshield@chromium.org> Reviewed-by: Robert Shield <robertshield@chromium.org> Cr-Commit-Position: refs/heads/master@{#583676} [modify] https://crrev.com/cb023a8529eb397b174f7b5e3183a04ef7fa91cc/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 16
(this is great but I'm getting a lot of email updates :)
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a71d6ecfbb5508d866229c4dc56eaee9bc5ec161 commit a71d6ecfbb5508d866229c4dc56eaee9bc5ec161 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 16 21:32:34 2018 Remove Cloud Print preferences from incognito whitelist. Cloud Print preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I601f41f611a81c2a5dccc712dba7f5e5626c923a Reviewed-on: https://chromium-review.googlesource.com/1176810 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583821} [modify] https://crrev.com/a71d6ecfbb5508d866229c4dc56eaee9bc5ec161/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af3f617ce5822d8a4ea6161d2cc6acefebc3b16e commit af3f617ce5822d8a4ea6161d2cc6acefebc3b16e Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Aug 17 04:48:40 2018 Remove ChromeOS Audio preferences from incognito whitelist. ChromeOS Audio preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. This CL won't affect changes from Settings page. Bug: 861722 Change-Id: Id4f4bf82494188ac4501248ffdf4867187b77d3d Reviewed-on: https://chromium-review.googlesource.com/1176807 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583964} [modify] https://crrev.com/af3f617ce5822d8a4ea6161d2cc6acefebc3b16e/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a5aa120e3719344df36116d1f712e8264cbe627 commit 6a5aa120e3719344df36116d1f712e8264cbe627 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Aug 17 04:51:26 2018 Remove Suggestions and Feed preferences from incognito whitelist. Suggestions and Feed preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ibe4c2545c0d9bab6efd82f1d0972c22bec176c1b Reviewed-on: https://chromium-review.googlesource.com/1176804 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#583965} [modify] https://crrev.com/6a5aa120e3719344df36116d1f712e8264cbe627/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c65c865826f0deaca9e578324ec2f1716fab6ac6 commit c65c865826f0deaca9e578324ec2f1716fab6ac6 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Aug 17 19:38:23 2018 Move Google URL preferences to incognito persistent whitelist. Google URL preferences are moved to the persistent storage list for the incognito mode. This CL does not change any behavior. Bug: 861722 Change-Id: I72c4cb075551b81c1ceeb04eaadbeff7f53447b5 Reviewed-on: https://chromium-review.googlesource.com/1176805 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#584150} [modify] https://crrev.com/c65c865826f0deaca9e578324ec2f1716fab6ac6/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e17a06d54159d3b0b76d268da4a093bf68d87941 commit e17a06d54159d3b0b76d268da4a093bf68d87941 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 20 05:21:56 2018 Remove Media Router preferences from incognito whitelist. Media Router preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ice965ba421945c6408b6c13b248acafe4181c76f Reviewed-on: https://chromium-review.googlesource.com/1179147 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#584365} [modify] https://crrev.com/e17a06d54159d3b0b76d268da4a093bf68d87941/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c02a310fabbc8f19ce9cc4cda0872231171ff1d commit 1c02a310fabbc8f19ce9cc4cda0872231171ff1d Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 20 05:29:00 2018 Remove Windows promotion preferences from incognito whitelist. Windows promotion preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I2c806b403ecbcf25ce0aab7984e6c313dbc81912 Reviewed-on: https://chromium-review.googlesource.com/1179146 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584367} [modify] https://crrev.com/1c02a310fabbc8f19ce9cc4cda0872231171ff1d/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7359fcd10fde3a0691880191b0369c0a4fefeed commit b7359fcd10fde3a0691880191b0369c0a4fefeed Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 20 05:31:54 2018 Remove unused Cross Device Promo preferences. kCrossDevicePromo* preferences are removed. Bug: 861722 Change-Id: Ica9b5aa7c0002479c57321aedde3e20ab33e25ca Reviewed-on: https://chromium-review.googlesource.com/1179148 Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584369} [modify] https://crrev.com/b7359fcd10fde3a0691880191b0369c0a4fefeed/chrome/browser/prefs/pref_service_incognito_whitelist.cc [modify] https://crrev.com/b7359fcd10fde3a0691880191b0369c0a4fefeed/chrome/common/pref_names.cc [modify] https://crrev.com/b7359fcd10fde3a0691880191b0369c0a4fefeed/chrome/common/pref_names.h
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf84369018c57871692865fcf71d0e070a74a471 commit bf84369018c57871692865fcf71d0e070a74a471 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 20 05:33:53 2018 Move Tab stats preferences to incognito whitelist. Tab stats metrics preferences are moved to the persistent storage list for incognito mode. This CL does not make any behavioral change. Bug: 861722 Change-Id: I052c8a62d4818a31451ff19baf815848bd3e3294 Reviewed-on: https://chromium-review.googlesource.com/1179145 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#584370} [modify] https://crrev.com/bf84369018c57871692865fcf71d0e070a74a471/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d076b1b7528bb943fef45305263cf91e4cff35cc commit d076b1b7528bb943fef45305263cf91e4cff35cc Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 20 08:16:45 2018 Remove Language preferences from incognito whitelist. Language preferences are removed from the persistent storage list for incognito mode. After this CL, if this preference is changed from incognito mode, it is only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ia013aaf468aa29b2efcfcb670003f09535e2a060 Reviewed-on: https://chromium-review.googlesource.com/1174118 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584379} [modify] https://crrev.com/d076b1b7528bb943fef45305263cf91e4cff35cc/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6119dffbe27ac5106e33798de4aad883839b09d6 commit 6119dffbe27ac5106e33798de4aad883839b09d6 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Aug 20 13:00:35 2018 Remove Profile preferences from incognito whitelist. Profile preferences are removed from the persistent storage list for incognito mode. Since these preferences are not written from incognito mode, this change should not have any behavioral effect. Bug: 861722 Change-Id: I430d9ee9db15576d31c822483a088306df4099aa Reviewed-on: https://chromium-review.googlesource.com/1180218 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584417} [modify] https://crrev.com/6119dffbe27ac5106e33798de4aad883839b09d6/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/921cd2402583fd816c4e53c94ba140c6a974b1b9 commit 921cd2402583fd816c4e53c94ba140c6a974b1b9 Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Aug 21 13:35:16 2018 Remove DOM distiller preferences from incognito whitelist. DOM distiller preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Icb08ad733b48a193c3ec52087d92decde6563191 Reviewed-on: https://chromium-review.googlesource.com/1179144 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584725} [modify] https://crrev.com/921cd2402583fd816c4e53c94ba140c6a974b1b9/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11be0e78ae9f7a44ca5c4f267f2ba19b26d3b4c0 commit 11be0e78ae9f7a44ca5c4f267f2ba19b26d3b4c0 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 22 16:18:54 2018 Remove First run, Enrollment and OOB prefs from incognito whitelist. First run, Enrollment, and OOB preferences are removed from the persistent storage list for incognito mode. Since these preferences are not written from incognito mode, this change should not have any behavioral effect. Bug: 861722 Change-Id: Iafe1ff19e7954ca2c420ee26708ba6f963a7fdb1 Reviewed-on: https://chromium-review.googlesource.com/1180217 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585031} [modify] https://crrev.com/11be0e78ae9f7a44ca5c4f267f2ba19b26d3b4c0/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/756ceea622528e07afd5ab69174d8131a7e34b7a commit 756ceea622528e07afd5ab69174d8131a7e34b7a Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 22 16:24:22 2018 Remove Braille IME preferences from incognito Whitelist. Braille IME preferences are not actual preferences and are never written/modified from an incognito window. So they are removed from incognito persistent whitelist. Bug: 861722 Change-Id: Id8ac77909c0927eebfdf6e0a2e9e5afce528c5d9 Reviewed-on: https://chromium-review.googlesource.com/1180891 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585040} [modify] https://crrev.com/756ceea622528e07afd5ab69174d8131a7e34b7a/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef86fbbab9370859ee262f74da85847edf814da9 commit ef86fbbab9370859ee262f74da85847edf814da9 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 22 17:08:44 2018 Remove Timezone preferences from incognito whitelist. Timezone preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ia6839002befb019f46617fc373c77b9600c069f1 Reviewed-on: https://chromium-review.googlesource.com/1180219 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585108} [modify] https://crrev.com/ef86fbbab9370859ee262f74da85847edf814da9/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b4ebe5d22832145ad79e8114d064daab8d84aa0 commit 5b4ebe5d22832145ad79e8114d064daab8d84aa0 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 22 17:15:39 2018 Remove Android Location preferences from incognito whitelist. Android Location and Search Geolocation preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ia23460d35650fd7631dfcad2b42b54fcd3305856 Reviewed-on: https://chromium-review.googlesource.com/1176809 Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585113} [modify] https://crrev.com/5b4ebe5d22832145ad79e8114d064daab8d84aa0/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d476e8deb077d5d441dd84658259cf7e213a43c commit 7d476e8deb077d5d441dd84658259cf7e213a43c Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 23 05:06:24 2018 Remove Printing preferences from incognito whitelist. Priniting preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I1e54ac665c125aa50ce5c7a3b277c559bdd78e1d Reviewed-on: https://chromium-review.googlesource.com/1179149 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585400} [modify] https://crrev.com/7d476e8deb077d5d441dd84658259cf7e213a43c/chrome/browser/chromeos/printing/synced_printers_manager.cc [modify] https://crrev.com/7d476e8deb077d5d441dd84658259cf7e213a43c/chrome/browser/prefs/pref_service_incognito_whitelist.cc [modify] https://crrev.com/7d476e8deb077d5d441dd84658259cf7e213a43c/chrome/common/pref_names.cc [modify] https://crrev.com/7d476e8deb077d5d441dd84658259cf7e213a43c/chrome/common/pref_names.h
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/584c5c4f8cf12e04ac66271f06db163447caf2ee commit 584c5c4f8cf12e04ac66271f06db163447caf2ee Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 23 13:21:19 2018 Move Reading List preference to incognito whitelist. Reading List preference is moved to the persistent storage list for incognito mode. This CL does NOT make any change of behavior. Bug: 861722 Change-Id: Ie29e7c86cedc19842f64939a1acf60e7835bffc1 Reviewed-on: https://chromium-review.googlesource.com/1172132 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585465} [modify] https://crrev.com/584c5c4f8cf12e04ac66271f06db163447caf2ee/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/892d386e43c1d3bea1bd7f39df5a86c96f9a6ff9 commit 892d386e43c1d3bea1bd7f39df5a86c96f9a6ff9 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 23 18:07:55 2018 Move DevTools preferences to incognito whitelist. DevTools preferences are moved to the persistent storage list for incognito mode. This part of the CL does not make any behavioral change. Android preference regarding DevTool enabling is removed from the incognito whitelist as it is not set from inside an incognito window. Bug: 861722 Change-Id: Iab189675cdef808f5d03398bb4e7eb6fd9378e97 Reviewed-on: https://chromium-review.googlesource.com/1180881 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585544} [modify] https://crrev.com/892d386e43c1d3bea1bd7f39df5a86c96f9a6ff9/chrome/browser/prefs/pref_service_incognito_whitelist.cc [modify] https://crrev.com/892d386e43c1d3bea1bd7f39df5a86c96f9a6ff9/chrome/browser/profiles/profile.cc [modify] https://crrev.com/892d386e43c1d3bea1bd7f39df5a86c96f9a6ff9/chrome/common/pref_names.cc [modify] https://crrev.com/892d386e43c1d3bea1bd7f39df5a86c96f9a6ff9/chrome/common/pref_names.h
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d56c64889ad71a7bf0211e59057b5a8ad12073d commit 7d56c64889ad71a7bf0211e59057b5a8ad12073d Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Aug 24 05:35:49 2018 Remove invalidation, search, and omnibox prefs from incognito whitelist. Invalidation, search engines, and omnibox preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I8c2fbfac8ff8e9002ab828c908e826419bff2abc Reviewed-on: https://chromium-review.googlesource.com/1185599 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Nicolas Zea <zea@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585703} [modify] https://crrev.com/7d56c64889ad71a7bf0211e59057b5a8ad12073d/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faf9f0d6b259170776da6c9b0ee7e5a575899205 commit faf9f0d6b259170776da6c9b0ee7e5a575899205 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Aug 24 11:35:26 2018 Remove Profile and policy controlled preferences from incognito whitelist. Several profile and policy controlled preferences are removed from the persistent storage list for incognito mode. As these preferences are not written from inside an incognito window, the CL is not expected to make any behavioral change and is just cleanup. Bug: 861722 Change-Id: I28ec6eb98241656fe81bbbf81fbad0bc73eddc53 Reviewed-on: https://chromium-review.googlesource.com/1188123 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585795} [modify] https://crrev.com/faf9f0d6b259170776da6c9b0ee7e5a575899205/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a349c4f41a0f522f1e653c34e2670422a847acdb commit a349c4f41a0f522f1e653c34e2670422a847acdb Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Aug 29 05:32:56 2018 Remove Android specific preferences from incognito whitelist. The following Android specific preferences are removed from the persistent storage list for incognito mode. - kClickedUpdateMenuItem, - kContextualSearchEnabled, - kLatestVersionWhenClickedUpdateMenuItem, - kNotificationsVibrateEnabled - kPromptForDownloadAndroid As these preferences are not written from inside an incognito window, the CL is not expected to make any behavioral change and is just cleanup. Bug: 861722 Change-Id: Idb73eb2fc1e7c7c49faf0c92b17aad3b22c4fa9e Reviewed-on: https://chromium-review.googlesource.com/1189922 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#587018} [modify] https://crrev.com/a349c4f41a0f522f1e653c34e2670422a847acdb/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bcf0c9482e8e3ae2f7bb8210be340a4640dbb99 commit 2bcf0c9482e8e3ae2f7bb8210be340a4640dbb99 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Aug 30 06:00:22 2018 Remove several preferences from incognito whitelist. The following preferences are removed from the persistent storage list for incognito mode. - kAllowJavascriptAppleEvents - kAlternateErrorPagesEnabled - kCrashReportingEnabled - kConfirmToQuitEnabled - kDataSaverEnabled - kDnsPrefetchingHostReferralList - kDnsPrefetchingStartupList - kMdHistoryMenuPromoShown - kNewTabPageLocationOverride - kNetworkPredictionOptions - kNetworkQualities - kRecurrentSSLInterstitial - kRlzPingDelaySeconds - kSessionExitedCleanly - kSessionExitType - kShowMissingSdCardErrorAndroid - kSpeechRecognitionFilterProfanities - kSSLErrorOverrideAllowed - kURLsToRestoreOnStartup These preferences are either never changed from incognito mode, or the changed value is not supposed to be written to user profile. Bug: 861722 Change-Id: Iaf271281d29964a763db0c78f2cc34407bf4b681 Reviewed-on: https://chromium-review.googlesource.com/1194007 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Bence Béky <bnc@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Reviewed-by: Carlos IL <carlosil@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#587453} [modify] https://crrev.com/2bcf0c9482e8e3ae2f7bb8210be340a4640dbb99/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef0e7aad7f3f3137c282db95bb9310c83bf6a9f3 commit ef0e7aad7f3f3137c282db95bb9310c83bf6a9f3 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Sep 03 13:39:12 2018 Bypass incognito profile when storing flags. On ChromeOS, user profile is used to store flags. If the current profile is incognito, this CL bypasses that to the original profile and stores directly to that. As users are notified that a relaunch is required to apply the flags, this does not change any behavior. Bug: 861722 Change-Id: I4248c98b459d7828a5ccd46ad90c18955ac8c342 Reviewed-on: https://chromium-review.googlesource.com/1198746 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#588384} [modify] https://crrev.com/ef0e7aad7f3f3137c282db95bb9310c83bf6a9f3/chrome/browser/ui/webui/flags_ui.cc
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2b7dd597aed864fc22fd2492041bfb859865448 commit a2b7dd597aed864fc22fd2492041bfb859865448 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Sep 10 06:43:51 2018 Remove several preferences from incognito whitelist. The following preferences are removed from the persistent storage list for incognito mode. - kAutoplayAllowed, - kAutoplayWhitelist, - kDeviceOpenNetworkConfiguration, - kDownloadDefaultDirectory, - kDownloadDirUpgraded, - kDownloadExtensionsToOpen, - kDSEGeolocationSettingDeprecated, - kDSEPermissionsSettings, - kDSEWasDisabledByPolicy - kEnabledLabsExperiments - kIncompatibleApplications, - kIsolateOrigins, - kLocalConsentsDictionary - kModuleBlacklistCacheMD5Digest, - kObservedSessionTime, - kOpenNetworkConfiguration, - kProblematicPrograms, - kSitePerProcess, - kThirdPartyBlockingEnabled, - kUnsafelyTreatInsecureOriginAsSecure - kWebDriverOverridesIncompatiblePolicies - kWebShareVisitedTargets These preferences are either never changed from incognito mode, or the changed value is not supposed to be written to user profile. Bug: 861722 Change-Id: I67fdb205175d9656ef07fd3039a2496e74968ceb Reviewed-on: https://chromium-review.googlesource.com/1196384 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589837} [modify] https://crrev.com/a2b7dd597aed864fc22fd2492041bfb859865448/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd792106ba11ecfe587e4126dd83af0e43444d21 commit cd792106ba11ecfe587e4126dd83af0e43444d21 Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Sep 11 06:42:46 2018 Remove ChromeOS specific preferences from incognito whitelist. ChromeOS specific preferences are removed from the persistent storage list for incognito mode. As these preferences are not written from inside an incognito window, the CL is not expected to make any behavioral change and is just cleanup. Bug: 861722 Change-Id: I9b5c18427cf9875b20d44dd99b65cab2900a5998 Reviewed-on: https://chromium-review.googlesource.com/1185598 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#590217} [modify] https://crrev.com/cd792106ba11ecfe587e4126dd83af0e43444d21/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb47c6ad07675bf55a123dde2eb0cf124a007315 commit fb47c6ad07675bf55a123dde2eb0cf124a007315 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Sep 12 07:23:25 2018 Remove several preferences from incognito whitelist (3). The following preferences are removed from the persistent storage list for incognito mode. - kAllowFileSelectionDialogs - kContentSettingsPluginWhitelist - kCurrentThemeColors - kCurrentThemeDisplayProperties - kCurrentThemeID - kCurrentThemeImages - kCurrentThemePackFilename - kCurrentThemeTints - kDisable3DAPIs - kEnableDeprecatedWebPlatformFeatures - kImportantSitesDialogHistory - kOptionsWindowLastTabIndex - kPartitionDefaultZoomLevel - kPartitionPerHostZoomLevelsa - kPinnedTabs - kPluginsAllowOutdated - kPluginsAlwaysOpenPdfExternally - kPluginsDisabledPlugins - kPluginsDisabledPluginsExceptions - kPluginsEnabledPlugins - kPluginsLastInternalDirectory - kPluginsMetadata - kPluginsPluginsList - kPluginsResourceCacheUpdate - kPluginsShowDetails - kRunAllFlashInAllowMode - kShowUpdatePromotionInfoBar - kSiteEngagementLastUpdateTime - kUsesSystemTheme These preferences are either never changed from incognito mode, or the changed value is not supposed to be written to user profile. The following preferences are moved to persistent storage list for incognito mode: - kBrowserSuppressDefaultBrowserPrompt - kDefaultBrowserLastDeclined - kDefaultBrowserSettingEnabled - kResetCheckDefaultBrowser - kUseCustomChromeFrame This CL does not make any behavior change for them. Bug: 861722 Change-Id: I0e1ed524e6ddbd22a66de582519cf2ac8390447f Reviewed-on: https://chromium-review.googlesource.com/1215702 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#590612} [modify] https://crrev.com/fb47c6ad07675bf55a123dde2eb0cf124a007315/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a009baf6c69809d73e0e76abce015829626c2f0 commit 0a009baf6c69809d73e0e76abce015829626c2f0 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Sep 12 09:55:44 2018 Remove several preferences from incognito whitelist (4). The following preferences are removed from the persistent storage list for incognito mode. - kAppWindowPlacement - kExcludedSchemes - kEulaAccepted - kGCMProductCategoryForSubtypesa - kHasSeenWelcomePage - kInvertNotificationShown - kLocalDiscoveryNotificationsEnabled - kMessageCenterDisabledExtensionIds - kMessageCenterDisabledSystemComponentIds - kSelectFileLastDirectory - kStabilityOtherUserCrashCount - kStabilityKernelCrashCount - kStabilitySystemUncleanShutdownCount - kStabilityPluginStats - kStabilityPluginName - kStabilityPluginLaunches - kStabilityPluginInstances - kStabilityPluginCrashes - kStabilityPluginLoadingErrors - kTaskManagerColumnVisibility - kTaskManagerEndProcessEnabled - kTaskManagerWindowPlacement These preferences are either never changed from incognito mode, or the changed value is not supposed to be written to user profile. Bug: 861722 Change-Id: I8e002eca894871581a065b802736e980b65f55bb Reviewed-on: https://chromium-review.googlesource.com/1215703 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Nicolas Zea <zea@chromium.org> Reviewed-by: Jun Mukai <mukai@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#590631} [modify] https://crrev.com/0a009baf6c69809d73e0e76abce015829626c2f0/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a024c4a196815a3d2ec27240e4a5c2335f8ff34a commit a024c4a196815a3d2ec27240e4a5c2335f8ff34a Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Sep 13 08:44:23 2018 Remove Policy controlled preferences from incognito whitelist. The following policy controlled preferences are removed from incognito persistent white list: - kAllowCrossOriginAuthPrompt - kAllowDinosaurEasterEgg - kAudioCaptureAllowed - kAudioCaptureAllowedUrls - kAuthAndroidNegotiateAccountType - kAuthNegotiateDelegateWhitelist - kAuthSchemes - kAuthServerWhitelist - kBrowserAddPersonEnabled - kBrowserGuestModeEnabled - kBuiltInDnsClientEnabled - kComponentUpdatesEnabled - kDisableAuthNegotiateCnameLookup - kDiskCacheDir - kDiskCacheSize - kEnableAuthNegotiatePort - kGSSAPILibraryName - kHardwareAccelerationModeEnabled - kMaxConnectionsPerProxy - kMediaCacheSize - kNtlmV2Enabled - kPacHttpsUrlStrippingEnabled - kPromotionalTabsEnabled - kRelaunchNotification - kRelaunchNotificationPeriod - kSecurityKeyPermitAttestation - kSSLVersionMax - kSSLVersionMin - kSuppressUnsupportedOSWarning - kVideoCaptureAllowed - kVideoCaptureAllowedUrls - kWebAppInstallForceList - kWebRTCUDPPortRange - kWelcomePageOnOSUpgradeEnabled This CL does not make any behavior change is just clean up. Bug: 861722 Change-Id: I9d9834ccdbc5923041b5dfcfd54d893f89baba59 Reviewed-on: https://chromium-review.googlesource.com/1223811 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#590952} [modify] https://crrev.com/a024c4a196815a3d2ec27240e4a5c2335f8ff34a/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00f065631a47df4cbcf085924f069db9403fbf71 commit 00f065631a47df4cbcf085924f069db9403fbf71 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Sep 14 18:33:15 2018 Remove kEnableReferrers preference from incognito whitelist. kEnableReferrers is removed from incognito persistent preferences list as it is not exposed to UI and cannot be changed from incognito mode. The tests checking its former behavior are also updated. Bug: 861722 Change-Id: I357e81482efa41c6436b7ed79c0b84e4e55cfc0b Reviewed-on: https://chromium-review.googlesource.com/1219609 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#591408} [modify] https://crrev.com/00f065631a47df4cbcf085924f069db9403fbf71/chrome/browser/net/network_context_configuration_browsertest.cc [modify] https://crrev.com/00f065631a47df4cbcf085924f069db9403fbf71/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1a736703dfe03ce98fb5d2dac722c1b85c48102 commit c1a736703dfe03ce98fb5d2dac722c1b85c48102 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Sep 17 06:03:59 2018 Remove several preferences from incognito whitelist (6). The following preferences are removed from the persistent storage list for incognito mode: - kCustomHandlersEnabled - kIgnoredProtocolHandlers - kRegisteredProtocolHandlers - kAppShortcutsVersion - kNotifyWhenAppsKeepChromeAlive These preferences are either local state, or never changed from incognito mode, and hence the CL is not supposed to make any behavior change. Bug: 861722 Change-Id: I059bd13850479e3357873e685b338a36b52eb356 Reviewed-on: https://chromium-review.googlesource.com/1226979 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#591615} [modify] https://crrev.com/c1a736703dfe03ce98fb5d2dac722c1b85c48102/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1730bc1d89ce2af7fbf16d3119b649e4d969a720 commit 1730bc1d89ce2af7fbf16d3119b649e4d969a720 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Sep 17 07:55:49 2018 Remove several preferences from incognito whitelist (5). The following preferences are removed from the persistent storage list for incognito mode: - kBackgroundModeEnabled - kChromeCreatedLoginItem - kMigratedLoginItemPref - kRegisteredBackgroundContents - kUserRemovedLoginItem These preferences are either local state, or never changed from incognito mode, and hence the CL is not supposed to make any behavior change. Bug: 861722 Change-Id: I111b6a932a11732db863e273adc22379122bea15 Reviewed-on: https://chromium-review.googlesource.com/1226601 Reviewed-by: Drew Wilson <atwilson@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#591619} [modify] https://crrev.com/1730bc1d89ce2af7fbf16d3119b649e4d969a720/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9057c113a353212edac8dff2260fbb7887c7c000 commit 9057c113a353212edac8dff2260fbb7887c7c000 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Sep 17 09:34:16 2018 Remove unused preferences. The following unused preferences are removed. - kGeolocationAccessToken - kGoogleServicesPasswordHash - kLastWelcomedOSVersion - kModuleConflictBubbleShown - kOptionsWindowLastTabIndex - kTrustedDownloadSources This CL should not result in any behavior change and is just clean up. Bug: 861722 Change-Id: I05cff5e38296424aeedb03c55df70d838ecd5341 Reviewed-on: https://chromium-review.googlesource.com/1224052 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#591625} [modify] https://crrev.com/9057c113a353212edac8dff2260fbb7887c7c000/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/9057c113a353212edac8dff2260fbb7887c7c000/chrome/browser/prefs/pref_service_incognito_whitelist.cc [modify] https://crrev.com/9057c113a353212edac8dff2260fbb7887c7c000/chrome/browser/signin/local_auth.cc [modify] https://crrev.com/9057c113a353212edac8dff2260fbb7887c7c000/chrome/browser/signin/local_auth.h [modify] https://crrev.com/9057c113a353212edac8dff2260fbb7887c7c000/chrome/browser/signin/signin_manager_factory.cc [modify] https://crrev.com/9057c113a353212edac8dff2260fbb7887c7c000/chrome/browser/ui/browser_ui_prefs.cc [modify] https://crrev.com/9057c113a353212edac8dff2260fbb7887c7c000/chrome/browser/ui/startup/startup_browser_creator.cc [modify] https://crrev.com/9057c113a353212edac8dff2260fbb7887c7c000/chrome/common/pref_names.cc [modify] https://crrev.com/9057c113a353212edac8dff2260fbb7887c7c000/chrome/common/pref_names.h
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c69dd68294dd806df883745ad7c81911cb00e621 commit c69dd68294dd806df883745ad7c81911cb00e621 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Sep 17 11:08:48 2018 Remove several local states from incognito whitelist (8). The following local states are removed from the persistent storage list for incognito mode: - kAttemptedToEnableAutoupdate - kDebuggingFeaturesRequested - kDnsOverHttpsServerMethods - kDnsOverHttpsServers - kFactoryResetRequested - kFactoryResetTPMFirmwareUpdateMode - kHardwareAccelerationModePrevious - kHasSeenWin10PromoPage - kLastKnownIntranetRedirectOrigin - kMigratedToSiteNotificationChannels - kOriginTrialDisabledFeatures - kOriginTrialDisabledTokens - kOriginTrialPublicKey - kQuickCheckEnabled - kRecoveryComponentNeedsElevation - kRestartLastSessionOnShutdown - kShutdownNumProcesses - kShutdownNumProcessesSlow - kShutdownType - kTabStripStackedLayout - kWasRestarted As storage of local states does not go through incognito preference store, this CL does not change any behavior and is just for clean up. Bug: 861722 Change-Id: I9af4431c2dca0d8143f4ee76f528daabbdeb58c5 Reviewed-on: https://chromium-review.googlesource.com/1226144 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#591637} [modify] https://crrev.com/c69dd68294dd806df883745ad7c81911cb00e621/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea0af06e9cc060c3ece51cadbd4104217c5b1f18 commit ea0af06e9cc060c3ece51cadbd4104217c5b1f18 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Sep 17 15:05:53 2018 Remove several preferences from incognito whitelist (7). The following preferences are removed from the persistent storage list for incognito mode: - kCertEnableSha1LocalAnchors - kCertEnableSymantecLegacyInfrastructure - kCertRevocationCheckingEnabled - kCertRevocationCheckingRequiredLocalAnchors - kCipherSuiteBlacklist - kTLS13Variant These preferences are either local state, or never changed from incognito mode, and hence the CL is not supposed to make any behavior change. Bug: 861722 Change-Id: Ia5e5ec999d88c67aaa080d6f7c2f4bc4e1f11758 Reviewed-on: https://chromium-review.googlesource.com/1225985 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#591675} [modify] https://crrev.com/ea0af06e9cc060c3ece51cadbd4104217c5b1f18/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/863fb9e774b6bf5b04db1bc88d5a0db2cab01113 commit 863fb9e774b6bf5b04db1bc88d5a0db2cab01113 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Sep 20 07:54:48 2018 Remove several preferences from incognito whitelist (9). The following preferences are removed from the persistent storage list for incognito mode: - kClearedBlockedSiteNotificationChannels - kDRMSalt - kEnableDoNotTrack - kEnableDRM - kEnableHyperlinkAuditing - kEnableEncryptedMedia - kMediaStorageIdSalt - kPushMessagingAppIdentifierMap These preferences are either never changed from incognito mode, or if changed, they do not need to be written to user profile. Bug: 861722 Change-Id: I52437e7ef3a141babb1a797092d3ae316a059761 Reviewed-on: https://chromium-review.googlesource.com/1233354 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#592715} [modify] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56698e7925ec6bf41be913cafccb7f2823412032 commit 56698e7925ec6bf41be913cafccb7f2823412032 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Sep 21 07:37:43 2018 Remove network profile warning time from incognito persistent list. kNetworkProfileLastWarningTime is removed from incognito persistent list to avoid leaking the last time the warning is shown in incognito mode to user profile. kNetworkProfileWarningsLeft is moved from temporary to actual incognito persistent list (no behavior change) to avoid annoying users who extensively use incognito mode. Bug: 861722 Change-Id: I554fc66e762579b657a4ada24a0a7243f596f670 Reviewed-on: https://chromium-review.googlesource.com/1238153 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#593102} [modify] https://crrev.com/56698e7925ec6bf41be913cafccb7f2823412032/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2428c915bd7338c34606695d9f03ea9af909cfaf commit 2428c915bd7338c34606695d9f03ea9af909cfaf Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Sep 24 07:02:15 2018 Remove kMediaEngagementSchemaVersion from incognito persistent list. kMediaEngagementSchemaVersion is removed from the list of preferences that are persieted if modified in incognito mode. Bug: 861722 Change-Id: Idb74a3d2013d74c5c7158a10aca1fb88b926c6db Reviewed-on: https://chromium-review.googlesource.com/1237974 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#593481} [modify] https://crrev.com/2428c915bd7338c34606695d9f03ea9af909cfaf/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cb1137fa4161606be938c46b0e95809c0fe6203 commit 3cb1137fa4161606be938c46b0e95809c0fe6203 Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Sep 25 06:08:09 2018 Remove several preferences from incognito whitelist (10): The following preferences are removed from the persistent storage list for incognito mode: - kAppListLocalState - kHasSeenGoogleAppsPromoPage - kOpenPdfDownloadInSystemReader - kWatchdogExtensionActive - kWebAppCreateInAppsMenu - kWebAppCreateInQuickLaunchBar - kWebAppCreateOnDesktop These preferences are either never changed from incognito mode, or if changed, they do not need to be written to user profile. Bug: 861722 Change-Id: Ie42d077effeb90cab6b0062991eaf04613faf619 TBR: khmel@chromium.org TBR: palmer@chromium.org TBR: rdevlin.cronin@chromium.org TBR: tmartino@chromium.org TBR: xiyuan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1242456 Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#593833} [modify] https://crrev.com/3cb1137fa4161606be938c46b0e95809c0fe6203/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28b3e4f557cc71fd8bc9c15af10a51d27c162c40 commit 28b3e4f557cc71fd8bc9c15af10a51d27c162c40 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Sep 28 08:22:53 2018 Remove several preferences from incognito whitelist (11). The following preferences are removed from the persistent storage list for incognito mode: - kBackgroundTracingLastUpload - kDefaultAudioCaptureDevice - kDefaultTasksByMimeType - kDefaultTasksBySuffix - kDefaultVideoCaptureDevice - kMediaGalleriesRememberedGalleries - kMediaGalleriesUniqueId - kPartnerBookmarkMappings - kPepperFlashSettingsEnabled - kPerformanceTracingEnabled - kWebRTCIPHandlingPolicy - kWebRTCMultipleRoutesEnabled - kWebRTCNonProxiedUdpEnabled These preferences are either never changed from incognito mode, or if changed, they do not need to be written to user profile. Bug: 861722 Change-Id: I03fb38784b57460b4d2e74c1abfdb01e83ddbda2 TBR: guidou@chromium.org TBR: oysteine@chromium.org TBR: satorux@chromium.org TBR: tommycli@chromium.org TBR: wychen@chromium.org TBR: zork@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1250521 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#595018} [modify] https://crrev.com/28b3e4f557cc71fd8bc9c15af10a51d27c162c40/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87ed0acba034b70a4760c60eeef4fc5642547899 commit 87ed0acba034b70a4760c60eeef4fc5642547899 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Sep 28 10:41:23 2018 Add Partner Bookmark Mappings to Incognito persistent whitelist. As bookmarks are shared between incognito and regular mode, partner bookmark mapping is added to incognito persistent list. Bug: 861722 Change-Id: I98a10094b2734c32316a6aea0e477391305b19f2 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1251101 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#595044} [modify] https://crrev.com/87ed0acba034b70a4760c60eeef4fc5642547899/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b0d7de6898470fc25696a1b60ba9e8b533be2c2 commit 9b0d7de6898470fc25696a1b60ba9e8b533be2c2 Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Oct 02 07:56:25 2018 Remove kMediaDeviceIdSalt from incognito whitelist. kMediaDeviceIdSalt is removed from incognito persistent preferences list. After this CL, the changes to this preference in incognito mode are not written to user profile. Bug: 861722 Change-Id: If9328b582523573fb0f9cbcc7dbe89ff8b36c8b4 TBR: perkj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1255525 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#595753} [modify] https://crrev.com/9b0d7de6898470fc25696a1b60ba9e8b533be2c2/chrome/browser/prefs/pref_service_incognito_whitelist.cc
,
Oct 2
crbug.com/891192 created to follow up the effort on iOS specific code.
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21962d78343c495b3ff1dc6f82969081328f7ad7 commit 21962d78343c495b3ff1dc6f82969081328f7ad7 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Oct 04 06:16:44 2018 Remove incognito temporary whitelist. Incognito temporary whitelist and the last item in it are removed. All items in the list were audited and removed before and the list is no more in use. Bug: 861722 Change-Id: I2922c3010efe3685beff59271294669affa93af5 Reviewed-on: https://chromium-review.googlesource.com/c/1256684 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#596522} [modify] https://crrev.com/21962d78343c495b3ff1dc6f82969081328f7ad7/chrome/browser/prefs/pref_service_incognito_whitelist.cc [modify] https://crrev.com/21962d78343c495b3ff1dc6f82969081328f7ad7/chrome/browser/prefs/pref_service_syncable_util.cc
,
Oct 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 17