New issue
Advanced search Search tips

Issue 861717 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jul 12
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Win] Fix line endings when writing bookmark URLs to clipboard.

Project Member Reported by osc...@opera.com, Jul 9 
When copying bookmark URLs to clipboard on Windows, the line ending is "\n" when it should be "\r\n" to format it correctly.

Patch incomming.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfbed7c068cc6333c7c4f455455891faae524da3

commit dfbed7c068cc6333c7c4f455455891faae524da3
Author: Oscar Johansson <oscarj@opera.com>
Date: Tue Jul 10 08:05:55 2018

Fix line endings when writing bookmark URLs to clipboard.

Add "\r\n" instead of "\n" when copying multiple bookmark
URLs on Windows.

Bug:  861717 
Change-Id: I0d15a8662bbb27ee67b899ea805ddd5b147be71f
Reviewed-on: https://chromium-review.googlesource.com/1128879
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#573646}
[modify] https://crrev.com/dfbed7c068cc6333c7c4f455455891faae524da3/components/bookmarks/browser/bookmark_node_data.cc
[modify] https://crrev.com/dfbed7c068cc6333c7c4f455455891faae524da3/components/bookmarks/browser/bookmark_node_data_unittest.cc

Comment 2 by dtapu...@chromium.org, Jul 12

Status: Fixed (was: Untriaged)
►

Sign in to add a comment