New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 861709 link

Starred by 1 user
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Jul 18
Cc:
yamaguchi@chromium.org
█ yoshiki@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression:Unnecessary ripple effect is seen on clicking Ethernet icon at ubertray

Project Member Reported by rkalavakuntla@chromium.org, Jul 9 
Chrome Version:69.0.3480.0/10859.0.0 dev channel Daisy,Candy,Peppy
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover build >> Connect to Ethernet >> Sign into user 
(2)Go to ubertray >>click on the Ethernet icon and observe

Expected: On clicking Ethernet icon at ubertray no ripple effect should be seen since it cannot be disconnected.
Actual: Unnecessary ripple effect is seen on clicking Ethernet icon at ubertray - which cannot be disconnected

This is a Non-Regression issue seen from M-69

Attached the screencast for reference..
Actual.mp4
6.0 MB View Download

Comment 1 by tetsui@chromium.org, Jul 11

Cc: -ajha@chromium.org -tetsui@chromium.org yamaguchi@chromium.org yoshiki@chromium.org
Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by tetsui@chromium.org, Jul 17

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe7b0602d87ac8abdc06590e02300218197cd916

commit fe7b0602d87ac8abdc06590e02300218197cd916
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Jul 18 06:23:25 2018

Unified: Fix DND and network button behavior.

This CL fixes two issues:
* Fix do-not-disturb button to turn on DND automatically on the label
  click.
* Fix network button to ignore the icon click when Ethernet is
  connected.

TEST=manual
BUG= 859831 , 861709 

Change-Id: I064db9687084ac21aa9a059b7cd90f740e734d4d
Reviewed-on: https://chromium-review.googlesource.com/1139849
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575957}
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/network/network_feature_pod_controller.cc
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/unified/quiet_mode_feature_pod_controller.cc
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/unified/unified_system_tray_controller.cc
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/unified/unified_system_tray_controller.h
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/unified/unified_system_tray_test_api.cc

Comment 4 by tetsui@chromium.org, Jul 18

Status: Fixed (was: Started)
►

Sign in to add a comment