New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 861700 link

Starred by 1 user
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Jul 13
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Pause button is seen inverted in RTL on www.mounirlamouri.github.io

Reported by shruti.j...@etouch.net, Jul 9 
Chrome version : 69.0.3486.0 (Official Build) 472d1caeb99d99a8952e7170bbf435bd92902d73-refs/branch-heads/3486@{#1}(32/64-bit) 

OS: Windows(7,8,8.1,10) and Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)

Test URL:https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html
Pre-condition:Enable 'Force UI Direction'

Steps to reproduce:
1.Launch chrome  and navigate to above URL.
2.Click on three dots and select'Picture in Picture' option.
3.Pause the 'Picture in Picture' and observe the pause button.

Actual:Pause button is seen inverted in RTL.
Expected:Pause button should be seen properly even in RTL.

This is non-regression issue seen from ‘M-69’ seen from #69.0.3484.0.

Kindly refer the attached screen-cast.
Actual_Result.mp4
588 KB View Download

Comment 1 by rbasuvula@chromium.org, Jul 9

Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!

Comment 2 by iclell...@chromium.org, Jul 9

Components: -Blink>HTML Blink>Media>PictureInPicture
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7d7210e6aeb7a736d09bfc97bcbc5c5372b590f

commit f7d7210e6aeb7a736d09bfc97bcbc5c5372b590f
Author: Jennifer Apacible <apacible@chromium.org>
Date: Tue Jul 10 17:58:05 2018

[Vector Icons] Do not flip play icon in RTL cases.

In RTL cases, the play icon is flipped so the arrow points to the left.
This changes makes the arrow point to the right in all cases, including
when in RTL.

Bug:  861700 
Change-Id: Icf03cca5bc48690058cc9709c5dc083382cab51a
Reviewed-on: https://chromium-review.googlesource.com/1130852
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573804}
[modify] https://crrev.com/f7d7210e6aeb7a736d09bfc97bcbc5c5372b590f/chrome/app/vector_icons/play_arrow.icon

Comment 4 by shruti.j...@etouch.net, Jul 11

Labels: TE-Verified-69.0.3487.0 TE-Verified-M69
Update : 
Retested above issue on Windows (7,8,8.1,10)OS using latest Canary #69.0.3487.0 and issue is fixed. Pause button is not inverted when RTL is applied.Kindly review the attached screen-cast.
Thank you!
Canary_Behaviour#69.0.3487.0.mp4
424 KB View Download

Comment 5 by shruti.j...@etouch.net, Jul 11

Labels: -TE-Verified-69.0.3487.0 TE-Verified-69.0.3488.0
Update : 

Kindly ignore the above comment.

Retested above issue on Windows (7,8,8.1,10) and Mac(10.12.6, 10.13.1, 10.13.6, 10.14)OS using latest Canary build #69.0.3488.0 and issue is fixed. Pause button is not inverted when RTL is applied.
Kindly review the attached screen-cast.

Thank you!
Canary_Behaviour#69.0.3488.0.mp4
424 KB View Download

Comment 6 by apaci...@chromium.org, Jul 13

Owner: apaci...@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment