New issue
Advanced search Search tips

Issue 861696 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Aug 16
Cc:
ajha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: SAVE button is seen enabled when the Name, Address fields are left blank in Edit printer overlay

Project Member Reported by rkalavakuntla@chromium.org, Jul 9 
Chrome Version:69.0.3480.0/10859.0.0 dev channel Daisy,Candy,Peppy
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user >> Open chrome://settings/cupsPrinters page >> Add a sample Printer
(2)In Edit printer >> Remove the Name,Address and observe SAVE button is seen enabled

Actual: SAVE button is seen enabled even after deleting the Name,Address of a printer in Edit printer overlay
Expected: SAVE button should be seen disable or an error message should be seen when the Name, Address fields are left blank while editing

This is a Non-Regression issue seen from M-62

Attached the screencast for reference..

@xdai : Please confirm the issue
actual.mp4
15.0 MB Download

Comment 1 by x...@chromium.org, Aug 8

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6acdeb7fc4996e45c4d0372c10194954cde19d31

commit 6acdeb7fc4996e45c4d0372c10194954cde19d31
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Thu Aug 16 18:30:06 2018

CUPS: only allow save printer when the provided info is valid.

After adding a printer, it's possible for the user to edit the added
printer's info. Only allow saving the edited info if the provided info
is valid.

Bug:  861696 
Change-Id: Id42ec655e3b50ba13a424489b9d57d77e0be4228
Reviewed-on: https://chromium-review.googlesource.com/1168031
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583748}
[modify] https://crrev.com/6acdeb7fc4996e45c4d0372c10194954cde19d31/chrome/browser/resources/settings/printing_page/BUILD.gn
[modify] https://crrev.com/6acdeb7fc4996e45c4d0372c10194954cde19d31/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/6acdeb7fc4996e45c4d0372c10194954cde19d31/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[add] https://crrev.com/6acdeb7fc4996e45c4d0372c10194954cde19d31/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[add] https://crrev.com/6acdeb7fc4996e45c4d0372c10194954cde19d31/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js
[modify] https://crrev.com/6acdeb7fc4996e45c4d0372c10194954cde19d31/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
[modify] https://crrev.com/6acdeb7fc4996e45c4d0372c10194954cde19d31/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[modify] https://crrev.com/6acdeb7fc4996e45c4d0372c10194954cde19d31/chrome/browser/resources/settings/settings_resources.grd

Comment 3 by x...@chromium.org, Aug 16

Status: Fixed (was: Started)
►

Sign in to add a comment