Regression : Space is not seen between spinner and cancel button on 'Failed to load extension' overlay.
Reported by
pranjali...@etouch.net,
Jul 9
|
|||||||||
Issue descriptionChrome version : 69.0.3486.0 (Official Build) 472d1caeb99d99a8952e7170bbf435bd92902d73-refs/branch-heads/3486@{#1}(32/64-bit) OS :Win(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS Steps to reproduce: 1. Launch chrome ,navigate to 'chrome://extensions/' and click on 'developer mode'. 2. Click 'Load unpacked' button and add random folder (such that 'failed to load extension' error overlay appears). 3. Now click on 'retry' button continuously(such that spinner should be seen). 4. Observe. Actual Result: Space is not seen between spinner and cancel button on 'Failed to load extension' overlay. Expected Result: Proper space should be seen between Spinner and cancel button 'Failed to load extension' overlay This is a regression issue broken in ‘M-68’ and will below is bisect info. Good build: 68.0.3406.0 Bad build: 68.0.3409.0 You are probably looking for a change made after 553381 (known good), but no later than 553383 (first known bad) CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/cf71828f1a3b7d1236d3d3c24982df9d830e829d..80bff43a869b6f482b3fd0f8396134e1253b5073 Suspect: https://chromium.googlesource.com/chromium/src/+/bf799ef89ce47640211ce7e949e196762a104130 @dpapad: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Jul 12
,
Jul 12
,
Jul 12
,
Jul 12
,
Jul 12
,
Jul 12
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e8285afd40747dbd2eeb7f4f4be3036999098db commit 3e8285afd40747dbd2eeb7f4f4be3036999098db Author: Scott Chen <scottchen@chromium.org> Date: Fri Jul 13 03:56:40 2018 Extensions: spinner and button are too close. Bug: 861685 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib84715313698d8ded12cc7ecedfae719e15e917e Reviewed-on: https://chromium-review.googlesource.com/1135758 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574831} [modify] https://crrev.com/3e8285afd40747dbd2eeb7f4f4be3036999098db/chrome/browser/resources/md_extensions/load_error.html
,
Jul 14
,
Jul 16
Update: Rechecked the above issue on Win(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS using latest canary build #69.0.3493.0 and issue is fixed. Please refer attached screencast for reference. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dpa...@chromium.org
, Jul 9