Get binutils >= 2.30 |
||
Issue descriptionThere is a fix[1] in binutils 2.30 that we want for Chromium. Version 2.29 and earlier has a performance problem with objcopy (and possibly other tools) where they are O(n^2) in number of sections in the object file. Since Chromium is compiled with -ffunction-section there can be many hundreds or thousands of sections per cc file instead of just one. In some jumbo builds, those hundreds or hundreds can become tens of thousands and then an objcopy that should have been more or less instant can take more than 5 minutes. None of the official configurations experience the most extreme slowdown which is why it's not been urgent but at some time it should be switched to (it was released at the beginning of the year). Unless the project has moved to llvm objcopy but if that is happening I have not noticed. [1]: https://sourceware.org/ml/binutils/2018-01/msg00197.html
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee84db22e78330dde850130dcd52b26ee55e5a7d commit ee84db22e78330dde850130dcd52b26ee55e5a7d Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Jul 10 18:15:35 2018 Update bundled binutils to 2.30 BUG= 861672 R=thestig Change-Id: Icda4ecb0792ab50f51cd82d3899b64e656ab975d Reviewed-on: https://chromium-review.googlesource.com/1129369 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#573812} [modify] https://crrev.com/ee84db22e78330dde850130dcd52b26ee55e5a7d/third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 [modify] https://crrev.com/ee84db22e78330dde850130dcd52b26ee55e5a7d/third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 [modify] https://crrev.com/ee84db22e78330dde850130dcd52b26ee55e5a7d/third_party/binutils/README.chromium [modify] https://crrev.com/ee84db22e78330dde850130dcd52b26ee55e5a7d/third_party/binutils/build-all.sh
,
Jul 10
,
Jul 11
Thank you! That was quick! |
||
►
Sign in to add a comment |
||
Comment 1 by thomasanderson@chromium.org
, Jul 9