New issue
Advanced search Search tips

Issue 861664 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: last_text_node_ != node_ (#text "baz" vs. #text "baz")We should never call Handl

Project Member Reported by ClusterFuzz, Jul 9

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6431699043614720

Fuzzer: attekett_surku_fuzzer
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  last_text_node_ != node_ (#text "baz" vs. #text "baz")We should never call Handl
  blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >::Ha
  blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >::Ad
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=571364:571366

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6431699043614720

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 9

Components: Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 9

Labels: Test-Predator-Auto-Owner
Owner: xiaoche...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/b33a9282728898428632c036f2c09e258bfcd888 ([Spellchecker] Stop cold mode spellchecker from checking beyond editable element).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Jul 9

ClusterFuzz has detected this issue as fixed in range 573238:573240.

Detailed report: https://clusterfuzz.com/testcase?key=6431699043614720

Fuzzer: attekett_surku_fuzzer
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  last_text_node_ != node_ (#text "baz" vs. #text "baz")We should never call Handl
  blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >::Ha
  blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >::Ad
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=571364:571366
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=573238:573240

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6431699043614720

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Jul 9

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6431699043614720 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: ClusterFuzz-Wrong
Status: Assigned (was: Verified)
Still reproducing.
Components: -Internals>Core Blink>Editing>Spellcheck
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e8395a6ef581ea65088af7a18dc74e2dad9d5c3

commit 8e8395a6ef581ea65088af7a18dc74e2dad9d5c3
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Jul 10 21:11:34 2018

[Spellchecker] Do not call CalculateCharacterSubrange with overshot length

Cold mode spellchecker used to call CalculateCharacterSubrange()
unconditionally with the max chunk length to get the checking chunk. This
introduces crashes when the passed length is longer than the text length.

This patch obtains the text length to avoid passing out-of-range lengths
to CalculateCharacterSubrange, and fixes a crash.

Bug:  861664 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iacccedd7e7beb5a41a8fd5411257a1c6106dacf7
Reviewed-on: https://chromium-review.googlesource.com/1130935
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573905}
[add] https://crrev.com/8e8395a6ef581ea65088af7a18dc74e2dad9d5c3/third_party/WebKit/LayoutTests/editing/spelling/cold_mode_nested_div.html
[modify] https://crrev.com/8e8395a6ef581ea65088af7a18dc74e2dad9d5c3/third_party/blink/renderer/core/editing/iterators/character_iterator.cc
[modify] https://crrev.com/8e8395a6ef581ea65088af7a18dc74e2dad9d5c3/third_party/blink/renderer/core/editing/spellcheck/cold_mode_spell_check_requester.cc

Status: Fixed (was: Assigned)

Sign in to add a comment