New issue
Advanced search Search tips

Issue 861649 link

Starred by 1 user
Status: Fixed
Owner:
tangltom@chromium.org
Closed: Aug 24
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Space is not seen between 'Save' button and the row separator line on 'Sync' sub page.

Reported by avsha...@etouch.net, Jul 9 
Chrome Version : 69.0.3486.0 (Official Build) 472d1caeb99d99a8952e7170bbf435bd92902d73-refs/branch-heads/3486@{#1} 32/64 bit
OS : Windows(7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.14, 10.13.6)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings page and sign in to chrome with valid credentials
2. Go to 'Sync' sub page, scroll down the page and select "Encrypt synced data.." radio button in "Encryption options" section.
3. Observe the 'Save' button and row separator line at bottom.

Actual Result : Space is not seen between 'Save' button and row separator line.

Expected Result : 'Save' button and row separator line should have proper space in between.

This is a regression issue broken in ‘M-69’ and will soon update the bisect info.
Good Build : 69.0.3481.0 (Revision : 572438)
Bad Build : 69.0.3482.0 (Revision : 572690)
Expected_Result.mp4
422 KB View Download
Spacing_Result.png
40.6 KB View Download

Comment 1 by avsha...@etouch.net, Jul 9

Labels: hasbisect-per-revision RegressedIn-69 Target-69 FoundIn-69
Owner: tangltom@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue broken in ‘M-69’ and below is the bisect info :
Good Build : 69.0.3481.0 (Revision : 572438)
Bad Build : 69.0.3482.0 (Revision : 572690)

You are probably looking for a change made after 572663 (known good), but no later than 572664 (first known bad).

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/21d34562409c4cf7b232aa4921118117d4e9eab9..50c5e05de3d9e28eafc11d15c9b7584bdb8ef506

Suspect : https://chromium.googlesource.com/chromium/src/+/50c5e05de3d9e28eafc11d15c9b7584bdb8ef506

Thomas@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You..!

Comment 2 by tangltom@chromium.org, Jul 30 

This wasn't my CL. But probably someone from my team. I will look into it and try to merge it back!

Comment 3 by tangltom@chromium.org, Aug 23

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb2da37d1553a39e94cea0b84a289460e698c3bd

commit eb2da37d1553a39e94cea0b84a289460e698c3bd
Author: Thomas Tangl <tangltom@chromium.org>
Date: Fri Aug 24 10:03:17 2018

[unified-consent] Fix bottom spacing of passphrase Save button

Screenshot before:
https://drive.google.com/file/d/1docQTG83IMfNalyaJn8VOZ_bWIbMFq0J/view?usp=sharing
Screenshot after:
https://drive.google.com/file/d/1u6gCMPVEqsLy9fkuxhqGlrqpBYQzSmj_/view?usp=sharing

Bug:  861649 
Change-Id: Iecef069e5fe5007711c0b8b7191e9c3534c367f6
Reviewed-on: https://chromium-review.googlesource.com/1186723
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585780}
[modify] https://crrev.com/eb2da37d1553a39e94cea0b84a289460e698c3bd/chrome/browser/resources/settings/people_page/sync_page.html

Comment 5 by tangltom@chromium.org, Aug 24

Status: Fixed (was: Started)

Comment 6 by avsha...@etouch.net, Aug 27

Labels: TE-Verified-M70 TE-Verified-70.0.3534.0
Update :
---------
Tested above issue in latest Canary build #70.0.3534.0 on Windows(7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) OS and the issue is fixed. 
Now, proper space is available below the 'Save' button, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
Latest_Canary_Behavior.mp4
362 KB View Download
►

Sign in to add a comment