New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 861645 link

Starred by 1 user
Status: Verified
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Jul 11
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

autotest-tests-security: Failed to build with glibc 2.27

Project Member Reported by yunlian@chromium.org, Jul 9 
With glibc 2.27, I got
ERROR:root:[stderr] In file included from seccomp_bpf_tests.c:24:
ERROR:root:[stderr] In file included from /build/samus/usr/include/signal.h:57:
ERROR:root:[stderr] In file included from /build/samus/usr/include/bits/types/siginfo_t.h:6:
ERROR:root:[stderr] /build/samus/usr/include/bits/types/__sigval_t.h:24:7: error: redefinition of 'sigval'
ERROR:root:[stderr] union sigval
ERROR:root:[stderr]       ^
ERROR:root:[stderr] /build/samus/usr/include/asm-generic/siginfo.h:7:15: note: previous definition is here
ERROR:root:[stderr] typedef union sigval {
ERROR:root:[stderr]               ^
ERROR:root:[stderr] In file included from seccomp_bpf_tests.c:24:
ERROR:root:[stderr] In file included from /build/samus/usr/include/signal.h:57:
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/990193e1c020521b73037455ec9fe7187e1885af

commit 990193e1c020521b73037455ec9fe7187e1885af
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Jul 11 19:13:30 2018

autotest: remove redundant headers

si_syscall was added in glibc-2.17+, so there is no
need to keep the hack. This CL also makes autotest-tests-security builds
with glibc 2.27

BUG= chromium:861645 
TEST=emerge-samus autotest-tests-security

Change-Id: I07373c0ce021e74ea296d0749d36160c92e03630
Reviewed-on: https://chromium-review.googlesource.com/1128632
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/990193e1c020521b73037455ec9fe7187e1885af/client/site_tests/security_SeccompSyscallFilters/src/seccomp_bpf_tests.c

Comment 2 by yunlian@chromium.org, Jul 11

Status: Verified (was: Untriaged)
►

Sign in to add a comment