New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 861642 link

Starred by 1 user
Status: Verified
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Jul 11
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 834385



Sign in to add a comment

crash-reporter: failed to build with glibc 2.27

Project Member Reported by yunlian@chromium.org, Jul 9 
With glibc 2.27, emerge-samus crash-reporter

while (readdir_r(dir, &ent_buf, &ent) == 0 && ent) {
         ^
../../../../../../../usr/include/dirent.h:194:25: note: 'readdir_r' has been explicitly marked deprecated here
  __nonnull ((1, 2, 3)) __attribute_deprecated__;
                        ^
../../../../../../../usr/include/sys/cdefs.h:385:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9ae458295b507040ae4c75a3707250712f8455a5

commit 9ae458295b507040ae4c75a3707250712f8455a5
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Jul 11 19:13:16 2018

crash: remove the usage of readdir_r()

readdir_r() is deprecated, which causes build failures when using
glibc-2.24 or newer headers.  This CL replaces usage of readdir_r()
with readdir().
The change from readdir_r to readdir readdir is safe for glibc
because it guarantees readdir is thread safe, and atm we aren't
supporting other C libraries

BUG= chromium:861642 
TEST=FEATURES="test" emerge-samus crash-reporter with glibc 2.27.

Change-Id: Id156f273ca2cdd76496efaea9f755881118249ed
Reviewed-on: https://chromium-review.googlesource.com/1128627
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9ae458295b507040ae4c75a3707250712f8455a5/crash-reporter/crash_collector.cc

Comment 2 by yunlian@chromium.org, Jul 11

Status: Verified (was: Untriaged)
►

Sign in to add a comment