Wrong Magic Signature "FX_OutOfMemoryTerminate" is given to crash reports because of ThinLTO |
|||||||
Issue description(From https://bugs.chromium.org/p/chromium/issues/detail?id=508489#c33) In M67, http://crrev.com/c/949089 enabled ThinLTO[1] on all AMD64 platforms. This resulted in folding base::debug::BreakDebugger() and FX_OutOfMemoryTerminate() (and 2 other functions -> issue 860850 ) together. Because of this, the crash server cannot label stack traces which contain base::debug::BreakDebugger() correctly, and many crash reports were labelled with wrong Magic Signature "FX_OutOfMemoryTerminate". [1]: https://clang.llvm.org/docs/ThinLTO.html
,
Jul 9
Uploaded https://chromium-review.googlesource.com/c/chromium/src/+/1128693 to disable optimization for base::debug::Alias(). This will make base::debug::BreakDebugger() unique again.
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a31f26075580e73b05da1bb1d899b5edec38cea8 commit a31f26075580e73b05da1bb1d899b5edec38cea8 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Mon Jul 09 18:08:14 2018 Do not optimize base::debug::Alias(). Optimization is already disabled for MSVC, do the same thing for Clang too. BUG= 861636 TEST=Run dump_syms against chrome (w/ symbol_level=3, use_thin_lto=true, use_lld=true) and manually checked the output. Change-Id: Ia275e2310ccb8e70a2392d95ca4acadf2f218b01 Reviewed-on: https://chromium-review.googlesource.com/1128693 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#573365} [modify] https://crrev.com/a31f26075580e73b05da1bb1d899b5edec38cea8/base/debug/alias.cc
,
Jul 10
Requesting to merge to 68 and 67 (if it's not too late). https://crrev.com/573365 is needed to fix the crash server's dashboard.
,
Jul 10
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 10
It's too late for M67. Has the change been tested? Assume it's limited to the dump output?
,
Jul 11
https://crrev.com/573365 makes crash reports include more info, and fixes the wrong Magic Signatures displayed on the crash server. I did manual testing locally, but unfortunately the change is not pushed to any canary/dev release because of issue 860584 :(
,
Jul 11
Seems critical for the crash dumps. Approving merge to M68 Chrome OS.
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35360985c2b93b7aa49667a26626df3644c20052 commit 35360985c2b93b7aa49667a26626df3644c20052 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Thu Jul 12 06:05:05 2018 Do not optimize base::debug::Alias(). Optimization is already disabled for MSVC, do the same thing for Clang too. BUG= 861636 TEST=Run dump_syms against chrome (w/ symbol_level=3, use_thin_lto=true, use_lld=true) and manually checked the output. Change-Id: Ia275e2310ccb8e70a2392d95ca4acadf2f218b01 Reviewed-on: https://chromium-review.googlesource.com/1128693 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#573365}(cherry picked from commit a31f26075580e73b05da1bb1d899b5edec38cea8) Reviewed-on: https://chromium-review.googlesource.com/1134607 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#652} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/35360985c2b93b7aa49667a26626df3644c20052/base/debug/alias.cc
,
Jul 12
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by hashimoto@chromium.org
, Jul 9