AppCacheRequestHandlerTest failed in asan when disabling DCHECK |
|||||
Issue descriptionhttps://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_asan_rel_ng/50550 content_unittests (with patch) Run on OS: 'Ubuntu-14.04' Max shard duration: 0:04:51.547400 (shard #0) Min shard duration: 0:03:55.211150 (shard #1) failures: AppCacheRequestHandlerTest.SubResource_Network/1 AppCacheRequestHandlerTest.SubResource_NoRedirectFallback/1 AppCacheRequestHandlerTest.MainResource_Fallback/1 AppCacheRequestHandlerTest.DestroyedService/1 AppCacheRequestHandlerTest.SubResource_RedirectFallback/1 AppCacheRequestHandlerTest.DestroyedHostWithWaitingJob/1 viz_content_unittests (with patch) Run on OS: 'Ubuntu-14.04' Shard duration: 0:08:53.609940 failures: AppCacheRequestHandlerTest.SubResource_Network/1 AppCacheRequestHandlerTest.SubResource_NoRedirectFallback/1 AppCacheRequestHandlerTest.MainResource_Fallback/1 AppCacheRequestHandlerTest.DestroyedService/1 AppCacheRequestHandlerTest.SubResource_RedirectFallback/1 AppCacheRequestHandlerTest.DestroyedHostWithWaitingJob/1 log from AppCacheRequestHandlerTest.SubResource_Network/1 in content_unittests [ RUN ] AppCacheRequestHandlerTest.SubResource_Network/1 [ OK ] AppCacheRequestHandlerTest.SubResource_Network/1 (2 ms) [----------] 1 test from AppCacheRequestHandlerTest (12 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (56 ms total) [ PASSED ] 1 test. ================================================================= ==13813==ERROR: LeakSanitizer: detected memory leaks Direct leak of 640 byte(s) in 1 object(s) allocated from: #0 0x3e4b422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3 #1 0xc6d9281 in content::AppCacheRequestHandler::CreateJob(net::NetworkDelegate*) content/browser/appcache/appcache_request_handler.cc:316:15 #2 0xc6d815a in MaybeLoadSubResource content/browser/appcache/appcache_request_handler.cc:471:38 #3 0xc6d815a in content::AppCacheRequestHandler::MaybeLoadResource(net::NetworkDelegate*) content/browser/appcache/appcache_request_handler.cc:110 #4 0x3fdb8c9 in content::AppCacheRequestHandlerTest::SubResource_Network() content/browser/appcache/appcache_request_handler_unittest.cc:726:30 #5 0xfdda593 in Run base/callback.h:99:12 #6 0xfdda593 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:101 #7 0xfdd0bd5 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:351:25 #8 0xfdd1f23 in DeferOrRunPendingTask base/message_loop/message_loop.cc:361:5 #9 0xfdd1f23 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:419 #10 0xff9dde0 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:210:31 #11 0xfe34701 in base::RunLoop::Run() base/run_loop.cc:102:14 #12 0xc86466d in content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*) content/browser/browser_process_sub_thread.cc:178:11 #13 0xfee56b4 in base::Thread::ThreadMain() base/threading/thread.cc:337:3 #14 0xff95764 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:76:13 #15 0x7f612564d183 in start_thread /build/eglibc-ripdx6/eglibc-2.19/nptl/pthread_create.c:312
,
Jul 9
,
Jul 9
This leak happens when I tried to disable dcheck on asan builder. The build used following args.gn ``` goma_dir = "/b/swarming/w/ir/cache/goma/client" is_asan = true is_component_build = false is_debug = false is_lsan = true strip_absolute_paths_from_debug_symbols = true use_goma = true ```
,
Oct 3
Do you think this is worth poking at given that it looks like a job is being leaked?
,
Jan 12
mek@: Can you please investigate?
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94c03f94b200327211ca5fa6329807afed5920de commit 94c03f94b200327211ca5fa6329807afed5920de Author: Marijn Kruisselbrink <mek@chromium.org> Date: Wed Jan 16 02:12:49 2019 [AppCache] Fix some leaks of AppCacheURLLoaderJob. AppCacheURLLoaderJob only deletes itself if the job actually was started. If the job never starts you need to make sure to call DeleteIfNeeded to ensure it gets deleted. Bug: 861634 Change-Id: I8dc21972a6220b88392f57dca7dd905e765dad44 Reviewed-on: https://chromium-review.googlesource.com/c/1413138 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#623038} [modify] https://crrev.com/94c03f94b200327211ca5fa6329807afed5920de/content/browser/appcache/appcache_request_handler.cc [modify] https://crrev.com/94c03f94b200327211ca5fa6329807afed5920de/content/browser/appcache/appcache_request_handler_unittest.cc
,
Jan 16
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tikuta@chromium.org
, Jul 9