New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 861622 link

Starred by 3 users
Status: Fixed
Owner:
█ sashab@chromium.org
Last visit > 30 days ago
Closed: Jul 24
Cc:
weifangsun@chromium.org
slangley@chromium.org
█ mcirimele@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

The date for team drives is 1st Jan 1970

Project Member Reported by sashab@chromium.org, Jul 9 
The date for team drives is listed as 1st Jan 1970. This is likely because the team drive creation date is not stored in the proto.

The creation time is returned from the Drive API in "createdTime":
https://developers.google.com/drive/api/v3/reference/teamdrives#resource

To fix this, just need to plumb the field through.

In the meantime, we can display "--" or similar in the Time column for Team Drives.

Comment 1 by mcirimele@chromium.org, Jul 18

Cc: mcirimele@chromium.org
Sounds good - please use one dash, as that's what we do for other fields we don't have metadata for.

Related to this I'd like to update the icon for drives on the first level under "Team Drives" to the regular Drive icon (without people on it). I've attached the icon and a screenshot of what it would look like all together. 

Please let me know if you'd prefer I split this into it's own bug!
drive.svg
1.4 KB Download
files-team-drives.png
51.1 KB View Download

Comment 2 by sashab@chromium.org, Jul 18 

We current use two dashes for missing size (see attached). Not sure where you got that screenshot from.

Yes, please split the drive icon request into a separate bug. Is it important to have this for M69? We'll need not just the icon in grey but also in blue, and in 2x versions. I've attached the current versions we use for team drives for you to base them on :) Thanks.
team_drive.png
51.4 KB View Download
filetype_team_drive.png
352 bytes View Download
filetype_team_drive_active.png
372 bytes View Download
filetype_team_drive.png
689 bytes View Download
filetype_team_drive_active.png
743 bytes View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd723504e61aad9a0bbd91d9881cb87fa8c453a1

commit bd723504e61aad9a0bbd91d9881cb87fa8c453a1
Author: Sasha Morrissey <sashab@chromium.org>
Date: Thu Jul 19 03:57:00 2018

Hide the modified date for Team Drives

Hide the modified date for Team Drives, since it's always set to 1st Jan
1970. In a later patch, we will update it to the correct date.

Bug:  861622 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7be57d16fedf62c07cb0eb7bf3e2e32cf01ccaf6
Reviewed-on: https://chromium-review.googlesource.com/1141459
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576362}
[modify] https://crrev.com/bd723504e61aad9a0bbd91d9881cb87fa8c453a1/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
[modify] https://crrev.com/bd723504e61aad9a0bbd91d9881cb87fa8c453a1/ui/file_manager/file_manager/foreground/js/ui/file_table.js

Comment 4 by mcirimele@chromium.org, Jul 20 

Oh - interesting! The one dash is used in all our mocks, that's where the inconsistency came from. Not worth updating right now though, please go ahead with the "--" as you had planned :)

I created b/865993 to track the icon. Will leave it to Weifang to decide the milestone, my two cents would be to update them for M69 if possible.

Comment 5 by slangley@chromium.org, Jul 24

Status: Started (was: Assigned)

Comment 6 by slangley@chromium.org, Jul 24

Status: Fixed (was: Started)

Comment 7 by weifangsun@chromium.org, Jul 25 

Issue 867153 has been merged into this issue.
►

Sign in to add a comment