New issue
Advanced search Search tips

Issue 861585 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/1128559

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Jul 8

Issue description

WPT import https://crrev.com/c/1128559 introduced new failures in external/wpt/svg:

List of new failures:
external/wpt/svg/shapes/ellipse-05.svg [ Failure ]
external/wpt/svg/shapes/ellipse-06.svg [ Failure ]
external/wpt/svg/shapes/ellipse-08.svg [ Failure ]
external/wpt/svg/shapes/ellipse-03.svg [ Failure ]
external/wpt/svg/shapes/ellipse-07.svg [ Failure ]
external/wpt/svg/shapes/ellipse-02.svg [ Failure ]

This import contains upstream changes from 15224088a20d1dfb8a85bfe907f3439abcd098c3 to 7400064b74cfdd7c1a81d0de38e2846b44af77fc:
Merge pull request #11844 from ewilligers/ellipse-auto-radius: https://github.com/web-platform-tests/wpt/commit/7400064b74cfdd7c1a81d0de38e2846b44af77fc
Additional rx/ry property tests: https://github.com/web-platform-tests/wpt/commit/b9a9abacf233c9a3c027bc8049cba13877a07e71 [affecting this directory]
SVG ellipse supports rx/ry properties: https://github.com/web-platform-tests/wpt/commit/bbce96b69e659b0bdf3494cfe036c50c6cfe4233 [affecting this directory]
Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/6c4096358e4be4610fd7b8ec16a68dd984c7f7fd . (#11845): https://github.com/web-platform-tests/wpt/commit/f82e6636c40d9341016acf524872ceb1bd0e072e

 
Status: Available (was: Untriaged)
I guess we missed this when we started supporting/parsing 'auto' for various properties ('rx' and 'ry' in this particular case.)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1eea3dace2d1113d23405d8fa731330c6771515

commit e1eea3dace2d1113d23405d8fa731330c6771515
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Jul 09 21:37:49 2018

Fix handling of 'auto' for 'rx' and 'ry' on <ellipse>

Per the spec[1][2], when 'auto' is specified for 'rx' or 'ry' the used
value of said property will be the used value of the other property
('rx' for 'ry' and vice versa.)

[1] https://svgwg.org/svg2-draft/geometry.html#RX
[2] https://svgwg.org/svg2-draft/geometry.html#RY

Bug:  861585 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iec0a9179527a5b0e99cc6a0ec671e5b6d92f828b
Reviewed-on: https://chromium-review.googlesource.com/1128885
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#573457}
[modify] https://crrev.com/e1eea3dace2d1113d23405d8fa731330c6771515/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e1eea3dace2d1113d23405d8fa731330c6771515/third_party/WebKit/LayoutTests/svg/custom/SVGEllipse-without-rx-or-ry-expected.svg
[modify] https://crrev.com/e1eea3dace2d1113d23405d8fa731330c6771515/third_party/blink/renderer/core/layout/svg/layout_svg_ellipse.cc
[modify] https://crrev.com/e1eea3dace2d1113d23405d8fa731330c6771515/third_party/blink/renderer/core/svg/svg_ellipse_element.cc

Owner: f...@opera.com
Status: Fixed (was: Available)

Sign in to add a comment