textarea with dir='auto' might freeze the tab process.
Reported by
gilad.ku...@gmail.com,
Jul 7
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36 Steps to reproduce the problem: 1. go to https://goo.gl/AdJNQA 2. press the right arrow until the text curt passes the first $ 3. the process should be unresponsive at this point What is the expected behavior? page should be responsive What went wrong? process is unresponsive and needed to be terminated Did this work before? N/A Does this work in other browsers? Yes Chrome version: 67.0.3396.99 Channel: stable OS Version: Flash Version:
,
Jul 10
Able to reproduce the issue on the reported chrome 67.0.3396.99,latest canary 69.0.3486.0 using Windows 10,Mac 10.13.5 ,Ubuntu 17.10.Below is the bisect information for same. Bisect Info: ================ Good build: 67.0.3388.0 Bad build: 67.0.3390.0 CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/59deb360661b808a61f88790b4b9d8be7a22a1e2..6a93bb17fb2477de9bddce5c0275f422b1cb1cce Suspect: https://chromium.googlesource.com/chromium/src/+/6a93bb17fb2477de9bddce5c0275f422b1cb1cce Reviewed-on: https://chromium-review.googlesource.com/994389 xiaochengh:Please confirm the issue and help in re-assigning if it is not related to your change.Adding RBS label for M-68 feel free to change it if not required. Thanks!
,
Jul 10
We're not planning any further M67 releases. Pls target fix for M68.
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b245c2e812b84d4e58b76dbc0fd6bb14b5d257e commit 2b245c2e812b84d4e58b76dbc0fd6bb14b5d257e Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Jul 11 22:11:02 2018 Make bidi adjustment in auto-directioned paragraphs saner In bidi adjustment for legacy layout, there is a hack that stops any adjustment if current text box is in 'unicode-bidi: plaintext'. This is wrong if the auto-directioned paragraph still contains bidirectional text. Ideally, we should remove this hack, and check paragraph direction. However, we don't have a reliable way to do this in legacy layout. So this patch makes the hack slightly saner that, bidi adjustment shouldn't stop as long as we are at a bidi boundary, even if we are in 'unicode-bidi: plaintext'. Bug: 861559 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie7e1f704b976adf28a5d143e8265a499af0d62e4 Reviewed-on: https://chromium-review.googlesource.com/1132472 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574362} [modify] https://crrev.com/2b245c2e812b84d4e58b76dbc0fd6bb14b5d257e/third_party/blink/renderer/core/editing/inline_box_traversal.cc [modify] https://crrev.com/2b245c2e812b84d4e58b76dbc0fd6bb14b5d257e/third_party/blink/renderer/core/editing/selection_modifier_character_test.cc
,
Jul 11
,
Jul 11
The CL in #4 adds another level of hack over the pile of hacks in the legacy code. It may introduce new regressions, but I'm not sure. As there are not many days before M68 Stable release and this is not a high priority bug, I'm not going to target M68 due to risk concerns.
,
Jul 11
,
Jul 13
Able to reproduce the issue on chrome version 67.0.3396.99 (build without fix) as per the comment #0. Verified the fix on Mac 10.13.5 using Chrome version # 69.0.3489.0 . Attaching screen-cast for reference. Observed that "right arrow until the text curt passes the first $ " The fix is working as expected, adding Verified labels Thanks...! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by susan.boorgula@chromium.org
, Jul 9