New issue
Advanced search Search tips

Issue 861544 link

Starred by 1 user
Status: Fixed
Owner:
fs...@chromium.org
Closed: Jul 10
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

fast/text/selection/khmer-selection.html is failing/flaky on Win

Project Member Reported by pdr@chromium.org, Jul 7 
This test started failing at:
New inline text rendering to support ligatures
https://chromium.googlesource.com/chromium/src/+/129e4ea0be58c7d1c20be2c719b66b794d3c983f

Test:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ftext%2Fselection%2Fkhmer-selection.html&testType=webkit_layout_tests

Example failure:
https://test-results.appspot.com/data/layout_results/WebKit_Win10/37552/layout-test-results/results.html

The results actually seem flaky in the non-selected text, which is surprising. I'm going to suppress the failure for now, but this should be investigated.

Comment 1 by pdr@chromium.org, Jul 7 

I think this test has always been a little flaky on Windows, even before your patch. It looks like your patch picked up the flaky baseline which causes the test to fail 90% of the time (instead of 10% as before).

The flakiness looks like an issue getting the font for the teletype text between <tt> tags. WDYT of removing the <tt> tags from the test since they are unrelated to the actual test?
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31df6925f94fcdc72937e24dd25d66c5b4846ddc

commit 31df6925f94fcdc72937e24dd25d66c5b4846ddc
Author: Philip Rogers <pdr@chromium.org>
Date: Sat Jul 07 17:49:50 2018

Mark fast/text/selection/khmer-selection.html as flaky on Windows

TBR=fserb@chromium.org

No-Try: true
Bug:  861544 
Change-Id: I845999132e69e0f89681102e2c74de1ab61d405f
Reviewed-on: https://chromium-review.googlesource.com/1128507
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573171}
[modify] https://crrev.com/31df6925f94fcdc72937e24dd25d66c5b4846ddc/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 Deleted

Comment 4 by fs...@chromium.org, Jul 10 

That makes a lot of sense. Doing the change.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e

commit 065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e
Author: Fernando Serboncini <fserb@chromium.org>
Date: Tue Jul 10 20:37:22 2018

Fix khmer test flakiness

The underlying problem is still unsolved, but tracked here:
http://crbug.com/862304

Bug:  861544 
Change-Id: Iaa7fb137398520ead7f4fe2c1b6778251c1034f0
Reviewed-on: https://chromium-review.googlesource.com/1131829
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573892}
[modify] https://crrev.com/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e/third_party/WebKit/LayoutTests/fast/text/selection/khmer-selection.html
[modify] https://crrev.com/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e/third_party/WebKit/LayoutTests/platform/linux/fast/text/selection/khmer-selection-expected.png
[delete] https://crrev.com/c3207698ec8e01350186c05f5a462eca7795788c/third_party/WebKit/LayoutTests/platform/linux/fast/text/selection/khmer-selection-expected.txt
[modify] https://crrev.com/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/selection/khmer-selection-expected.png
[modify] https://crrev.com/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/text/selection/khmer-selection-expected.png
[modify] https://crrev.com/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/text/selection/khmer-selection-expected.png
[modify] https://crrev.com/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e/third_party/WebKit/LayoutTests/platform/mac/fast/text/selection/khmer-selection-expected.png
[delete] https://crrev.com/c3207698ec8e01350186c05f5a462eca7795788c/third_party/WebKit/LayoutTests/platform/mac/fast/text/selection/khmer-selection-expected.txt
[modify] https://crrev.com/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e/third_party/WebKit/LayoutTests/platform/win/fast/text/selection/khmer-selection-expected.png
[delete] https://crrev.com/c3207698ec8e01350186c05f5a462eca7795788c/third_party/WebKit/LayoutTests/platform/win/fast/text/selection/khmer-selection-expected.txt
[modify] https://crrev.com/065270ef15bf09dcc2d8a3ef0e92d77b2658ce6e/third_party/WebKit/LayoutTests/platform/win7/fast/text/selection/khmer-selection-expected.png
[delete] https://crrev.com/c3207698ec8e01350186c05f5a462eca7795788c/third_party/WebKit/LayoutTests/platform/win7/fast/text/selection/khmer-selection-expected.txt

Comment 6 by fs...@chromium.org, Jul 10

Status: Fixed (was: Started)
Fixedrino.
►

Sign in to add a comment