Updating Crostini apps causes them to lose their app list ordinal |
||||||||
Issue descriptionWhen a Crostini app is updated it is removed and re-inserted (in CrostiniAppModelBuilder::OnRegistryUpdated) which causes them to lose their position in the app list or app list folder. They should stay where they were.
,
Aug 1
They also lose their folder location
,
Aug 2
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/223968844367fef041f270c862d6c017c25b6579 commit 223968844367fef041f270c862d6c017c25b6579 Author: Renee Wright <rjwright@chromium.org> Date: Tue Aug 07 06:50:29 2018 Instead of rebuilding updated Crostini apps, just update the name The name should be the only member of the app item that can change as a result of the app being updated (i.e. changes to the .desktop file), so that is the only thing we need to update on the app item. This fixes the problem of app items moving or changing folder when the app is updated. I have tried this on hardware and it works as intended. Bug: 861524 Change-Id: I20e413991609f861b0b371856e8fc96e4905978c Reviewed-on: https://chromium-review.googlesource.com/1160067 Reviewed-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#581153} [modify] https://crrev.com/223968844367fef041f270c862d6c017c25b6579/chrome/browser/ui/app_list/crostini/crostini_app_model_builder.cc
,
Aug 7
,
Aug 8
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9
,
Aug 9
Merge approved, M69.
,
Aug 10
,
Aug 13
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 20
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rjwright@chromium.org
, Jul 9