Settings: Focusing subpage-arrow icon when exiting subpage broken. |
|||||
Issue descriptionThis seems to have regressed at r542362 where the paper-icon-button-light version was bumped to 2.x. Example repro steps (happens in multiple places across the UI). 1) Click "manage search engines". 2) Click the back arrow within the page (or use the keyboard). 3) Observe the focus. Expected: The "manage search engines" icon should be focused (with or without ripple). Actual: Focus is lost.
,
Jul 7
Candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1128463.
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc810ef6085685f24c3d5e22413a5cd42891d8d3 commit fc810ef6085685f24c3d5e22413a5cd42891d8d3 Author: dpapad <dpapad@chromium.org> Date: Mon Jul 09 23:44:15 2018 Settings: Fix focus restoration after subpage exit. The code stopped working when paper-icon-button-light was updated to its latest version, which changed the structure of the DOM. Bug: 860854 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0c7189752a5ae47eab0024e3e81775a5f93ee7b6 Reviewed-on: https://chromium-review.googlesource.com/1128463 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573531} [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/a11y_page/a11y_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/android_apps_page/android_apps_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/crostini_page/crostini_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/date_time_page/date_time_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/device_page/device_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/downloads_page/downloads_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/internet_page/internet_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/people_page/people_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/printing_page/printing_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/fc810ef6085685f24c3d5e22413a5cd42891d8d3/chrome/browser/resources/settings/search_page/search_page.js
,
Jul 10
,
Jul 10
Able to reproduce the issue on chrome reported version 69.0.3481.0(BUild without fix) Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #69.0.3487.0 as per the comment#0 Attaching screen cast for reference. Observed "The 'manage search engines' icon get focused" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b709ac12f4485ecf6737e7c6de41ba8c60bfaf44 commit b709ac12f4485ecf6737e7c6de41ba8c60bfaf44 Author: dpapad <dpapad@chromium.org> Date: Thu Jul 12 23:41:15 2018 Settings WebUI: Fix focus when exiting syncSetup subpage. This was throwing a runtime error when the unified-consent flag was enabled. Bug: 860854 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6e521b813ca160e5434ac066e47f73ecf61b7ba1 Reviewed-on: https://chromium-review.googlesource.com/1134515 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#574774} [modify] https://crrev.com/b709ac12f4485ecf6737e7c6de41ba8c60bfaf44/chrome/browser/resources/settings/people_page/people_page.js
,
Jul 16
Able to reproduce the issue on chrome reported version 69.0.3480.0(Build without fix) Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #69.0.3493.0 as per the comment#6 Attaching screen cast for reference. Observed "The 'syncSetup subpage' icon get focused" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Jul 25
Issue 836752 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpa...@chromium.org
, Jul 7Status: Started (was: Available)