autotest: Allow setting CPU governor from server tests |
||
Issue descriptionThe autotest_lib.client.bin.utils package contains various functions for setting the CPU governor of a client system, but no such functionality is available for use in server tests. These functions should be modified to allow a host to be specified without breaking their existing behavior.
,
Jul 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/19e0ab3547756bbced5ef7e1b7abb645bc831720 commit 19e0ab3547756bbced5ef7e1b7abb645bc831720 Author: Alex Khouderchah <akhouderchah@chromium.org> Date: Sun Jul 15 01:11:39 2018 autotest: Allow setting CPU governor from server tests The autotest_lib.client.bin.utils package provides various functions for setting and restoring the CPU governor of a client system. This change modifies these functions to allow a custom host to be specified. The default behavior of these functions remains unchanged. BUG= chromium:860844 TEST=Ran video_PlaybackPerf.vp8 test to ensure that a regular call to ensure that a regular call to set_high_performance_mode would still work. TEST=Made calls to set_high_performance_mode and restore_scaling_governor_states from video_HangoutHardwarePerf test to ensure that calls to those functions will still work without change, despite the move from bin.utils to common_lib.utils. TEST=Manually tested with modified server test to ensure that the functions work when specifying a remote host. Change-Id: I4d1bc263d36f848aa8d3f7f46ecf6fab912d0f1f Reviewed-on: https://chromium-review.googlesource.com/1128445 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/19e0ab3547756bbced5ef7e1b7abb645bc831720/client/common_lib/utils.py [modify] https://crrev.com/19e0ab3547756bbced5ef7e1b7abb645bc831720/client/bin/utils.py
,
Jul 22
,
Jul 22
Should we verify this by adding a "performance" governor setting to the vht80 config? We've had to debug cpu scheduling issues with new designs using intel_pstates (redacting names here, but all the Create ones I've worked on). It would be nice to log the delta b/w default and performance governors in these cases.
,
Aug 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b5f75ebe8058143d3cb5c66f05bb4d4f59a12a3c commit b5f75ebe8058143d3cb5c66f05bb4d4f59a12a3c Author: Alex Khouderchah <akhouderchah@chromium.org> Date: Sat Aug 11 05:44:04 2018 autotest: wifi: perf test with specific governor Our network_WiFi_Perf tests run with whatever cpu governor is set on the DUT and router. This change allows for perf tests to be run in which one set of tests is performed with the existing cpu governors, and the other set of tests to be run with the specified governer applied to all cores on both the DUT and router. By default, the tests remain unchanged. One must run the test with '--args="governor=$(GOVERNOR_NAME)" to get the new functionality. BUG= chromium:860844 TEST=Ran `test_that -b $(BOARD) $(MACHINE) network_WiFi_Perf.vht80 to ensure test will, by default, work as before (except for the added 'governor-default' part of the test tag). TEST=Ran `test_that -b $(BOARD) $(MACHINE) network_WiFi_Perf.vht80 --args="governor=performance"` to take the performance test with the default and performance governors. Change-Id: Ie735cea67f8528e2f715887b560a9679a85e0044 Reviewed-on: https://chromium-review.googlesource.com/1148584 Commit-Ready: Alex Khouderchah <akhouderchah@chromium.org> Tested-by: Alex Khouderchah <akhouderchah@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/b5f75ebe8058143d3cb5c66f05bb4d4f59a12a3c/tko/parsers/version_1.py [modify] https://crrev.com/b5f75ebe8058143d3cb5c66f05bb4d4f59a12a3c/server/site_tests/network_WiFi_Perf/network_WiFi_Perf.py |
||
►
Sign in to add a comment |
||
Comment 1 by akhouderchah@chromium.org
, Jul 7