Issue metadata
Sign in to add a comment
|
Cloud Print Service cannot be stopped |
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3396.99 OS: Windows Prereqs: Install the Cloud Print Service [1] and set it up. What steps will reproduce the problem? (1) Open the Cloud Print Service UI (2) (Assuming the service has already been set up and started) Press the Stop button. What is the expected result? The service stops, and the button changes to a Start button. What happens instead? The Stop button stays grayed out and the service process does not stop. This worked with 67.0.3396.0. Bisecting, we get to a blame list like [2], so I suspect this is caused by the cherrypick [3] for r553653. [1] https://tools.google.com/dlpage/cloudprintservice [2] https://chromium.googlesource.com/chromium/src/+log/67.0.3396.25..67.0.3396.30?pretty=fuller&n=10000 [3] https://chromium.googlesource.com/chromium/src/+/d8247fee809fcd780438c812461b099885718ff7
,
Jul 6
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23e212e0f9b0d23d39b8958bd44d5b7a0408cb60 commit 23e212e0f9b0d23d39b8958bd44d5b7a0408cb60 Author: Lei Zhang <thestig@chromium.org> Date: Tue Jul 10 04:59:54 2018 Make the Cloud Print service process listen for WM_QUIT. The Windows base::MessagePumpUI used to process WM_QUIT, but r553653 changed it to ignore WM_QUIT. This CL adds EnableWmQuit() methods to MessagePumpForUI and MessageLoopForUI on Windows. The Cloud Print service process can then call EnableWmQuit() for its MessagePumpForUI to get the old behavior. BUG= 860827 Change-Id: Ie9d9c4c8e2dd205f3ec24cb10be364d0653a7f97 Reviewed-on: https://chromium-review.googlesource.com/1128327 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#573620} [modify] https://crrev.com/23e212e0f9b0d23d39b8958bd44d5b7a0408cb60/base/message_loop/message_loop.cc [modify] https://crrev.com/23e212e0f9b0d23d39b8958bd44d5b7a0408cb60/base/message_loop/message_loop.h [modify] https://crrev.com/23e212e0f9b0d23d39b8958bd44d5b7a0408cb60/base/message_loop/message_loop_unittest.cc [modify] https://crrev.com/23e212e0f9b0d23d39b8958bd44d5b7a0408cb60/base/message_loop/message_pump_win.cc [modify] https://crrev.com/23e212e0f9b0d23d39b8958bd44d5b7a0408cb60/base/message_loop/message_pump_win.h [modify] https://crrev.com/23e212e0f9b0d23d39b8958bd44d5b7a0408cb60/chrome/service/service_main.cc
,
Jul 11
I verified this fixes the bug in the latest build. Requesting a merge to M68 since it regressed.
,
Jul 11
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 13
Approved - branch:3440
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0769af30ba4a82c5f8187d3d24c685932291cd0a commit 0769af30ba4a82c5f8187d3d24c685932291cd0a Author: Lei Zhang <thestig@chromium.org> Date: Fri Jul 13 21:08:04 2018 M68: Make the Cloud Print service process listen for WM_QUIT. The Windows base::MessagePumpUI used to process WM_QUIT, but r553653 changed it to ignore WM_QUIT. This CL adds EnableWmQuit() methods to MessagePumpForUI and MessageLoopForUI on Windows. The Cloud Print service process can then call EnableWmQuit() for its MessagePumpForUI to get the old behavior. BUG= 860827 TBR=thestig@chromium.org (cherry picked from commit 23e212e0f9b0d23d39b8958bd44d5b7a0408cb60) Change-Id: Ie9d9c4c8e2dd205f3ec24cb10be364d0653a7f97 Reviewed-on: https://chromium-review.googlesource.com/1128327 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#573620} Reviewed-on: https://chromium-review.googlesource.com/1137030 Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#671} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/0769af30ba4a82c5f8187d3d24c685932291cd0a/base/message_loop/message_loop.cc [modify] https://crrev.com/0769af30ba4a82c5f8187d3d24c685932291cd0a/base/message_loop/message_loop.h [modify] https://crrev.com/0769af30ba4a82c5f8187d3d24c685932291cd0a/base/message_loop/message_loop_unittest.cc [modify] https://crrev.com/0769af30ba4a82c5f8187d3d24c685932291cd0a/base/message_loop/message_pump_win.cc [modify] https://crrev.com/0769af30ba4a82c5f8187d3d24c685932291cd0a/base/message_loop/message_pump_win.h [modify] https://crrev.com/0769af30ba4a82c5f8187d3d24c685932291cd0a/chrome/service/service_main.cc
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7fa28c64c273530c71ca14c5b66d1ef10501b92 commit c7fa28c64c273530c71ca14c5b66d1ef10501b92 Author: Lei Zhang <thestig@chromium.org> Date: Thu Sep 27 20:48:31 2018 Add a test for the Cloud Print service's interaction with WM_QUIT. BUG= 860827 Change-Id: I403f2b4ada07242cc035ebb12ec1d1f6145ac42d Reviewed-on: https://chromium-review.googlesource.com/1249838 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#594850} [modify] https://crrev.com/c7fa28c64c273530c71ca14c5b66d1ef10501b92/chrome/browser/service_process/service_process_control.cc [modify] https://crrev.com/c7fa28c64c273530c71ca14c5b66d1ef10501b92/chrome/browser/service_process/service_process_control.h [modify] https://crrev.com/c7fa28c64c273530c71ca14c5b66d1ef10501b92/chrome/browser/service_process/service_process_control_browsertest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by w...@chromium.org
, Jul 6