Rerunning the test locally against multiple buddy and candy hosts failed.

pbathini@, re-generate the zoom-in and zoom out data files for candy touch device. First check if there is a file path naming issue.

Another action item is to find the specific boards and see if test beds are having touchscreen in contact with any of the surroundings - I've seen objects put between TS and base to keep the lid open etc.

Checking on Candy example:
- Only one board is having touchscreen and part of pool:bvt - chromeos4-row8-rack3-host5. No wonder it is the only one to run this test - https://screenshot.googleplex.com/AzPWvJnioVC
- Need to - check the board physically, and add more touchscreen boards to the pool:bvt

Checking on buddy(chromebase) example:
- these are all 6 touchscreen boards in pool:bvt - https://screenshot.googleplex.com/L3yFDVz12wi
- Need to check how are they positioned and if anything is touching the screens for all of them. 

Checking on nyan_big example:
- These are the 5 boards with touchscreen on pool:bvt -https://screenshot.googleplex.com/bJ5uqjKQFiV

Etc.

Observing devices(candy, setzer) in lab while test is running, I'd accept the test zoom data is wrong, having nothing was found to interfere with touchscreen at the testbed.

Hi pramod, do you have the data generated?

Hi Kalin,

Tied up with BT full release testing.

PFA the gesture files for candy

Deleted: candy_touchscreen_2a43_zoom-in 52.2 KB

candy_touchscreen_2a43_zoom-in 52.2 KB View Download

Deleted: candy_touchscreen_2a43_zoom-out 52.2 KB

candy_touchscreen_2a43_zoom-out 52.2 KB View Download

I replaced the original files with the new in #6. Lets see if the test will improve on Candy board.

The new test files did not make the test pass - https://screenshot.googleplex.com/gW1nptXWNDm

Possible scenarios:
- zoom does not actually happen
- verification is not sufficient

Picked up the device pbathini@ generated and played back the files in #6. Test failed - FAIL: No page zoom occurred!

- Check if any of the passing boards are passing for real
- Check what is wrong with check_zoom_in_one_direction()

Could not find boards that actually pass the test
The test reads the value of window.innerWidth in TestPage.get_page_width()
Before and after the zoom it returns one same value - 1366(for Candy) and test fails respectively. get_page_width() returns same value as even the content is zoomed, the chrome window is unchanged.

AI - Implement zoom sensitive verification method.

Up for review - https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1380719

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3e505362fdd6e2773c8b0808a3d2eabb0c92cbb9

commit 3e505362fdd6e2773c8b0808a3d2eabb0c92cbb9
Author: Kalin Stoyanov <kalin@chromium.org>
Date: Tue Dec 18 12:28:54 2018

Fix touchscreen zoom input test verification

Replaced window.innerWidth with window.visualViewport.scale

BUG= chromium:860818 
TEST=Tested DUTs locally and in lab

Change-Id: I63d7b71bd8fcec465527f44cfe7fcf2d66dae3ee
Reviewed-on: https://chromium-review.googlesource.com/1380719
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Kalin Stoyanov <kalin@chromium.org>
Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org>

[modify] https://crrev.com/3e505362fdd6e2773c8b0808a3d2eabb0c92cbb9/client/site_tests/touch_TouchscreenZoom/touch_TouchscreenZoom.py
[modify] https://crrev.com/3e505362fdd6e2773c8b0808a3d2eabb0c92cbb9/client/cros/touch_playback_test_base.py

This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ad766d0c01b555f98be8b4bb877e306620508252

commit ad766d0c01b555f98be8b4bb877e306620508252
Author: Kalin Stoyanov <kalin@chromium.org>
Date: Wed Dec 19 18:47:35 2018

Fix touchscreen zoom input test verification

Replaced window.innerWidth with window.visualViewport.scale

BUG= chromium:860818 
TEST=Tested DUTs locally and in lab

Change-Id: I63d7b71bd8fcec465527f44cfe7fcf2d66dae3ee
Reviewed-on: https://chromium-review.googlesource.com/1380719
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Kalin Stoyanov <kalin@chromium.org>
Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org>
(cherry picked from commit 3e505362fdd6e2773c8b0808a3d2eabb0c92cbb9)
Reviewed-on: https://chromium-review.googlesource.com/c/1382805
Commit-Queue: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/ad766d0c01b555f98be8b4bb877e306620508252/client/site_tests/touch_TouchscreenZoom/touch_TouchscreenZoom.py
[modify] https://crrev.com/ad766d0c01b555f98be8b4bb877e306620508252/client/cros/touch_playback_test_base.py

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot