New issue
Advanced search Search tips

Issue 860815 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
cturner-helpforum-bugs


Sign in to add a comment

The "box-shadow" attribute has no color-picker if it has the "!important" flag.

Reported by robinroeper10@gmail.com, Jul 6

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

Steps to reproduce the problem:
(1) Open your Chrome Developer Tools.
(2) Apply the "box-shadow" attribute with a "!important" flag to any element via Class, Id or element.style.
(3) Inspect the Styles of the element.

What is the expected behavior?
The "box-shadow" attribute provides a Color-picker if it has the "!important" flag.

What went wrong?
The "box-shadow" attribute doesn't provide a Color-picker if it has the "!important" flag.

Did this work before? N/A 

Chrome version: 67.0.3396.99  Channel: stable
OS Version: OS X 10.13.3
Flash Version:
 
Screen Shot 2018-07-06 at 10.40.38 PM.png
11.7 KB View Download
Screen Shot 2018-07-06 at 10.28.14 PM.png
10.7 KB View Download
Labels: Hotlist-ConOps
Status: Untriaged (was: Unconfirmed)
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET Needs-Feedback
Unable to reproduce the issue on reported chrome version 67.0.3396.99 using Mac 10.13.3.Attaching screen-cast for reference.
Steps: 
---------
1. Launched reported chrome 
2. Navigated the URL ""https://www.facebook.com/Google/""
3. Opened Dev tools >Styles > body >>Typed "!important" as per screen-cast.

@Reporter: Could you please review the attached screen-cast and confirm if anything being missed here.If possible provide screencast for better triaging it.

Thanks..!
860815.mp4
2.6 MB View Download
@phanindra.mandapaka
You must do it on a "box-shadow" element. And not in the "background" element.
And in the video you add "!important" as a new style element (and then is it gone).

Version 67.0.3396.99 (Official Build) (64-bit)

I can confirm the issue with this steps:
1. Open Google Chrome web browser
2. Navigated the URL "https://www.facebook.com/Google/"
3. Opened Dev tools > Styles > body
4. Copy this text:
box-shadow: 1px 1px 1px #b97070 !important;
5. At the end of the bracket (from body), paste that text.

You see that the "#b97070" do not show a color-picker button.

Owner: einbinder@chromium.org
Status: Assigned (was: Untriaged)
True.


Components: -Platform>DevTools Platform>DevTools>Authoring

Comment 6 Deleted

Common.Color.Regex is separating the !important flag and important does not match one of the regexIndex's for _parseShadow therefore returning blank. Patch to follow.

Sign in to add a comment