New issue
Advanced search Search tips

Issue 860800 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

angle_perftests failing on chromium.gpu.fyi/Android FYI Release (Nexus 5)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 6

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of sunnyps@chromium.org

angle_perftests failing on chromium.gpu.fyi/Android FYI Release (Nexus 5)

Builders failed on: 
- Android FYI Release (Nexus 5): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29

Example failure:
I   24.186s run_tests_on_device(07db00e713cc350a)  [ RUN      ] UniformsBenchmark.Run/gles_null_400_vec4
I   24.186s run_tests_on_device(07db00e713cc350a)  ../../third_party/angle/src/tests/perf_tests/ANGLEPerfTest.cpp:171: Failure
I   24.186s run_tests_on_device(07db00e713cc350a)  Failed
I   24.186s run_tests_on_device(07db00e713cc350a)  Failed initializing EGLWindow
I   24.186s run_tests_on_device(07db00e713cc350a)  Stack trace:
I   24.186s run_tests_on_device(07db00e713cc350a)  #00 0xa2efab2f /data/app/org.chromium.native_test-1/lib/arm/lib_angle_perftests__library.so+0x00113b2f
I   24.186s run_tests_on_device(07db00e713cc350a)  #01 0xa2ed65a9 /data/app/org.chromium.native_test-1/lib/arm/lib_angle_perftests__library.so+0x000ef5a9
I   24.186s run_tests_on_device(07db00e713cc350a)  #02 0xa2efc817 /data/app/org.chromium.native_test-1/lib/arm/lib_angle_perftests__library.so+0x00115817

Symbolized:
Stack Trace:
  RELADDR   FUNCTION                                                                   FILE:LINE
  00113b2f  testing::internal::AssertHelper::operator=(testing::Message const&) const  ??:0:0
  000ef5a9  ANGLERenderTest::SetUp()                                                   ??:0:0
  00115817  testing::Test::Run()                                                       ??:0:0
 
Components: Internals>GPU>Testing
Labels: OS-Android Type-Bug-Regression
Cc: geoffl...@chromium.org
Labels: GPU-Qualcomm
Cc: ynovikov@chromium.org
Components: Internals>GPU>ANGLE
Owner: geoffl...@chromium.org
Status: Assigned (was: Available)
Only one CL in the regression range:

https://chromium.googlesource.com/angle/angle/+log/838f304d37cc2b..258e87182bcfd5664

258e871 EGL: Support unvirtualized contexts and unsafe multithreading. by Geoff Lang

Geoff or Yuly would be good owners for this.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93f672529c048ed901c5a3a28a635cb7c32000ef

commit 93f672529c048ed901c5a3a28a635cb7c32000ef
Author: Kenneth Russell <kbr@chromium.org>
Date: Tue Jul 10 01:22:54 2018

Stop running angle_perftests on Nexus 5.

These tests have been failing for a few days on this bot for a known
reason. Until it's addressed, get the bot green again.

Tbr: geofflang@chromium.org
Tbr: jmadill@chromium.org
Bug:  860800 
Change-Id: Id9707e6942cf1fca0745a2755b6eab5503bf3c2f
Reviewed-on: https://chromium-review.googlesource.com/1130597
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573585}
[modify] https://crrev.com/93f672529c048ed901c5a3a28a635cb7c32000ef/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/93f672529c048ed901c5a3a28a635cb7c32000ef/testing/buildbot/test_suite_exceptions.pyl

Cc: chrome-gpu-perf-owners@chromium.org
 Issue 862655  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/89ef177f94753a91d7ec12aa58a5b06df2c12f0f

commit 89ef177f94753a91d7ec12aa58a5b06df2c12f0f
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Jul 11 18:11:00 2018

EGL: Fix binding EGL_NO_SURFACE without surfaceless support.

It was possible for ANGLE to call eglMakeCurrent with EGL_NO_SURFACE and
a valid context when the client called eglMakeCurrent with
EGL_NO_SURFACE and EGL_NO_CONTEXT.  Fix this by always binding a surface
when the driver has no native surfaceless support.

Don't expose the surfaceless extension when it's not possible to support
it (unvirtualized contexts and no native surfaceless support).

BUG= 860800 
BUG=angleproject:2464

Change-Id: Id8af9638d4356dbd710c453c9f196b9f25a2bbf9
Reviewed-on: https://chromium-review.googlesource.com/1131555
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/89ef177f94753a91d7ec12aa58a5b06df2c12f0f/src/libANGLE/renderer/gl/egl/android/DisplayAndroid.cpp
[modify] https://crrev.com/89ef177f94753a91d7ec12aa58a5b06df2c12f0f/src/libANGLE/renderer/gl/egl/android/DisplayAndroid.h
[modify] https://crrev.com/89ef177f94753a91d7ec12aa58a5b06df2c12f0f/src/libANGLE/renderer/gl/egl/ozone/DisplayOzone.cpp
[modify] https://crrev.com/89ef177f94753a91d7ec12aa58a5b06df2c12f0f/src/libANGLE/renderer/gl/egl/ozone/DisplayOzone.h
[modify] https://crrev.com/89ef177f94753a91d7ec12aa58a5b06df2c12f0f/src/libANGLE/renderer/gl/egl/DisplayEGL.h
[modify] https://crrev.com/89ef177f94753a91d7ec12aa58a5b06df2c12f0f/src/libANGLE/renderer/gl/egl/DisplayEGL.cpp

The issue is fixed now.  Not sure if we want to re-enable angle_perftets on this bot though, not even angle_end2end_tests are run there.
Thanks Geoff. Let's re-enable the test suite since in general more coverage is better than less. It looks like there was a problem a while ago running angle_end2end_tests on these older devices; wonder if that is still the case. https://chromium-review.googlesource.com/1138549 in flight turning angle_perftests back on on the Nexus 5.

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/508cc6b13b28f73f80fbfd019b83786cfac23970

commit 508cc6b13b28f73f80fbfd019b83786cfac23970
Author: Kenneth Russell <kbr@chromium.org>
Date: Mon Jul 16 19:19:36 2018

Re-enable angle_perftests on Nexus 5.

Bug:  860800 
Change-Id: I131f5e7a73d435f0d55788cea351f14a34039526
Tbr: geofflang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1138549
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575377}
[modify] https://crrev.com/508cc6b13b28f73f80fbfd019b83786cfac23970/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/508cc6b13b28f73f80fbfd019b83786cfac23970/testing/buildbot/test_suite_exceptions.pyl

Status: Fixed (was: Assigned)
Thanks for re-enabling the tests, Ken!
You're welcome Geoff!

Sign in to add a comment