New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860799 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Today’s view “Show More” in Chrome - Suggested Sites doesn’t show additional information.

Project Member Reported by shbarezer@chromium.org, Jul 6

Issue description

App Version: 69.0.3483.0 canary
iOS Version: 11.4.1, 12
Device: iPhone x, iPhone 7
URL: 

Precondition:
Add Chrome - Suggested Sites to Today’s view

Steps to reproduce:
  1. Navigate to Today’s view
  2. Tap on Show More

Observed results:  Today’s view “Show More” in Chrome - Suggested Sites doesn’t show additional information.

Expected results:  Today’s view “Show More” in Chrome - Suggested Sites should show additional information. 

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: , Safari: NA

Link to video/image:
https://drive.google.com/file/d/1MoxBFvDQNYm3tlcL0Ud28OC8AVa2Hi8K/view

 
Labels: -Restrict-View-Google
Cc: gambard@chromium.org ghendel@chromium.org mard...@chromium.org
Owner: olivierrobin@chromium.org
Status: Assigned (was: Untriaged)
I don't know how many tiles are supposed to show up. On my iPhone SE (narrow phone), only 3 tiles are showing. Tapping on Show More shows a 4th one.
Is this a UI Refresh bug?
Cc: olivierrobin@chromium.org
Owner: lod@chromium.org
Yes this is UI Refresh bug
Labels: -Pri-2 M-69 MS-UIRefresh Q2 Pri-1
If the Show More link isn't going to do anything, it shouldn't be there (this may depend on device size). 
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/705e1516d4fc03389818f4af57f48b4b6f5f7a88

commit 705e1516d4fc03389818f4af57f48b4b6f5f7a88
Author: Elodie Banel <lod@google.com>
Date: Thu Jul 19 15:32:04 2018

Allow only compact widget size when all sites shown

When all the sites fit on a single row (as is the case for most
devices now that only 4 sites are shown), hide the "Show more"
option and allow only compact mode.

Bug:  860799 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If2efa48bcd1cbe23c49b34be4ec084f95a703d08
Reviewed-on: https://chromium-review.googlesource.com/1143464
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576505}
[modify] https://crrev.com/705e1516d4fc03389818f4af57f48b4b6f5f7a88/ios/chrome/content_widget_extension/content_widget_view.h
[modify] https://crrev.com/705e1516d4fc03389818f4af57f48b4b6f5f7a88/ios/chrome/content_widget_extension/content_widget_view.mm
[modify] https://crrev.com/705e1516d4fc03389818f4af57f48b4b6f5f7a88/ios/chrome/content_widget_extension/content_widget_view_controller.mm

Status: Fixed (was: Started)
Labels: UIRefresh-NoMerge
Status: Verified (was: Fixed)
Verified on iPhone SE iOS 11.3 on 70.0.3509.0 Canary
Today’s view “Show More” in Chrome - Suggested Sites shows additional information.

Sign in to add a comment