Issue metadata
Sign in to add a comment
|
Move fuzzer helper functions to toolchain-funcs eclass |
||||||||||||||||||||||||
Issue descriptionCurrently, many of the fuzzing helper function are in platform eclass. As a result, packages not using platform eclass need top copy the logic in the ebuilds. Move the functions to toolchain-funcs eclass so that all apckages can use it.
,
Jul 8
,
Jul 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ecf47e0524a1ac9624cc1c3d1479ed66a240a186 commit ecf47e0524a1ac9624cc1c3d1479ed66a240a186 Author: Manoj Gupta <manojgupta@google.com> Date: Sun Jul 08 21:48:32 2018 platform: Fix an incorrect comment in fuzzer_test function. BUG= chromium:860785 TEST=None Change-Id: I639b5e688e8f0d16f167814f0ff0b25728f644e4 Reviewed-on: https://chromium-review.googlesource.com/1128565 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/ecf47e0524a1ac9624cc1c3d1479ed66a240a186/eclass/platform.eclass
,
Jul 9
can we please create a new cros-specific eclass here rather than continuing to override standard Gentoo ones ?
,
Jul 9
I agree that that cros-specific additions should preferably be done in a separate eclass but then I don't know the reasons/history behind over-riding the Gentoo's toolchain-funcs eclass in the first place.
,
Jul 9
since the fuzzer integration is new, i don't think pre-existing choices about toolchain-fucns need to be hashed out. just start a new cros-fuzzer.eclass or something to hold these funcs.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97 commit 7b13b11cc511f4f423de4d7e01ff63dd2c12ec97 Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jul 13 09:22:25 2018 fuzzing: Move fuzzing related functions to cros-fuzzer eclass. BUG= chromium:860785 TEST=amd64-generic-fuzzer tryjob passed. Change-Id: I2d47643c393b8c46013ec7047b193e870ee1c58c Reviewed-on: https://chromium-review.googlesource.com/1135584 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/media-libs/virglrenderer/virglrenderer-9999.ebuild [modify] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/media-libs/virglrenderer/virglrenderer-0.6.0_p20180615.ebuild [modify] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/chromeos-base/libchrome/libchrome-395517.ebuild [add] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/eclass/cros-fuzzer.eclass [add] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/media-libs/virglrenderer/virglrenderer-0.6.0_p20180615-r1.ebuild [rename] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/chromeos-base/libchrome/libchrome-395517-r33.ebuild [modify] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/chromeos-base/libmojo/libmojo-395517.ebuild [modify] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/eclass/platform.eclass [rename] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/chromeos-base/libmojo/libmojo-395517-r5.ebuild [modify] https://crrev.com/7b13b11cc511f4f423de4d7e01ff63dd2c12ec97/eclass/toolchain-funcs.eclass
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/docs/+/1d7e75dbb290265da317a564d3578cc06018f9d8 commit 1d7e75dbb290265da317a564d3578cc06018f9d8 Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jul 20 01:20:53 2018 fuzzing: Recommend cros-fuzzer eclass. We have refactored most of the fuzzing functions into cros-fuzzer eclass. Update docs to reflect that. BUG= chromium:860785 TEST=None Change-Id: Iefac7c1effa9a6459b28843ebe0dab27f2804e23 Reviewed-on: https://chromium-review.googlesource.com/1144443 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/1d7e75dbb290265da317a564d3578cc06018f9d8/fuzzing.md |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 7